You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Onboarding modal not show when the invited member who not complete onboarding login #84436
Version Number: v9.3.32-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/test-runs/TR-7800/folder/13176677/41237677/1233303116 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: Win 11/Chrome App Component: Other
Action Performed:
Go to OldDot staging.expensify.com > Choose the "Manage expenses for 1-9 employees" option and sign up with a new account
Once on NewDot - don't complete the onboarding modal, exit the browser
Another account invite the created account to a Collect workspace via OldDot as a member
As the invited member again, open staging.new.expensify.com and login
Please re-state the problem that we are trying to solve in this issue.
When a user signs up via OldDot, lands on NewDot but exits the browser before completing the onboarding modal, then gets invited to a Collect workspace via OldDot, and logs back into NewDot — the onboarding modal is not shown. It should still appear since the user never completed onboarding.
When the user is invited to a Collect workspace via OldDot, the backend sets hasNonPersonalPolicy = true (because the user now belongs to a non-personal policy). This is returned via OpenApp/ReconnectApp and stored in Onyx. On the next NewDot login, isInvitedOrGroupMember evaluates to true, causing shouldSkipOnboarding to be true — even though hasCompletedGuidedSetupFlow is explicitly false (the user started but never completed onboarding).
The isInvitedOrGroupMember condition was designed to skip the onboarding modal for users who were invited to NewDot (they get an alternative invite-specific onboarding via guided setup messages). However, it doesn't distinguish between "invited user who never started onboarding" and "organic user who started onboarding but was later added to a workspace."
What changes do you think we should make in order to solve the problem?
Modify the isInvitedOrGroupMember condition in OnboardingGuard.ts:165 to not skip onboarding when the user has explicitly started but not completed it. Specifically, add a check that hasCompletedGuidedSetupFlow is not explicitly false:
If hasCompletedGuidedSetupFlow is false (user started onboarding but didn't finish) → onboarding is still shown regardless of workspace membership
If hasCompletedGuidedSetupFlow is true → the existing isOnboardingCompleted check handles it
If hasCompletedGuidedSetupFlow is undefined or NVP_ONBOARDING is empty → hasCompletedGuidedSetupFlowSelector already returns true, so isOnboardingCompleted handles it
Invited users who never started onboarding still skip the modal (intended behavior)
What alternative solutions did you explore? (Optional)
Removing hasNonPersonalPolicy from the isInvitedOrGroupMember check entirely — this would be too aggressive, as it would force onboarding on legitimate invited workspace members who should skip it.
Adding a separate isOnboardingExplicitlyStarted flag — functionally equivalent but more verbose. Directly checking onboarding?.hasCompletedGuidedSetupFlow !== false in the existing condition is cleaner.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Onboarding modal not show when the invited member who not complete onboarding login[/-][+][$250] Onboarding modal not show when the invited member who not complete onboarding login[/+]on Mar 6, 2026
Please re-state the problem that we are trying to solve in this issue.
Go to OldDot (staging.expensify.com) → choose "Manage expenses for 1-9 employees" and sign up with a new account. Once on NewDot, do not complete the onboarding modal; exit the browser. Another account invites the created account to a Collect workspace via OldDot as a member. As the invited member, open staging.new.expensify.com and log in. The onboarding modal is not shown.
What is the root cause of that problem?
OnboardingGuard skips the onboarding flow for any user who has hasNonPersonalPolicy === true or wasInvitedToNewDot === true. After the user is invited to a workspace, hasNonPersonalPolicy becomes true, so the guard skips onboarding even when the user never completed the guided setup.
What changes do you think we should make in order to solve the problem?
Only skip onboarding for users with a non-personal policy when they have already completed the guided setup. Users who signed up, left without completing onboarding, and were later invited to a workspace should still see the onboarding modal when they return. Users who joined via an invite link (wasInvitedToNewDot) continue to skip the full flow.
constneedsExplanationModal=(CONFIG.IS_HYBRID_APP&&tryNewDot?.isHybridAppOnboardingCompleted!==true)??false;// Skip onboarding for users with a workspace only when they have completed onboarding (so users who signed up,// left without completing, then were invited to a workspace still see the onboarding modal when they return).// Users who joined via invite link (wasInvitedToNewDot) always skip the full flow.// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescingconstisInvitedOrGroupMember=(!CONFIG.IS_HYBRID_APP&&((hasNonPersonalPolicy&&isOnboardingCompleted)||wasInvitedToNewDot))??false;
⚠️@MugheesMb Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.
$250 to @nkdengineer cuz they where hired, created a PR and requested review.
$125 to @aimane-chnaif cuz that'd be the price for not completing test and, as a best practice, I think work should have been paused after @trjExpensify posted this
Activity
melvin-bot commentedon Mar 6, 2026
Triggered auto assignment to @lydiabarclay (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Mar 6, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user signs up via OldDot, lands on NewDot but exits the browser before completing the onboarding modal, then gets invited to a Collect workspace via OldDot, and logs back into NewDot — the onboarding modal is not shown. It should still appear since the user never completed onboarding.
What is the root cause of that problem?
The
OnboardingGuardatApp/src/libs/Navigation/guards/OnboardingGuard.ts:165computes:This flag is included in the
shouldSkipOnboardingOR-chain at line 174-175:When the user is invited to a Collect workspace via OldDot, the backend sets
hasNonPersonalPolicy = true(because the user now belongs to a non-personal policy). This is returned viaOpenApp/ReconnectAppand stored in Onyx. On the next NewDot login,isInvitedOrGroupMemberevaluates totrue, causingshouldSkipOnboardingto betrue— even thoughhasCompletedGuidedSetupFlowis explicitlyfalse(the user started but never completed onboarding).The
isInvitedOrGroupMembercondition was designed to skip the onboarding modal for users who were invited to NewDot (they get an alternative invite-specific onboarding via guided setup messages). However, it doesn't distinguish between "invited user who never started onboarding" and "organic user who started onboarding but was later added to a workspace."What changes do you think we should make in order to solve the problem?
Modify the
isInvitedOrGroupMembercondition inOnboardingGuard.ts:165to not skip onboarding when the user has explicitly started but not completed it. Specifically, add a check thathasCompletedGuidedSetupFlowis not explicitlyfalse:Change:
To:
This ensures:
hasCompletedGuidedSetupFlowisfalse(user started onboarding but didn't finish) → onboarding is still shown regardless of workspace membershiphasCompletedGuidedSetupFlowistrue→ the existingisOnboardingCompletedcheck handles ithasCompletedGuidedSetupFlowisundefinedor NVP_ONBOARDING is empty →hasCompletedGuidedSetupFlowSelectoralready returnstrue, soisOnboardingCompletedhandles itWhat alternative solutions did you explore? (Optional)
hasNonPersonalPolicyfrom theisInvitedOrGroupMembercheck entirely — this would be too aggressive, as it would force onboarding on legitimate invited workspace members who should skip it.isOnboardingExplicitlyStartedflag — functionally equivalent but more verbose. Directly checkingonboarding?.hasCompletedGuidedSetupFlow !== falsein the existing condition is cleaner.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon Mar 6, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)[-]Onboarding modal not show when the invited member who not complete onboarding login[/-][+][$250] Onboarding modal not show when the invited member who not complete onboarding login[/+]melvin-bot commentedon Mar 6, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022029984185090756051
abbasifaizan70 commentedon Mar 6, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
Go to OldDot (staging.expensify.com) → choose "Manage expenses for 1-9 employees" and sign up with a new account. Once on NewDot, do not complete the onboarding modal; exit the browser. Another account invites the created account to a Collect workspace via OldDot as a member. As the invited member, open staging.new.expensify.com and log in. The onboarding modal is not shown.
What is the root cause of that problem?
OnboardingGuard skips the onboarding flow for any user who has
hasNonPersonalPolicy === trueorwasInvitedToNewDot === true. After the user is invited to a workspace,hasNonPersonalPolicybecomes true, so the guard skips onboarding even when the user never completed the guided setup.App/src/libs/Navigation/guards/OnboardingGuard.ts
Lines 164 to 165 in e26dc41
What changes do you think we should make in order to solve the problem?
Only skip onboarding for users with a non-personal policy when they have already completed the guided setup. Users who signed up, left without completing onboarding, and were later invited to a workspace should still see the onboarding modal when they return. Users who joined via an invite link (
wasInvitedToNewDot) continue to skip the full flow.App/src/libs/Navigation/guards/OnboardingGuard.ts
Lines 163 to 165 in e26dc41
MugheesMb commentedon Mar 6, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
github-actions commentedon Mar 6, 2026
52 remaining items
m-natarajan commentedon Apr 10, 2026
@trjExpensify
Updated the referenced test case
trjExpensify commentedon Apr 10, 2026
@nkdengineer I'm not following you.
So at the time of being invited to the workspace they have
wasInvitedToNewDot: truedon't they?nkdengineer commentedon Apr 10, 2026
No, it's always false for this usủe if the user created account before is invited to a workspace.
trjExpensify commentedon Apr 10, 2026
Shouldn't we set that when someone is invited to a workspace? I guess I'm now confused what
wasInvitedToNewDotis and for.nkdengineer commentedon Apr 21, 2026
@trjExpensify We have two cases:
Eager employee creates an account before being invited to the workspace: This case has no
introSelected-->wasInvitedToNewDotisfalse.Eager employee signs in for the first time after being invited to the workspace: This case has
introSelectedlike this -->wasInvitedToNewDotistruetrjExpensify commentedon Apr 22, 2026
More specifically..
nkdengineer commentedon Apr 22, 2026
@trjExpensify That is the reason why I mentioned we need to fix it in the backend here
trjExpensify commentedon Apr 27, 2026
Alright gotcha, that wasn't clear to me from what was written which didn't mention setting the introSelected / inviteType NVP and values.
nkdengineer commentedon May 18, 2026
@mallenexpensify, please help to handle the full payment here since we completed the PR and reviewed before decided to close this PR as expected.
mallenexpensify commentedon May 20, 2026
Payment Summary
Contributor: @nkdengineer due $250 via NewDot
Contributor+: @aimane-chnaif paid $125 via Upwork.
$250 to @nkdengineer cuz they where hired, created a PR and requested review.
$125 to @aimane-chnaif cuz that'd be the price for not completing test and, as a best practice, I think work should have been paused after @trjExpensify posted this
twisterdotcom commentedon May 21, 2026
$250 approved for @nkdengineer in Report ID: R00O5W9hSjEU.
Zapier Logs
Run ID: 00040eee-3351-a12f-9f8a-46985f75c504SO: https://stackoverflowteams.com/c/expensify/questions/7582