Repository navigation
Description
Details
As part of the loading indicator standardization, we are preparing to enable shouldUseGoBackButton by default in FullscreenLoadingIndicator. Before that, we need to migrate components where FullscreenLoadingIndicator is used alongside visible navigation to use ActivityIndicator instead, otherwise users would see two back controls (the header back button AND the Go Back button from the loader).
LoadingPage.tsx renders HeaderWithBackButton and FullscreenLoadingIndicator as siblings inside ScreenWrapper. The back button is always visible during loading, so the user can already escape, FullscreenLoadingIndicator is unnecessary here and should be replaced with a plain ActivityIndicator.
This component is used in:
BrokenCardFeedConnectionPage.tsxwithReportAndPrivateNotesOrNotFound.tsx
Solution
Replace FullscreenLoadingIndicator with ActivityIndicator in src/pages/LoadingPage.tsx. The loading state must be pixel-perfect identical after the change, same background color, same opacity, same centered large spinner in the content area below the header.
Before making any changes, read the FullscreenLoadingIndicator component source to understand what styles it applies internally, and make sure the replacement reproduces them exactly. ActivityIndicator is a raw spinner with no layout or background styling, so it should not be used on its own as a fullscreen loading state, the codebase convention is to wrap it in a parent View that provides the layout and background styling.
Activity
PiyushChandra17 commentedon Mar 9, 2026
Julesssss commentedon Mar 9, 2026
This is internal
Julesssss commentedon Mar 9, 2026
@MelvinBot investigate this
mateuuszzzzz commentedon Mar 10, 2026
@Julesssss can we re-run it? I updated issue description to be more accurate
mallenexpensify commentedon Mar 10, 2026
Added
Melvin Triageto see if he'll run again (also.. NO idea why I'm here... bye)MelvinBot commentedon Mar 10, 2026
Updated Proposal
(Re-run after issue description update requiring pixel-perfect visual match and View wrapper convention)
Please re-state the problem that we are trying to solve in this issue.
LoadingPage.tsxrenders bothHeaderWithBackButtonandFullScreenLoadingIndicatoras siblings insideScreenWrapper. WhenshouldUseGoBackButtonis enabled by default inFullScreenLoadingIndicator(as part of the loading indicator standardization in #69850), users will see two back controls — the header back button AND the Go Back button from the loader.What is the root cause of that problem?
LoadingPage.tsxusesFullScreenLoadingIndicatorwhich is designed as a full-screen overlay (withStyleSheet.absoluteFillObject, background color, opacity, z-index, and soon a Go Back button). However,LoadingPagealready has its ownHeaderWithBackButton, so the Go Back button behavior is redundant. The component currently only works as expected because the passedstyle={[styles.flex1, styles.pRelative]}overrides the absolute positioning to relative, but it still inherits the full overlay machinery — which will break onceshouldUseGoBackButtondefaults totrue.What changes do you think we should make in order to solve the problem?
In
src/pages/LoadingPage.tsx, replaceFullScreenLoadingIndicatorwith aViewwrapping anActivityIndicatorthat reproduces the exact same visual styling:FullScreenLoadingIndicatorimportView(fromreact-native),ActivityIndicator, andCONST<FullScreenLoadingIndicator style={[styles.flex1, styles.pRelative]} />with:This is pixel-perfect identical because:
styles.fullScreenLoadingprovides:backgroundColor: theme.componentBG,opacity: 0.8,justifyContent: 'center',alignItems: 'center',zIndex: 10— matching the exact visual properties fromFullscreenLoadingIndicatorstyles.flex1makes the View fill the remaining space below the header — matching theflex: 1passed via the original style propabsoluteFillObjectandpRelativecancel each other out (absolute → relative override), andw100is redundant in a flex-1 child — so they can all be dropped<View style={styles.w100}>fromFullscreenLoadingIndicatorhas no visual effect since the parent already centers its children viajustifyContent/alignItemsActivityIndicatorcomponent automatically appliestheme.spinnercolorThis pattern (
View+flex1+fullScreenLoading+ largeActivityIndicator) is the established codebase convention, already used inHelpContent.tsxat line 129.What alternative solutions did you explore? (Optional)
Using a bare
<ActivityIndicator style={[styles.flex1]} />without a wrapping View was considered, but this would not reproduce the background color (theme.componentBG) and opacity (0.8) from the current implementation. The codebase convention is to wrapActivityIndicatorin a parentViewthat provides layout and background styling.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.Julesssss commentedon Mar 10, 2026
@MelvinBot implement this
MelvinBot commentedon Mar 10, 2026
🤖 Draft PR created: #84798
Please mark it as "Ready for review" when it is ready for review.
Julesssss commentedon Mar 10, 2026
PR looks great: #84798
[-]Use valid loading indicator in `LoadingPage.tsx`[/-][+][$125] Use valid loading indicator in `LoadingPage.tsx`[/+]melvin-bot commentedon Mar 16, 2026
melvin-bot commentedon Apr 8, 2026
This issue has not been updated in over 15 days. @Julesssss, @mateuuszzzzz eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!