Skip to content

Hide expired virtual Expensify cards from the Expensify Wallet #84752

Closed

Description

@lakchote

Bug: Expired virtual card still visible in Expensify Wallet

A virtual card ending in 0371 expired on 5 March 2026 but continues to appear in the Expensify Wallet as of 10 March. The issue persists after signing out and back in, ruling out a session or Onyx update problem.

Card assignee: jason@expensify.com
Last 4: 0371
View:

Expected behaviour

The card should be removed from the Wallet once it has expired.

Image

Note: There will be a backend fix to prevent them from being returned in the first place if they are expired. With that being said, we should, as a safety measure, hide them if we encounter them.

Issue OwnerCurrent Issue Owner: @dukenv0307

Activity

  1. self-assigned this
    on Mar 10, 2026
  2. lakchote commented on Mar 10, 2026

    @lakchote
    ContributorAuthor
  3. nkdengineer commented on Mar 10, 2026

    @nkdengineer
    Contributor

    @lakchote Please assign me

  4. lakchote commented on Mar 10, 2026

    @lakchote
    ContributorAuthor

    @lakchote Please assign me

    Done

  5. nkdengineer commented on Mar 11, 2026

    @nkdengineer
    Contributor

    @dukenv0307 The PR is ready for review.

  6. nkdengineer commented on Mar 16, 2026

    @nkdengineer
    Contributor

    @lakchote Raised a follow-up PR cc @dukenv0307

  7. nkdengineer commented on Mar 31, 2026

    @nkdengineer
    Contributor

    @mallenexpensify The PR was deployed to production 2 weeks ago. This is ready for payment.

  8. 2 remaining items

  9. melvin-bot commented on Apr 2, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. mallenexpensify commented on Apr 2, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @nkdengineer due $250 via NewDot
    Contributor+: @dukenv0307 due $250 via NewDot

    @dukenv0307 plz complete the BZ checklist and tag me in a post once you have. Thx

  11. dukenv0307 commented on Apr 13, 2026

    @dukenv0307
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: New requirement

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Has an virtual Expensify Card which is expired

    Test:

    1. Go Home page
    2. Notice the Assigned cards section
    3. Verify that the expired card is not displayed

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-a218-a726-a8f7-4ea3cab78474
  12. dukenv0307 commented on Apr 13, 2026

    @dukenv0307
    Contributor
  13. garrettmknight commented on Apr 14, 2026

    @garrettmknight
    Contributor

    $250 approved for @dukenv0307

  14. twisterdotcom commented on Apr 22, 2026

    @twisterdotcom
    Contributor

    @nkdengineer has submitted payment for this report on ND here.

    SO: https://stackoverflowteams.com/c/expensify/questions/7582

    Zapier Logs Run ID: 00040eee-518c-a458-bfe3-1c68287e8be4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions