Skip to content

[Due for payment 2026-04-07] React Compiler compliance check blocked in AI code reviewer #85070

Closed

Description

@kacper-mikolajczak

Background

The Expensify App repo uses claude-code-action to run automated code reviews on every PR via .github/workflows/claude-review.yml. The reviewer agent operates in a restricted sandbox where only explicitly whitelisted Bash commands are permitted through the allowedTools parameter - currently limited to gh pr diff and gh pr view. Separately, a coding standards rule (CLEAN-REACT-PATTERNS-0) instructs the reviewer to verify whether a file compiles with React Compiler before flagging manual memoization as redundant.

Problem

When the reviewer agent tries to verify React Compiler compliance per the rule's instructions, it cannot execute the npx react-compiler-healthcheck command due to the allowedTools whitelist, which prevents it from distinguishing files that compile (where manual memoization is redundant) from files that don't (where manual memoization may be necessary).

Image

Solution

Replace the npx react-compiler-healthcheck instruction with npm run react-compiler-compliance-check check <filepath> - an existing repo script that wraps the same healthcheck. Add Bash(npm run react-compiler-compliance-check:*) to the allowedTools in both claude-review.yml and review-code-pr.md. Update the rule's verification command accordingly.

PR: #85067

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. kacper-mikolajczak commented on Mar 12, 2026

    @kacper-mikolajczak
    ContributorAuthor
  2. kacper-mikolajczak commented on Mar 18, 2026

    @kacper-mikolajczak
    ContributorAuthor

    Next step: Observe how reviewer picks up the script

  3. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 23, 2026
  4. changed the title [-]React Compiler compliance check blocked in AI code reviewer[/-] [+][Due for payment 2026-03-30] React Compiler compliance check blocked in AI code reviewer[/+] on Mar 23, 2026
  5. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  6. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-30. 🎊

    For reference, here are some details about the assignees on this issue:

  7. 7 remaining items

  8. Julesssss commented on Mar 26, 2026

    @Julesssss
    Contributor

    No payment required. PR merged

  9. changed the title [-]React Compiler compliance check blocked in AI code reviewer[/-] [+][Due for payment 2026-04-07] React Compiler compliance check blocked in AI code reviewer[/+] on Mar 31, 2026
  10. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-07. 🎊

    For reference, here are some details about the assignees on this issue:

  12. removed their assignment
    on Apr 6, 2026
  13. melvin-bot commented on Apr 7, 2026

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  14. mountiny commented on Apr 10, 2026

    @mountiny
    Contributor

    I think we can close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions