Skip to content

[Due for payment 2026-03-24] Bank account - Employee lands on wallet page after adding PBA from expense details page #85191

New issue
New issue
Closed
Closed
[Due for payment 2026-03-24] Bank account - Employee lands on wallet page after adding PBA from expense details page#85191
Assignees
nkuochmjasikowskimallenexpensifycollectioneur
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringWeeklyKSv2

Description

@jponikarchuk
jponikarchuk
opened on Mar 13, 2026

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.3.37.0
Reproducible in staging?: Yes
Reproducible in production?: Unable to validate in Prod - Provide reasoning.
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-8761/folder/13176702/41236794/1247679782
Email or phone of affected tester (no customers): kiatest.78+ck31226100@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 11/Chrome, iPhone 16/iOS 18.7.1, Pixel 8a/Android 16
App Component: Money Requests

Action Performed:

Precondition :

  1. Admin has set up bank account (VBA) in workspace settings
  2. Admin has invited member to workspace
  3. Employee has submitted expense in workspace chat
  4. Admin has approved & paid employee's expense with VBA
    Steps:
  5. Navigate to staging.new.expensify.com or launch hybrid app
  6. Log in as employee
  7. Go to expense details page
  8. Click "Add Bank account" button
  9. Add personal bank account (use Regions bank >> 0000 checking account)
  10. Tap Continue button on bank account added animation page
  11. Observe user redirected to wallet page instead of expense details page

Expected Result:

After adding PBA & tapping continue button in animation page, user should be redirected to expense details page showing Paid status & system message displayed as "paid with bank account xxxx via Workspace rules"

Actual Result:

Employee lands on wallet page instead of expense details page after adding PBA & tapping continue button in animation page. Tapping back button from wallet page, navigates user to add bank account page & where's your bank located page, then displaying before expense details page

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

bandicam.2026-03-13.08-22-05-927.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @collectioneur

Activity

  1. jponikarchuk
    added
    MonthlyKSv2
    Not a priority
    on Mar 13, 2026
  2. jponikarchuk
    added this to #expensify-bugson Mar 13, 2026
  3. jponikarchuk
    added
    DeployBlockerCashThis issue or pull request should block deployment
    DailyKSv2
    and removed
    MonthlyKSv2
    Not a priority
    on Mar 13, 2026
  4. melvin-bot
    assigned
    nkuoch
    on Mar 13, 2026

  5. melvin-bot commented on Mar 13, 2026

    @melvin-bot
    melvin-botBot
    on Mar 13, 2026 – with Melvin Bot

    Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  6. melvin-bot commented on Mar 13, 2026

    @melvin-bot
    melvin-botBot
    on Mar 13, 2026 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Mar 13, 2026

  8. github-actions commented on Mar 13, 2026

    @github-actions
    github-actionsBot
    on Mar 13, 2026 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. OSBotify commented on Mar 13, 2026

    @OSBotify
    OSBotify
    on Mar 13, 2026
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #84158 - "Implement query parameters handling in dynamic routes" by @collectioneur (High confidence)
    Related Issues: None found

    Recommendation: REVERT

    PR #84158 introduced significant changes to the navigation system for handling query parameters in dynamic routes. While the changes were well-intentioned to support query params in dynamic routes (like country?country=US), they appear to have introduced a regression in the bank account setup flow navigation.

    Labels: Keeping DeployBlockerCash - this is a frontend bug affecting the App deploy

    📋 Detailed Analysis

    Evidence

    PR #84158 modified core navigation helpers and specifically touched the exact flow mentioned in this bug:

    • Modified src/libs/Navigation/helpers/dynamicRoutesUtils/getPathWithoutDynamicSuffix.ts - added query parameter stripping logic
    • Modified src/libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute.ts - added query parameter merging logic
    • Modified src/libs/actions/BankAccounts.ts - imports for the new navigation helpers
    • Modified src/pages/settings/Wallet/WalletPage/index.tsx and PaymentMethodList.tsx
    • Merged on 2026-03-12 at 12:45:41 (position Add unread notifications to the LHN #28 in the staging deploy chronological list)

    The PR test steps specifically included:

    "Navigate to Settings -> Wallet -> Add Bank Account and log into the US bank account... While on the address step, open the country page."

    This matches the affected flow in this bug report.

    Verification

    The bug occurs when:

    1. User is on expense details page
    2. Clicks "Add Bank account" button to add personal bank account (PBA)
    3. Completes the flow and clicks Continue on the success animation page
    4. Expected: Return to expense details page
    5. Actual: User lands on wallet page instead

    Files affected by the bug:

    • /home/runner/_work/App/App/src/pages/AddPersonalBankAccountPage.tsx - handles the success page and Continue button
    • /home/runner/_work/App/App/src/libs/actions/PaymentMethods.ts - continueSetup function that handles navigation after success
    • /home/runner/_work/App/App/src/libs/Navigation/helpers/dynamicRoutesUtils/getPathWithoutDynamicSuffix.ts - navigation helper modified by PR Implement query parameters handling in dynamic routes #84158

    PR #84158 modified the navigation logic that determines how to navigate back after completing a dynamic route flow, which directly impacts the bank account setup completion navigation.

    Root Cause

    The PR refactored how dynamic routes handle query parameters and navigation. The changes to getPathWithoutDynamicSuffix.ts and related navigation helpers likely broke the navigation chain that should return users to the expense details page after adding a bank account. Instead, the navigation falls back to the default wallet page.

    Specifically, the getPathWithoutDynamicSuffix function now returns an empty string when the path becomes empty or / (lines 40-42), and the query parameter stripping logic may be interfering with preserving the correct navigation context.

  10. 5 remaining items

  11. mjasikowski commented on Mar 13, 2026

    @mjasikowski
    mjasikowski
    on Mar 13, 2026
    Contributor

    Will merge the PR fix in a moment and request CP

  12. mjasikowski commented on Mar 13, 2026

    @mjasikowski
    mjasikowski
    on Mar 13, 2026
    Contributor

    CP requested here: https://expensify.slack.com/archives/C07J32337/p1773403933760359

  13. luacmartins commented on Mar 13, 2026

    @luacmartins
    luacmartins
    on Mar 13, 2026
    Contributor

    It seems like this is fixed #85191 (comment). Closing.

  14. luacmartins
    closed this as completedon Mar 13, 2026
  15. github-project-automation
    moved this to Done in #expensify-bugson Mar 13, 2026
  16. luacmartins
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 13, 2026
  17. melvin-bot
    added
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    HourlyKSv2
    on Mar 17, 2026
  18. melvin-bot
    changed the title [-]Bank account - Employee lands on wallet page after adding PBA from expense details page[/-] [+][Due for payment 2026-03-24] Bank account - Employee lands on wallet page after adding PBA from expense details page[/+] on Mar 17, 2026
  19. melvin-bot
    removed
    ReviewingHas a PR in review
    on Mar 17, 2026

  20. melvin-bot commented on Mar 17, 2026

    @melvin-bot
    melvin-botBot
    on Mar 17, 2026 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  21. melvin-bot commented on Mar 17, 2026

    @melvin-bot
    melvin-botBot
    on Mar 17, 2026 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.38-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-24. 🎊

    For reference, here are some details about the assignees on this issue:

  22. melvin-bot commented on Mar 17, 2026

    @melvin-bot
    melvin-botBot
    on Mar 17, 2026 – with Melvin Bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  23. melvin-bot
    assigned
    mallenexpensify
    on Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions