Skip to content

[Due for payment 2026-03-30] [Domain Control] [Release 4] [FE] Hide member-level "Force two-factor authentication" toggle when domain 2FA is not enabled #85208

Closed

Description

@mountiny

Problem

On the Domain Member details page, there is a per-member "Force two-factor authentication" toggle that controls whether a specific member is in the twoFactorAuthExemptEmails list. This toggle is currently shown unconditionally — even when the domain itself does not require 2FA (twoFactorAuthRequired is false).

When the domain does not have 2FA enabled, this per-member toggle is misleading: toggling it ON does not actually force the member to use 2FA. The member-level toggle only controls exemptions from the domain-level requirement, so it has no effect when there is no domain-level requirement to be exempt from.

This was confirmed in OldDot as well — the toggle exists but has no functional impact when the domain 2FA setting is off.

Related test case: #84809 (comment) (see "Enable 2FA for Specific Member" section)

Proposal

Hide the per-member "Force two-factor authentication" toggle row on the Domain Member details page when domainSettings.twoFactorAuthRequired is falsy.

The fix is in src/pages/domain/Members/DomainMemberDetailsPage.tsx — wrap the ToggleSettingOptionRow (lines 145-165) in a conditional:

{!!domainSettings?.twoFactorAuthRequired && (
    <ToggleSettingOptionRow
        ...
    />
)}

The domainSettings object is already fetched in this component, so no additional data fetching is needed.

Issue OwnerCurrent Issue Owner: @mallenexpensify
Issue OwnerCurrent Issue Owner: @war-in

Activity

  1. mountiny commented on Mar 13, 2026

    @mountiny
    ContributorAuthor
  2. changed the title [-]Hide member-level "Force two-factor authentication" toggle when domain 2FA is not enabled[/-] [+][Release 4] Hide member-level "Force two-factor authentication" toggle when domain 2FA is not enabled[/+] on Mar 13, 2026
  3. changed the title [-][Release 4] Hide member-level "Force two-factor authentication" toggle when domain 2FA is not enabled[/-] [+][Domain Control] [Release 4] [FE] Hide member-level "Force two-factor authentication" toggle when domain 2FA is not enabled[/+] on Mar 13, 2026
  4. war-in commented on Mar 13, 2026

    @war-in
    Contributor

    @MelvinBot could you please prepare a PR for this issue?

  5. war-in commented on Mar 13, 2026

    @war-in
    Contributor

    Looks like Melvin already started the weekend, I'll take care of the issue then

  6. 9 remaining items

  7. changed the title [-][Domain Control] [Release 4] [FE] Hide member-level "Force two-factor authentication" toggle when domain 2FA is not enabled[/-] [+][Due for payment 2026-03-30] [Domain Control] [Release 4] [FE] Hide member-level "Force two-factor authentication" toggle when domain 2FA is not enabled[/+] on Mar 23, 2026
  8. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @war-in does not require payment (Contractor)
    • @ZhenjaHorbach requires payment through NewDot Manual Requests
    • @situchan requires payment (Needs manual offer from BZ)
  10. melvin-bot commented on Mar 23, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  11. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @war-in does not require payment (Contractor)
    • Reviewer: @ZhenjaHorbach owed $250 via NewDot
    • ROLE: @situchan paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. ZhenjaHorbach commented on Mar 30, 2026

    @ZhenjaHorbach
    Contributor

    It's a part of the project
    Let's close this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions