[Due for payment 2026-03-25] Investigate workflow job failing on main: test / test (job 7)

@linhvovan29546

🚨 Failure Summary 🚨:

📋 Job Name: test / test (job 7)
🔧 Failure in Workflow: Process new code merged to main
🔗 Triggered by PR: PR Link
👤 PR Author: @linhvovan29546
🤝 Merged by: @tgolen
🐛 Error Message:
warning: Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@8ade135, SimenB/github-actions-cpu-cores@31e91de. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
failure: Process completed with exit code 1.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named test / test (job 7).
🔍 This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

Why the PR caused the job to fail?
Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

Issue Owner

Current Issue Owner: @ShridharGoel

Should be fixed with #85147. Re-running the tests now.

@MelvinBot

@MelvinBot Re-running the test, it still fails. Isn't this fixed on main?

The fix from PR #85147 is included in this re-run (the workflow commit c5fca4f is 48 commits ahead of PR #85147's merge), but the test is still failing because this is a different bug than what #85147 fixed.

PR #85147 fixed: The react-native-permissions mock (RESULTS.GRANTED was undefined due to a bad import path).

This failure is: expo-location's requestForegroundPermissionsAsync() returning undefined, causing TypeError: Cannot read properties of undefined (reading 'status') at src/libs/getCurrentPosition/index.ts:10.

Root Cause

The jest-expo preset mocks all native module methods with jest.fn(async () => {}) (in jest-expo/src/preset/setup.js:234-238), which resolves to undefined instead of a proper PermissionResponse object with a status field. There is no project-level mock for expo-location — no __mocks__/expo-location.ts, no jest.mock('expo-location') in jest/setup.ts, and no moduleNameMapper entry in jest.config.js.

The data flow:

Test triggers getCurrentPosition() → calls await requestForegroundPermissionsAsync() from expo-location
expo-location delegates to native module ExpoLocation.requestForegroundPermissionsAsync()
In tests, jest-expo replaces this with jest.fn(async () => {}) → resolves to undefined
getCurrentPosition/index.ts:10 reads .status on undefined → TypeError

Recommended Fix

The most targeted fix would be one of:

Add a project-level mock for expo-location in jest/setup.ts that returns a proper PermissionResponse:

jest.mock('expo-location', () => ({
  ...jest.requireActual('expo-location'),
  requestForegroundPermissionsAsync: jest.fn(() =>
    Promise.resolve({ status: 'denied', granted: false, canAskAgain: true, expires: 0 })
  ),
}));

Add a defensive null check in getCurrentPosition/index.ts:10:

if (!foregroundPermissionResponse || foregroundPermissionResponse.status !== PermissionStatus.GRANTED) {

Mock getCurrentPosition directly in the test file if only that specific test needs it.

Next Steps: Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.

@MelvinBot

@MelvinBot implement suggestion 1

🤖 Draft PR created: #85257
Please mark it as "Ready for review" when it is ready for review.

@rlinoz

Triggered auto assignment to @rlinoz, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@tgolen

@tgolen Can you assign me here as the reviewer? Thanks

Reviewing label has been removed, please complete the "BugZero Checklist".

@ShridharGoel

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.39-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[No QA] Add expo-location mock to jest setup #85257

If no regressions arise, payment will be issued on 2026-03-25. 🎊

For reference, here are some details about the assignees on this issue:

@ShridharGoel requires payment through NewDot Manual Requests

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Awaiting Payment)

@tgolen

@tgolen should this be $125 for the PR review, without any tests? Guessing so

Yes, I think that makes sense.

@ShridharGoel

Payment Summary

Contributor+: @ShridharGoel due $125 via NewDot

@ShridharGoel

$125 approved for @ShridharGoel

Navigation Menu

Repository navigation

[Due for payment 2026-03-25] Investigate workflow job failing on main: test / test (job 7) #85243

Root Cause

Recommended Fix

2 remaining items

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2026-03-25] Investigate workflow job failing on main: test / test (job 7) #85243

Description

Activity

tgolen commented on Mar 13, 2026

tgolen commented on Mar 13, 2026

MelvinBot commented on Mar 13, 2026

Root Cause

Recommended Fix

tgolen commented on Mar 13, 2026

MelvinBot commented on Mar 13, 2026

melvin-bot commented on Mar 13, 2026

ShridharGoel commented on Mar 13, 2026

2 remaining items

melvin-bot commented on Mar 18, 2026

melvin-bot commented on Mar 18, 2026

melvin-bot commented on Mar 18, 2026

mallenexpensify commented on Mar 24, 2026

tgolen commented on Mar 25, 2026

mallenexpensify commented on Mar 25, 2026

Payment Summary

JmillsExpensify commented on Apr 6, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions