Skip to content

[Due for Payment 2026-03-26] Payment issue for E/App PR#84159 #85536

Closed

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #84159
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/604683.
Contributor+ member who reviewed the PR - @jayeshmangwani.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Mar 17, 2026
  2. melvin-bot commented on Mar 17, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  3. changed the title [-]Payment issue for E/App PR#84159[/-] [+][Due for Payment 2026-03-26] Payment issue for E/App PR#84159[/+] on Mar 19, 2026
  4. jayeshmangwani commented on Mar 24, 2026

    @jayeshmangwani
    Contributor

    Regression Test Proposal

    Preconditions:

    • The admin owns a private domain.
    • Sign up for another account using the same domain, then validate that user by going to:
      Account > Profile > Contact Methods > Tap your email > Enter the magic code

    Test 1: Auto-Join Scenario

    1. In OldDot, go to Workspace Settings > Overview.
    2. Enable Pre-approve join requests from validated users at [domain].
    3. As the admin, go to Workspace Settings > Overview > More > Share, then copy the URL.
    4. As another user from the same domain (who is not a workspace member), open the URL.
      As the admin, go to the #admins room.
    5. Verify:
      • The message says: [email] joined via the workspace invite link.
      • The message actor is notifications@expensify.com.

    Test 2: Non Auto-Join Scenario

    1. As another user from a different domain (who is not a workspace member), open the invite URL.
    2. As the admin, go to the #admins room.
    3. Click Accept.
    4. Verify:
      • The message says: added [user] as a member.
      • The message actor is the admin.

    Test 3: Manual Invite Scenario

    1. As the admin, go to the Workspace Members page.
    2. Invite a new user.
    3. Go to the #admins room.
    4. Verify:
      • The message says: added [user] as a member.
      • The message actor is the admin.

    Do we agree 👍 or 👎

  5. jayeshmangwani commented on Mar 24, 2026

    @jayeshmangwani
    Contributor

    This was not a bug but an improvement, so I’ve added the regression proposal above.

  6. mallenexpensify commented on Mar 24, 2026

    @mallenexpensify
    Contributor

    Thanks @jayeshmangwani test case created (unsure where it's best for C+ to post, thanks for doing so here)

  7. mallenexpensify commented on Mar 26, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @jayeshmangwani due $250 via NewDot

  8. trjExpensify commented on Mar 30, 2026

    @trjExpensify
    Contributor

    approved $250 for @jayeshmangwani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions