Skip to content

[BT-011] Implement Tab Navigator Resolution for Dynamic Routes #85750

Closed

Description

@mjasikowski

Description

Current State:

  • The dynamic route permission check only validates the deepest (leaf) route in a dynamic route chain
  • If the leaf route is not an authorized entry screen, the router returns Not Found, even though a parent route in the chain is a valid entry screen
  • Example: URL /debug/report/123/details/constant-picker — the router only checks ConstantPicker, which is not an allowed entry screen, and returns Not Found. But Debug is a valid entry screen, so the URL should be allowed
  • There is existing related logic in findFocusedRouteWithOnyxTabGuard that partially handles this but needs adaptation for dynamic routes

Expected State:

  • The permission check should validate the entire route chain, not just the leaf route
  • If any parent route in the chain is an authorized entry screen, the dynamic route should be allowed
  • Tab navigators should be properly resolved when building navigation state for dynamic routes
  • This should leverage and extend the existing findFocusedRouteWithOnyxTabGuard logic rather than modifying getPathFromState

Context:

Scope

Files:

  • App/src/libs/Navigation/helpers/getAdaptedStateFromPath.ts - Update permission validation to check full route chain
  • App/src/libs/Navigation/helpers/findFocusedRouteWithOnyxTabGuard.ts - Extend for dynamic route tab resolution
  • Related navigation utility files

Dependencies:

Issue OwnerCurrent Issue Owner: @huult

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    on Mar 19, 2026
  2. added
    ReviewingHas a PR in review
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Mar 19, 2026
  3. changed the title [-][BT-011] Implement Tab Navigator Resolution for Dynamic Routes[/-] [+][Due for payment 2026-03-31] [BT-011] Implement Tab Navigator Resolution for Dynamic Routes[/+] on Mar 24, 2026
  4. melvin-bot commented on Mar 24, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  5. melvin-bot commented on Mar 24, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.42-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-03-31. 🎊

    For reference, here are some details about the assignees on this issue:

    • @huult requires payment through NewDot Manual Requests
    • @collectioneur does not require payment (Contractor)
  6. melvin-bot commented on Mar 24, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  7. mjasikowski commented on Mar 24, 2026

    @mjasikowski
    ContributorAuthor

    No payment needed - fixed price project

  8. changed the title [-][Due for payment 2026-03-31] [BT-011] Implement Tab Navigator Resolution for Dynamic Routes[/-] [+][BT-011] Implement Tab Navigator Resolution for Dynamic Routes[/+] on Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions