Repository navigation
[HOLD for payment 2022-06-16] [HOLD for payment 2022-06-15] [$500] Uploading an image causes the thumbnail to resize 3 times #8590
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Open any chat
- Upload a larger file to share
Expected Result:
Thumbnail should load once uploaded, or if it's a large file it should display a spinner until it's uploaded.
Actual Result:
If you share an image, the uploading thumbnail resizes 3 times. Then it finalizes the upload.
Workaround:
Just wait for the file to upload but it's a jarring experience.
Platform:
Where is this issue occurring?
- Web
Version Number: 1.1.52-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
If you click + > add attachment in a DM, and then select this attachment:
You'll notice it changes to this momentarily:
And then this:
Upwork job URL: https://www.upwork.com/jobs/~01ca59e5811fecf4d5
Issue reported by: @cead22
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1649352167230159
Activity
melvin-bot commentedon Apr 11, 2022
Triggered auto assignment to @iwiznia (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.melvin-bot commentedon Apr 11, 2022
Triggered auto assignment to @michaelhaxhiu (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.[-] when sharing an image the thumbnail resizes 3 times [/-][+]Uploading an image causes the thumbnail to resize 3 times [/+]melvin-bot commentedon Apr 11, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (
Exported)116 remaining items
melvin-bot commentedon Jun 9, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.74-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-06-16. 🎊
[-][HOLD for payment 2022-06-15] [$500] Uploading an image causes the thumbnail to resize 3 times [/-][+][HOLD for payment 2022-06-16] [HOLD for payment 2022-06-15] [$500] Uploading an image causes the thumbnail to resize 3 times [/+]michaelhaxhiu commentedon Jun 16, 2022
Ok so payment is due today. I'm seeing a regression here and so the payout structure would be:
michaelhaxhiu commentedon Jun 16, 2022
Awaiting confirmation from Chirag for this, as I'm alittle unsure about this regression 👆
chiragsalian commentedon Jun 16, 2022
I don't feel a penalty for this regression is required for C+ because the PR was testing thumbnail loading and not really the attachment modal. So QA finding a regression with attachment modal would have been very hard to catch in the normal PR and hence i don't feel there should be a penalty for the C+.
(P.S i also tested the PR on different devices and would not have thought to test the attachment modal the way QA did)
michaelhaxhiu commentedon Jun 16, 2022
Got it, so it seems you are saying this was out of scope of C+ responsibility.
Did we make the necessary changes to our process to ensure we don't miss this testing step again?
chiragsalian commentedon Jun 16, 2022
I feel like the issue caught by QA was out of the scope of the C+ responsibility since its quite the edge case.
Also technically even QA tested and cleared the PR without realizing any issue with it and later found the regression issue. Most likely from their checklist of complete app testing steps.
I'm not sure what can be done differently other than expecting our C+ to do the same regression testing as QA but this list is huge and not worth it for the C+ to go over so im unsure. Maybe we can recommend people to test a bit more beyond the PR's expectation. Not sure but thats a discussion for slack.
michaelhaxhiu commentedon Jun 16, 2022
Got it! Thanks for the context.
In that case, it seems like the feedback is for QA so they don't miss it next time. Sometimes our regressions are QAs fault, I think that's going to happen from time to time!
michaelhaxhiu commentedon Jun 16, 2022
@allroundexperts is paid.
@Santhosh-Sellavel can you apply for this upwork job? the OG link expired
Santhosh-Sellavel commentedon Jun 17, 2022
@michaelhaxhiu Applied for the job!
michaelhaxhiu commentedon Jun 17, 2022
All are paid.
allroundexperts commentedon Oct 11, 2022