You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-03-31] [Due for payment 2026-03-30] mWeb - Create Expense - “Hmm It's Not Here” page appears after deleting an expense #85954
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #79962 - "Upgrade React Native to v0.83" by @marcochavezf (High confidence) Related Issues: None identified
Recommendation: ROLL FORWARD
The React Native upgrade to v0.83 is a large, complex PR that touches core navigation infrastructure. Reverting this PR would be extremely disruptive as it:
Upgrades React Native from v0.76 to v0.83
Upgrades Expo from v52 to v55
Includes numerous dependency updates and patches
Has been in testing for weeks
Required full regression testing
A targeted fix for the expense deletion navigation issue will be much safer and faster than reverting this massive upgrade.
Labels: No label changes made. Keeping DeployBlockerCash as this is a frontend bug that needs to be fixed before mobile deploy.
Detailed Analysis
Evidence
The bug occurs when:
User is viewing an expense in a 1:1 DM that contains multiple expenses
User deletes one expense
Expected: Navigate to another expense in the same report
Actual: Shows "Hmm, its not here" page (NotFoundPage)
This is a staging-only bug (not reproducible in production), and the timeframe aligns with PR #79962 being merged on 2026-03-19 into the 9.3.41-3 deploy.
The React Native v0.83 upgrade includes changes to navigation behavior in react-navigation which could affect how the app determines the fallback route after deleting a transaction.
Root Cause
The React Native upgrade likely changed how navigation state is managed when a screen is removed from the stack. When deleting an expense, the app needs to navigate to:
The parent report (if only one transaction remains)
Another transaction in the same report (if multiple transactions exist)
The upgrade appears to have broken scenario #2, causing the app to navigate to the NotFoundPage instead of finding another transaction in the same report.
Recommended Fix
Create a targeted PR that:
Updates the delete transaction navigation logic to properly handle multiple transactions in a report
Ensures compatibility with React Native v0.83 navigation behavior
Tests the specific scenario: deleting an expense when multiple expenses exist in the same report
Please re-state the problem that we are trying to solve in this issue.
When a user opens an expense from a multi-expense report (entering the transaction thread view) and deletes it via More > Delete, a "Hmm... it's not here" page appears instead of redirecting to the remaining expense(s) in the report. This is reproducible in staging (v9.3.41-3) but not in production.
What is the root cause of that problem?
There is a race condition in MoneyRequestHeader.tsx between two Onyx updates that fire during expense deletion.
When the user deletes an expense from the transaction thread view, MoneyRequestHeader (line 611) calls setDeleteTransactionNavigateBackUrl(backToRoute) to set a guard URL in Onyx, and then immediately (line 629) calls deleteTransactions() which triggers deleteMoneyRequest() → API.write() with optimistic data that sets the parent report action to pendingAction: DELETE and the transaction thread report's reportID to null.
In ReportScreen.tsx (lines 518-520), the shouldShowNotFoundPage logic checks:
If deleteTransactionNavigateBackUrl is set → suppress the not-found page (return false)
If isDeletedTransactionThread is true → show the not-found page (return true)
Both values come from separate useOnyx subscriptions (which use useSyncExternalStore internally). If the optimistic data from API.write() reaches the component before the Onyx.set() for the guard URL propagates, there is a render frame where isDeletedTransactionThread = true but deleteTransactionNavigateBackUrl = undefined, causing the "Hmm... it's not here" page to appear.
This race condition is likely worsened in the current staging build due to the React 19.1→19.2 and React Native 0.81.4→0.83.1 upgrades, which may have changed useSyncExternalStore batching/scheduling behavior, plus the TransitionTracker V2 revert (PR #85700) which changed navigation timing fundamentals.
Notably, MoneyReportHeader.tsx (the header for the expense report view) already has a fix for this exact problem at lines 2050-2056, with a comment that explicitly acknowledges the bug:
// it's deleting transaction but not the report which leads to bug (that is actually also on staging)
// Money request should be deleted when interactions are done, to not show the not found page before navigating to goBackRoute
InteractionManager.runAfterInteractions(() => {
deleteTransactions([transaction.transactionID], ...);
removeTransaction(transaction.transactionID);
});
MoneyRequestHeader.tsx (the header for the individual transaction thread view) lacks this protection — it calls deleteTransactions() and removeTransaction() immediately without deferring via InteractionManager.runAfterInteractions.
What changes do you think we should make in order to solve the problem?
In MoneyRequestHeader.tsx (lines 628-631), wrap the deleteTransactions and removeTransaction calls inside InteractionManager.runAfterInteractions(), matching the pattern already used in MoneyReportHeader.tsx:
Before (current code at MoneyRequestHeader.tsx:628-631):
Also move the navigation calls (lines 632-637) to happen before the deferred deletion, similar to how MoneyReportHeader navigates first and then defers the delete.
What alternative solutions did you explore? (Optional)
Include setDeleteTransactionNavigateBackUrl in the optimistic data of deleteMoneyRequest: This would guarantee both Onyx updates are in the same batch. However, this would require modifying the shared deleteMoneyRequest function in IOU/index.ts, which has a wider blast radius.
Use Onyx.update() to batch both updates atomically: This would ensure the guard URL and the deletion optimistic data arrive in the same render cycle, but would require significant refactoring of how setDeleteTransactionNavigateBackUrl is called.
The recommended approach (deferring via InteractionManager.runAfterInteractions) is the simplest fix, matches the existing pattern in MoneyReportHeader, and directly addresses the timing issue.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
I don't think that deploy blocker was correctly linked to React Native upgrade issue. I verified the flow on the latest adhoc build from when we merged the PR and it works there.
changed the title [-]mWeb - Create Expense - “Hmm It's Not Here” page appears after deleting an expense[/-][+][Due for payment 2026-03-30] mWeb - Create Expense - “Hmm It's Not Here” page appears after deleting an expense[/+]on Mar 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-03-30] mWeb - Create Expense - “Hmm It's Not Here” page appears after deleting an expense[/-][+][Due for payment 2026-03-31] [Due for payment 2026-03-30] mWeb - Create Expense - “Hmm It's Not Here” page appears after deleting an expense[/+]on Mar 24, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.42-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@JS00001@mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Mar 20, 2026
Triggered auto assignment to @JS00001 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Mar 20, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 20, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 20, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #79962 - "Upgrade React Native to v0.83" by @marcochavezf (High confidence)
Related Issues: None identified
Recommendation: ROLL FORWARD
The React Native upgrade to v0.83 is a large, complex PR that touches core navigation infrastructure. Reverting this PR would be extremely disruptive as it:
A targeted fix for the expense deletion navigation issue will be much safer and faster than reverting this massive upgrade.
Labels: No label changes made. Keeping
DeployBlockerCashas this is a frontend bug that needs to be fixed before mobile deploy.Detailed Analysis
Evidence
The bug occurs when:
This is a staging-only bug (not reproducible in production), and the timeframe aligns with PR #79962 being merged on 2026-03-19 into the
9.3.41-3deploy.Verification
PR #79962 modified navigation-related files:
patches/react-native/react-native+0.83.1+013+fixNavigationAnimations.patchsrc/libs/Navigation/AppNavigator/createRootStackNavigator/GetStateForActionHandlers.tsThe React Native v0.83 upgrade includes changes to navigation behavior in react-navigation which could affect how the app determines the fallback route after deleting a transaction.
Root Cause
The React Native upgrade likely changed how navigation state is managed when a screen is removed from the stack. When deleting an expense, the app needs to navigate to:
The upgrade appears to have broken scenario #2, causing the app to navigate to the NotFoundPage instead of finding another transaction in the same report.
Recommended Fix
Create a targeted PR that:
MelvinBot commentedon Mar 20, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user opens an expense from a multi-expense report (entering the transaction thread view) and deletes it via More > Delete, a "Hmm... it's not here" page appears instead of redirecting to the remaining expense(s) in the report. This is reproducible in staging (v9.3.41-3) but not in production.
What is the root cause of that problem?
There is a race condition in
MoneyRequestHeader.tsxbetween two Onyx updates that fire during expense deletion.When the user deletes an expense from the transaction thread view,
MoneyRequestHeader(line 611) callssetDeleteTransactionNavigateBackUrl(backToRoute)to set a guard URL in Onyx, and then immediately (line 629) callsdeleteTransactions()which triggersdeleteMoneyRequest()→API.write()with optimistic data that sets the parent report action topendingAction: DELETEand the transaction thread report'sreportIDtonull.In
ReportScreen.tsx(lines 518-520), theshouldShowNotFoundPagelogic checks:deleteTransactionNavigateBackUrlis set → suppress the not-found page (return false)isDeletedTransactionThreadis true → show the not-found page (return true)Both values come from separate
useOnyxsubscriptions (which useuseSyncExternalStoreinternally). If the optimistic data fromAPI.write()reaches the component before theOnyx.set()for the guard URL propagates, there is a render frame whereisDeletedTransactionThread = truebutdeleteTransactionNavigateBackUrl = undefined, causing the "Hmm... it's not here" page to appear.This race condition is likely worsened in the current staging build due to the React 19.1→19.2 and React Native 0.81.4→0.83.1 upgrades, which may have changed
useSyncExternalStorebatching/scheduling behavior, plus the TransitionTracker V2 revert (PR #85700) which changed navigation timing fundamentals.Notably,
MoneyReportHeader.tsx(the header for the expense report view) already has a fix for this exact problem at lines 2050-2056, with a comment that explicitly acknowledges the bug:MoneyRequestHeader.tsx(the header for the individual transaction thread view) lacks this protection — it callsdeleteTransactions()andremoveTransaction()immediately without deferring viaInteractionManager.runAfterInteractions.What changes do you think we should make in order to solve the problem?
In
MoneyRequestHeader.tsx(lines 628-631), wrap thedeleteTransactionsandremoveTransactioncalls insideInteractionManager.runAfterInteractions(), matching the pattern already used inMoneyReportHeader.tsx:Before (current code at
MoneyRequestHeader.tsx:628-631):After:
Also move the navigation calls (lines 632-637) to happen before the deferred deletion, similar to how
MoneyReportHeadernavigates first and then defers the delete.What alternative solutions did you explore? (Optional)
Include
setDeleteTransactionNavigateBackUrlin the optimistic data ofdeleteMoneyRequest: This would guarantee both Onyx updates are in the same batch. However, this would require modifying the shareddeleteMoneyRequestfunction inIOU/index.ts, which has a wider blast radius.Use
Onyx.update()to batch both updates atomically: This would ensure the guard URL and the deletion optimistic data arrive in the same render cycle, but would require significant refactoring of howsetDeleteTransactionNavigateBackUrlis called.The recommended approach (deferring via
InteractionManager.runAfterInteractions) is the simplest fix, matches the existing pattern inMoneyReportHeader, and directly addresses the timing issue.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.war-in commentedon Mar 20, 2026
I don't think that deploy blocker was correctly linked to React Native upgrade issue. I verified the flow on the latest adhoc build from when we merged the PR and it works there.
ScreenRecording_03-20-2026.15-51-37_1.MP4
melvin-bot commentedon Mar 20, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
6 remaining items
[-]mWeb - Create Expense - “Hmm It's Not Here” page appears after deleting an expense[/-][+][Due for payment 2026-03-30] mWeb - Create Expense - “Hmm It's Not Here” page appears after deleting an expense[/+]melvin-bot commentedon Mar 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.41-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-30. 🎊
melvin-bot commentedon Mar 23, 2026
@JS00001 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Mar 23, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)[-][Due for payment 2026-03-30] mWeb - Create Expense - “Hmm It's Not Here” page appears after deleting an expense[/-][+][Due for payment 2026-03-31] [Due for payment 2026-03-30] mWeb - Create Expense - “Hmm It's Not Here” page appears after deleting an expense[/+]melvin-bot commentedon Mar 24, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.42-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-03-31. 🎊
melvin-bot commentedon Mar 24, 2026
@JS00001 @mallenexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]