Skip to content

[Internal QA] App from Mar 24 #86198

Closed
Closed

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 24, 2026
  2. MelvinBot commented on Mar 24, 2026

    @MelvinBot
    Contributor

    🔍 Issue Analysis

    Summary: This is an Internal QA tracking issue for the Mar 24 deploy, covering 4 merged PRs related to UK/EU Expensify Card PIN management and passkey/3DS flows that were not deploy-blocking but still require internal verification.

    Nature: QA checklist — no bug to root-cause. Below is a breakdown of each PR with key areas to verify.


    PR-by-PR Breakdown

    1. PR #86009 — Enable passkeys for PIN flows (rafecolton)

    What changed: Enabled passkey authentication for the ChangePIN, RevealPIN, and SetPINOrderCard MFA scenarios.

    Files: MultifactorAuthentication/config/scenarios/ChangePIN.tsx, RevealPIN.tsx, SetPINOrderCard.tsx, plus unit tests.

    QA focus:

    • Verify passkey prompts appear correctly during Change PIN, Reveal PIN, and Set PIN (order card) flows on web
    • Confirm fallback behavior works if passkeys are unavailable (e.g., on native/mobile)

    2. PR #86002 — Enable passkeys for 3DS challenges + RHP close prompt (chuckdries)

    What changed: Two things: (a) enabled passkeys for the AuthorizeTransaction MFA scenario, and (b) added a "Deny transaction?" confirmation modal when the user tries to close the RHP (via clicking outside or browser back button) during a 3DS challenge.

    Files: AuthorizeTransaction.tsx, MultifactorAuthentication/index.ts, AuthorizeTransactionPage/index.tsx.

    QA focus (from PR test plan):

    • Trigger a 3DS challenge, click outside the RHP → "Deny transaction" modal should appear
    • Cancel → RHP stays open; Deny → RHP closes and stays closed
    • Browser back button should behave the same way
    • Outcome screens (after deny/approve) should NOT show the prompt
    • Approve flow should navigate through MFA screens normally

    3. PR #85983 — Update react-native-onyx (rafecolton)

    What changed: Bumped react-native-onyx to include onyx PR #754. Also touched src/hooks/useOnyx.ts.

    QA focus:

    • General regression testing — ensure Onyx-backed data (reports, personal details, cards, etc.) loads and updates correctly
    • Watch for unexpected stale data or missing updates in any data-heavy views

    4. PR #84120 — Reveal PIN + Change PIN (DylanDylann)

    What changed: This is the largest PR — it implements the full "Reveal PIN" and "Change PIN" features for UK/EU Expensify Card holders. Adds new routes, screens, API parameters, translations (all languages), SVG assets, and navigation config.

    Key files: New pages at ExpensifyCardPage/ChangePINPage.tsx, ChangePINATMPage.tsx; new API params ChangeCardPINParams, RevealCardPINParams; new CardPINStore.ts utility; updates to Card.ts types, routes, navigation, and translations across 10 languages.

    QA focus:

    • Navigate to Settings → Wallet → Expensify Card for a UK/EU card
    • Verify "Reveal PIN" flow works end-to-end (MFA → PIN displayed)
    • Verify "Change PIN" flow works end-to-end (MFA → new PIN set → confirmation)
    • Verify the "Change PIN at ATM" informational page renders correctly
    • Check translations render properly if testing in non-English locales
    • Verify the new magnifying glass spy SVG illustrations display correctly

    Overall QA Risk Assessment

    PR Risk Reason
    #84120 High Large feature PR — new routes, API calls, navigation, translations
    #86002 Medium UX behavior change (modal on RHP close) + passkey enablement for 3DS
    #86009 Low Config-only change enabling passkeys for existing scenarios
    #85983 Low-Medium Dependency bump — low surface area but Onyx is foundational

    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.

  3. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 24, 2026
  4. rafecolton commented on Mar 24, 2026

    @rafecolton
    Member

    I'll knock these out

  5. rafecolton commented on Mar 24, 2026

    @rafecolton
    Member

    Actually @joekaufmanexpensify I assigned you to the two 3DS ones. The second one that mentions react-native-onyx is the one that fixes needing to clear the cache to see the prompt

  6. joekaufmanexpensify commented on Mar 24, 2026

    @joekaufmanexpensify
    Contributor

    Sounds good! I will take care of this.

  7. joekaufmanexpensify commented on Mar 25, 2026

    @joekaufmanexpensify
    Contributor

    checked off #85983

  8. joekaufmanexpensify commented on Mar 26, 2026

    @joekaufmanexpensify
    Contributor

    tested #86002 and left some notes

  9. rafecolton commented on Mar 26, 2026

    @rafecolton
    Member

    @joekaufmanexpensify it seems QA for #86002 passed, but we might have some unrelated issues we need to follow up on - is that right? If so, can we check it off here and close this issue?

  10. joekaufmanexpensify commented on Mar 26, 2026

    @joekaufmanexpensify
    Contributor

    Yep, that works.

  11. joekaufmanexpensify commented on Mar 26, 2026

    @joekaufmanexpensify
    Contributor

    All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions