[Due for payment 2026-05-07] [$500] Expense - Map expense is shown instead scan expense.

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: V9.3.43-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85589
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

Launch app
Login with new gmail account
Create workspace
Create a room - invite a user sending message @dreamnitethedragon+cr6ytui@gmail.com ( from whisper select invite to chat)
Create a split distance map expense in room created
Tap multiple receipt scanning icon
Take 2 camera image and proceed
Create expense

Expected Result:

Scan expense must be shown.

Actual Result:

Map expense is shown instead scan expense.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~022044069303414836894
Upwork Job ID: 2044069303414836894
Last Price Increase: 2026-05-05

Proposal

What is the root cause of that problem?

When submitting a split expense in IOURequestStepConfirmation.tsx:999, the distance request check runs before the scan receipt check at line 1007:

Line 999:  if (iouType !== TRACK && isDistanceRequest && ...) { createDistanceRequest(...); return; }
Line 1007: if (iouType === SPLIT && receiptFiles.length) { startSplitBill(...); return; }

If the draft transaction retains iouRequestType: 'distance' when the user switches to the scan tab, isDistanceRequest returns true and a distance expense is created — even though the user captured receipt photos.

The draft retains the stale type because of a guard in IOURequestStartPage.tsx:233-248: the useFocusEffect skips calling resetIOUTypeIfChanged when transaction?.reportID === reportID. After completing a split distance expense and immediately starting a new split from the same room, the old draft (with iouRequestType: 'distance') may still be present because cleanup is deferred via InteractionManager.runAfterInteractions. If the OnyxTabNavigator also doesn't fire onTabSelected (because the persisted tab already matches), resetIOUTypeIfChanged is never called, and the draft keeps iouRequestType: 'distance'.

What changes do you think we should make in order to solve the problem?

The distance check at line 999 should not take priority when the user has receipt files. Add a receipt-file guard to the distance check condition:

At IOURequestStepConfirmation.tsx:999, add a check that there are no receipt files before entering the distance path:

if (iouType !== TRACK && isDistanceRequest && !isMovingTransactionFromTrackExpense && !isUnreported && !hasReceiptFiles) { ... }

Where hasReceiptFiles is Object.values(receiptFiles).some(Boolean). This ensures that when the user has captured receipt photos, the flow falls through to the scan/split receipt path at line 1007 instead of creating a distance expense.

What alternative solutions did you explore? (Optional)

An alternative is to fix the useFocusEffect guard in IOURequestStartPage.tsx to always call resetIOUTypeIfChanged when the transaction type doesn't match the selected tab, regardless of whether the reportID matches. However, this is riskier since that guard exists to avoid resetting the transaction for other legitimate reasons (e.g., test transactions). The confirmation-level fix is more defensive and directly prevents the symptom.

Supporting evidence

Control flow in the submit handler (IOURequestStepConfirmation.tsx):

Line 999: Distance check → createDistanceRequest and return
Line 1007: Split with receipts → startSplitBill and return
Line 1048: Split from room → splitBill and return

The distance check at step 1 preempts the receipt check at step 2.

Draft cleanup race condition (IOU/Split.ts:266): After splitBill completes, draft cleanup is deferred via InteractionManager.runAfterInteractions(() => removeDraftTransaction(...)). If the user starts a new split before this fires, the old draft persists.

Tab navigator skip (OnyxTabNavigator.tsx:195-202): When the persisted tab in Onyx matches the current tab, onTabSelected is not called on mount, so resetIOUTypeIfChanged doesn't fire.

useFocusEffect guard (IOURequestStartPage.tsx:237): transaction?.reportID === reportID causes early return when starting a new split from the same room — preventing re-initialization.

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

@ZhenjaHorbach

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

Upwork job price has been updated to $500

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Awaiting Payment)

BugZero Checklist:

[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Unfortunately, I did not find a suitable PR

[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: NA
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Test:

Open App
Create workspace
Go to Track Distance > Map > enter waypoints > Next
Kill the app
Long press the app icon to access the “3D touch” menu > scan receipt
Snap a picture of a receipt
Verify that the Scan expense is shown.

Open App
Create workspace
Create a room - invite a user sending message @dreamnitethedragon+cr6ytui@gmail.com ( from whisper select invite to chat)
Create a split distance map expense in room created
Tap multiple receipt scanning icon
Take 2 camera image and proceed
Create expense
Verify that the Scan expense is shown.

Do we agree 👍 or 👎

Zapier Logs

Run ID: 00040eee-7130-a2ac-4c91-8d7a5c693c94

@ZhenjaHorbach

Payment Summary

Upwork Job

Reviewer: @ZhenjaHorbach owed $500 via NewDot
ROLE: @TaduJR paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@mallenexpensify)

(if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2044069303414836894/hired)
I have verified the PR was not reverted
I have applied any discounts due to bugs/regressions introduced by this PR
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@TaduJR

Payment Summary

Contributor: @TaduJR paid $500 via Upwork
Contributor+: @ZhenjaHorbach due $500 via NewDot

@TaduJR can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022044069303414836894

^ Test case created

@mallenexpensify

Offer Accepted @mallenexpensify

Thanks!

@TaduJR

@TaduJR paid, summary updated above. Thx.

@ZhenjaHorbach

$500 approved for @ZhenjaHorbach

Navigation Menu

Repository navigation

[Due for payment 2026-05-07] [$500] Expense - Map expense is shown instead scan expense. #86248

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

49 remaining items

BugZero Checklist:

Regression Test Proposal

Test:

Payment Summary

BugZero Checklist (@mallenexpensify)

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[Due for payment 2026-05-07] [$500] Expense - Map expense is shown instead scan expense. #86248

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

MelvinBot commented on Apr 14, 2026

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Apr 14, 2026

49 remaining items

melvin-bot commented on May 5, 2026

melvin-bot commented on May 6, 2026

ZhenjaHorbach commented on May 7, 2026

BugZero Checklist:

Regression Test Proposal

Test:

melvin-bot commented on May 7, 2026

Payment Summary

BugZero Checklist (@mallenexpensify)

mallenexpensify commented on May 8, 2026

Payment Summary

TaduJR commented on May 8, 2026

mallenexpensify commented on May 8, 2026

garrettmknight commented on May 10, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions