Expense-Tax rate modified violation appears after merging expenses & disappears on navigation

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: V9.3.42-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85658
Email or phone of affected tester (no customers): dreamnitethedragon+yydyd373@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Redminote 10S Android 13
App Component: Money Requests

Action Performed:

Launch app
Create workspace
Enable taxes
Create 4 manual expenses without category
Eg: ₹5 - tax 0%
₹6 - tax 5%
₹7 - tax 0%
₹8 - tax tax 5%
Open the expense with amount ₹5 and merge with expense ₹6 selecting all second options in merge flow
Note merged expense and another expense with tax rate 5% shows tax rate was modified violation
Open the expense and navigate back and note violation disappears

Case 2

Launch app
Create workspace
Enable taxes
Create 4 manual expenses with category
Eg: ₹5 - tax 0%
₹6 - tax 5%
₹7 - tax 0%
₹8 - tax tax 5%
Open the expense with amount ₹5 and merge with expense ₹6 selecting all second options in merge flow
Note merged expense and another expense with tax rate 5% shows tax rate was modified violation
Open the expense and navigate back and note violation

Expected Result:

The violation should only appear if there is a real tax issue.

Unrelated expenses should not show the violation.

The violation should not disappear on navigation and must remain until resolved.

Actual Result:

After merging ₹5 (0% tax) with ₹6 (5% tax):
A “tax rate was modified” violation appears on the merged expense.

The same violation also appears on another expense with 5% tax.

When the expense( without category) is opened and navigated back, the violation disappears automatically.

Case 2

When the expense( with category) is opened and navigated back, the violation persist.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7112403_1774409262146.Screenrecorder-2026-03-25-08-39-03-332.mp4

Bug7112403_1774427926697.Screenrecorder-2026-03-25-14-02-55-177.mp4

View all open jobs on GitHub

Fix duplicate violations on target transaction after merge

Proposal

Please re-state the problem that we are trying to solve in this issue.

After merging two expenses with different tax rates, the merged expense shows a "tax rate was modified" violation that disappears on navigation. Additionally, unrelated expenses may also show spurious violations.

What is the root cause of that problem?

There are two bugs in mergeTransactionRequest in MergeTransaction.ts:

Bug 1 — Target transaction violations are duplicated by optimistic data ordering

optimisticTransactionViolations writes violations for BOTH the target and source transactions using Onyx.METHOD.MERGE:

App/src/libs/actions/MergeTransaction.ts

Lines 517 to 528 in 9ac9e98

    
           // Optimistic delete duplicated transaction violations 
        
           const optimisticTransactionViolations: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS>> = [targetTransaction.transactionID, sourceTransaction.transactionID].map( 
        
               (id) => { 
        
                   const violations = allTransactionViolations?.[ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS + id] ?? []; 
        
                   return { 
        
                       onyxMethod: Onyx.METHOD.MERGE, 
        
                       key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${id}`, 
        
                       value: violations.filter((violation) => violation.name !== CONST.VIOLATIONS.DUPLICATED_TRANSACTION), 
        
                   }; 
        
               }, 
        
           );

However, the target transaction's violations are already computed by getViolationsOnyxData (called from getUpdateMoneyRequestParams) using Onyx.METHOD.SET:

App/src/libs/Violations/ViolationsUtils.ts

Lines 650 to 654 in 9ac9e98

    
           return { 
        
               onyxMethod: Onyx.METHOD.SET, 
        
               key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${updatedTransaction.transactionID}`, 
        
               value: newTransactionViolations, 
        
           };

When API.write calls Onyx.update(), both operations target the same key. Due to Onyx v3's batching, SET enqueues [null, computed] and then MERGE pushes the original violations to the same queue — resulting in [null, computed, original]. When mergeAndMarkChanges processes this queue, it concatenates the arrays, causing duplicate violation entries on the target transaction.

https://github.com/nickenbach/react-native-onyx/blob/8c0a72f3d27e49daf5a2aaaba1aff0c4cd01c47d/lib/Onyx.ts#L411-L424

These duplicated violations appear immediately after merge and disappear on the next navigation because the server response overwrites them with the correct violations.

Bug 2 — Source transaction violations are orphaned

The source transaction itself is SET to null (deleted), but its violations are only MERGEd (filtering out DUPLICATED_TRANSACTION) rather than being deleted. This leaves orphaned violation data in ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS for a transaction that no longer exists.

What changes do you think we should make in order to solve the problem?

Remove the target transaction from optimisticTransactionViolations entirely — let getViolationsOnyxData (via getUpdateMoneyRequestParams) handle target violations exclusively with its SET operation, avoiding the SET+MERGE concatenation.
Change the source transaction's violations to use Onyx.METHOD.SET with null value instead of MERGE, properly cleaning up violations for the deleted transaction. Add corresponding failure data that restores the source violations for rollback.

Compare: https://github.com/Expensify/App/compare/main...wildan-m:App:wildan/86306-fix-merge-violation-ordering?expand=1

Huh... This is 4 days overdue. Who can take care of this?

Eep! 4 days overdue now. Issues have feelings too...

Huh... This is 4 days overdue. Who can take care of this?

Still overdue 6 days?! Let's take care of this!

Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

12 days overdue now... This issue's end is nigh!

This issue has not been updated in over 14 days. eroding to Weekly issue.

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@nlemma

@nlemma, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Navigation Menu

Repository navigation

Expense-Tax rate modified violation appears after merging expenses & disappears on navigation #86306

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	// Optimistic delete duplicated transaction violations
	const optimisticTransactionViolations: Array<OnyxUpdate<typeof ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS>> = [targetTransaction.transactionID, sourceTransaction.transactionID].map(
	(id) => {
	const violations = allTransactionViolations?.[ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS + id] ?? [];

	return {
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${id}`,
	value: violations.filter((violation) => violation.name !== CONST.VIOLATIONS.DUPLICATED_TRANSACTION),
	};
	},
	);

	return {
	onyxMethod: Onyx.METHOD.SET,
	key: `${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${updatedTransaction.transactionID}`,
	value: newTransactionViolations,
	};

Expense-Tax rate modified violation appears after merging expenses & disappears on navigation #86306

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

wildan-m commented on Mar 25, 2026

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot commented on Mar 30, 2026

melvin-bot commented on Mar 30, 2026

melvin-bot commented on Mar 30, 2026

melvin-bot commented on Apr 1, 2026

melvin-bot commented on Apr 3, 2026

melvin-bot commented on Apr 7, 2026

melvin-bot commented on Apr 10, 2026

melvin-bot commented on May 7, 2026

melvin-bot commented on Jul 20, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions