Skip to content

[Due for payment 2026-04-23] [Card Rules Release #2] [App] Allow editing and deleting of rules #86522

Closed

Description

Activity

  1. melvin-bot commented on Mar 27, 2026

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  2. JS00001 commented on Mar 30, 2026

    @JS00001
    ContributorAuthor

    Haven't gotten to this one yet

  3. JS00001 commented on Apr 2, 2026

    @JS00001
    ContributorAuthor

    Working through release #1 still

  4. 30 remaining items

  5. suneox commented on Apr 22, 2026

    @suneox
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      N/A: This is a new feature implementation

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Precondition:

    • Workspace with Expensify cards enabled
    • At least one spend rule exists

    Test Case 1: Edit Spend Rule

    1. Navigate to Workspaces > Rules
    2. Select an existing spend rule from the list
    3. Click "Edit" button
    4. Modify the rule name (if editable)
    5. Change the category
    6. Update the max amount
    7. Add/remove merchants
    8. Save the changes
    9. Navigate back to the rules list

    Verify The rule reflects the changes


    Test Case 2: Delete Spend Rule

    1. Navigate to Workspaces > Rules
    2. Create a new spend rule (or select existing one)
    3. Open the rule details
    4. Click "Delete rule" button
    5. Confirm deletion in the modal

    Verify:

    • RHP closes or navigates back to the rules list
    • Rules list no longer shows the deleted rule

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-9803-ac03-e48a-ae1348c271b4
  6. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 22, 2026
  7. melvin-bot commented on Apr 22, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  8. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @suneox owed $250 via NewDot

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  9. mallenexpensify commented on Apr 24, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @suneox due $250 via NewDot

    New feature and behind beta so assuming regression penalties aren't being added here.

    Guessing we can close but unsure so I'll let someone else do it.

  10. luacmartins commented on Apr 27, 2026

    @luacmartins
    Contributor

    We can close this. Thanks!

  11. garrettmknight commented on Apr 27, 2026

    @garrettmknight
    Contributor

    $250 approved for @suneox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions