You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: 9.3.50-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84653 Email or phone of affected tester (no customers):soidjosjdosijoijs@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Click search button.
Type anything.
Expected Result:
Highlight on the selection will look the same as production.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: PR 83799 - "Enhance icons UI consistency" by zfurtak (High confidence) Related Issues: None
Recommendation: REVERT
PR 83799 changed the default value of shouldHighlightSelectedItem from true to false in BaseListItem.tsx. Since SearchAutocompleteList does not explicitly pass this prop to SelectionListWithSections, it now inherits the new default value of false, causing the highlight/selection styling to not render properly.
Evidence
PR 83799 made widespread changes to selection list components as part of enhancing icon consistency. The PR description states it aims to "remove active state, so chosen element is not hovered anymore."
Key changes in BaseListItem.tsx:
Changed shouldHighlightSelectedItem default from = true to = false
Changed shouldUseDefaultRightHandSideCheckmark default from = true to = false
SearchAutocompleteList.tsx was modified in this PR but does not explicitly pass the shouldHighlightSelectedItem prop when rendering SelectionListWithSections.
PR 83799 changed default behavior for shouldHighlightSelectedItem in BaseListItem.tsx
SearchAutocompleteList does not explicitly set shouldHighlightSelectedItem prop, relying on the default
The PR merged on 2026-03-27 at 11:17:04, placing it in the staging deploy window
Issue is reproducible on staging but not production, confirming it was introduced in this deploy
Root Cause
When shouldHighlightSelectedItem is false, the selection highlight styling is not applied to list items properly, causing the cut off appearance reported in the issue.
The cut-off highlight is not caused by PR #84653, but by PR #83799 ("Enhance icons UI consistency"), which shipped in the same staging deploy.
PR #83799 made two changes that combine to break the focus highlight in the search autocomplete list:
Changed the default of shouldHighlightSelectedItem from true to false in BaseListItem.tsx (line ~85).
Removed the explicit shouldHighlightSelectedItem prop from BaseSelectionListWithSections.tsx (line ~358), which previously hardcoded it to true.
In BaseListItem, there are two layers that can receive focus background color:
Outer PressableWithFeedback — has borderRadius: 8 and paddingHorizontal: 12 (set by SearchAutocompleteList). Its highlight is gated by isFocused && shouldHighlightSelectedItem && getItemBackgroundColorStyle(...).
Inner View — narrower (inset by the pressable's padding) and has no border radius. Its highlight changed from being fully gated by shouldHighlightSelectedItem to only using it for the isSelected parameter: isFocused && getItemBackgroundColorStyle(shouldHighlightSelectedItem && isSelected, isFocused, ...).
Before PR #83799:shouldHighlightSelectedItem was true, so the outer pressable got the focus background — a full-width, rounded highlight.
After PR #83799:shouldHighlightSelectedItem defaults to false, so the outer pressable gets no background. Only the narrower inner View gets the focus highlight — resulting in a rectangular highlight that doesn't extend to the row edges, appearing "cut off" by ~12px on each side with no rounded corners.
What changes do you think we should make in order to solve the problem?
Re-add shouldHighlightSelectedItem to the ListItemRenderer call inside BaseSelectionListWithSections.tsx (around line 358), restoring the explicit pass-through so the search autocomplete list items receive the full-width rounded focus highlight:
This ensures BaseSelectionListWithSections consumers that pass shouldHighlightSelectedItem={true} (or want the previous default behavior) can opt in, while the new default behavior from PR #83799 remains intact for other list types.
Alternatively, the SearchAutocompleteList could explicitly pass shouldHighlightSelectedItem={true} to SelectionListWithSections.
What alternative solutions did you explore? (Optional)
Change the pressable-level highlight logic to always apply for focused (non-selected) items regardless of shouldHighlightSelectedItem — this would fix the issue but could affect other lists that intentionally don't want the pressable-level highlight.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Activity
melvin-bot commentedon Mar 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #84653
melvin-bot commentedon Mar 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Mar 27, 2026
Production:
Recording.5206.mp4
OSBotify commentedon Mar 27, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: PR 83799 - "Enhance icons UI consistency" by zfurtak (High confidence)
Related Issues: None
Recommendation: REVERT
PR 83799 changed the default value of shouldHighlightSelectedItem from true to false in BaseListItem.tsx. Since SearchAutocompleteList does not explicitly pass this prop to SelectionListWithSections, it now inherits the new default value of false, causing the highlight/selection styling to not render properly.
Labels: Keeping DeployBlockerCash (App deploy blocked - fix requires App PR revert or fix)
Detailed Analysis
Evidence
PR 83799 made widespread changes to selection list components as part of enhancing icon consistency. The PR description states it aims to "remove active state, so chosen element is not hovered anymore."
Key changes in BaseListItem.tsx:
SearchAutocompleteList.tsx was modified in this PR but does not explicitly pass the shouldHighlightSelectedItem prop when rendering SelectionListWithSections.
Verification
Confirmed that:
Root Cause
When shouldHighlightSelectedItem is false, the selection highlight styling is not applied to list items properly, causing the cut off appearance reported in the issue.
MelvinBot commentedon Mar 27, 2026
Proposal
What is the root cause of that problem?
The cut-off highlight is not caused by PR #84653, but by PR #83799 ("Enhance icons UI consistency"), which shipped in the same staging deploy.
PR #83799 made two changes that combine to break the focus highlight in the search autocomplete list:
Changed the default of
shouldHighlightSelectedItemfromtruetofalseinBaseListItem.tsx(line ~85).Removed the explicit
shouldHighlightSelectedItemprop fromBaseSelectionListWithSections.tsx(line ~358), which previously hardcoded it totrue.In
BaseListItem, there are two layers that can receive focus background color:PressableWithFeedback— hasborderRadius: 8andpaddingHorizontal: 12(set by SearchAutocompleteList). Its highlight is gated byisFocused && shouldHighlightSelectedItem && getItemBackgroundColorStyle(...).View— narrower (inset by the pressable's padding) and has no border radius. Its highlight changed from being fully gated byshouldHighlightSelectedItemto only using it for theisSelectedparameter:isFocused && getItemBackgroundColorStyle(shouldHighlightSelectedItem && isSelected, isFocused, ...).Before PR #83799:
shouldHighlightSelectedItemwastrue, so the outer pressable got the focus background — a full-width, rounded highlight.After PR #83799:
shouldHighlightSelectedItemdefaults tofalse, so the outer pressable gets no background. Only the narrower inner View gets the focus highlight — resulting in a rectangular highlight that doesn't extend to the row edges, appearing "cut off" by ~12px on each side with no rounded corners.What changes do you think we should make in order to solve the problem?
Re-add
shouldHighlightSelectedItemto theListItemRenderercall insideBaseSelectionListWithSections.tsx(around line 358), restoring the explicit pass-through so the search autocomplete list items receive the full-width rounded focus highlight:This ensures
BaseSelectionListWithSectionsconsumers that passshouldHighlightSelectedItem={true}(or want the previous default behavior) can opt in, while the new default behavior from PR #83799 remains intact for other list types.Alternatively, the
SearchAutocompleteListcould explicitly passshouldHighlightSelectedItem={true}toSelectionListWithSections.What alternative solutions did you explore? (Optional)
shouldHighlightSelectedItem— this would fix the issue but could affect other lists that intentionally don't want the pressable-level highlight.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.m-natarajan commentedon Mar 27, 2026
Not repro v9.3.50-2 web chrome
Screen.Recording.2026-03-28.at.01.48.13.mp4
melvin-bot commentedon Mar 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.