You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Reports - Type options and Status options have different paddings #86536
Version Number: 9.3.50-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#83799 Email or phone of affected tester (no customers):snodijosdnjoijiosnj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to Reports > Reports.
Click Type quick filter.
Click Status quick filter.
Expected Result:
Type options will have the same paddings as Status options.
Actual Result:
Type options and Status options have different paddings.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #83799 - "Enhance icons UI consistency" by @zfurtak (High confidence) Related Issues: None
Recommendation: REVERT
PR #83799 introduced inconsistent padding between single-select and multi-select lists. The Type filter uses SingleSelectListItem which applies optionRow style (minHeight: 64px, padding: 12px), while the Status filter uses MultiSelectListItem which applies optionRowCompact style (minHeight: 52px, padding: 12px). This creates a visible height and spacing difference between the two filters, resulting in poor UX.
A revert is the safest option as this is a large design system change affecting many components throughout the app.
Labels: This issue is only reproducible on staging (not production), and the causing PR is in the App repository. However, since the label was added by an internal employee (@nlemma), I will keep the DeployBlockerCash label per the investigation guidelines.
Detailed Analysis
Evidence
The issue reports that Type and Status filter options have different paddings when viewed in Reports > Reports.
PR #83799 was merged on 2026-03-27 at 11:17:04 UTC, which aligns with the 9.3.50-0 release where this bug was found. The PR made sweeping changes to selection list UI by:
Replacing RadioListItem with SingleSelectListItem across the codebase
Replacing various list items with MultiSelectListItem
Adding radio buttons and checkboxes to lists for consistency
// When no icon:computedWrapperStyle: [wrapperStyle,styles.optionRowCompact],// When icon present:computedWrapperStyle: [wrapperStyle,styles.pv0,styles.mnh13],
This creates a 12px height difference between Type (single-select) and Status (multi-select) filters, causing the visual inconsistency reported in the issue.
The Type and Status quick filter dropdowns use different list item components, which apply different row height styles:
Type uses SingleSelectPopup → SingleSelectListItem, which applies styles.optionRow with minHeight: 64px
Status uses MultiSelectPopup → MultiSelectListItem, which applies styles.optionRowCompact with minHeight: 52px
Both ultimately delegate to RadioListItem → BaseListItem, and the actual CSS padding is identical (12px vertical, 20px horizontal from sidebarLinkInner). The visual "padding difference" is caused by the 12px difference in minHeight (64 vs 52), which creates more vertical space in the Type rows.
This was introduced in #83799 which created the SingleSelectListItem and MultiSelectListItem components with these differing row height styles.
What changes do you think we should make in order to solve the problem?
Change SingleSelectListItem to use styles.optionRowCompact instead of styles.optionRow in its wrapperStyle, so both Type and Status dropdown rows have the same compact height (52px). The compact style is more appropriate for popover dropdown menus.
In src/components/SelectionList/ListItem/SingleSelectListItem.tsx, change:
This makes SingleSelectListItem consistent with MultiSelectListItem's row height while preserving the existing padding and selection indicator differences (circular radio vs square checkbox) which are intentionally distinct.
What alternative solutions did you explore? (Optional)
An alternative would be to change MultiSelectListItem to use styles.optionRow (64px) instead, making Status rows taller. However, the compact height (52px) is more appropriate for dropdown filter menus where space efficiency matters, so aligning SingleSelectListItem to the compact style is preferable.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Activity
melvin-bot commentedon Mar 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #83799
melvin-bot commentedon Mar 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 27, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #83799 - "Enhance icons UI consistency" by @zfurtak (High confidence)
Related Issues: None
Recommendation: REVERT
PR #83799 introduced inconsistent padding between single-select and multi-select lists. The Type filter uses
SingleSelectListItemwhich appliesoptionRowstyle (minHeight: 64px, padding: 12px), while the Status filter usesMultiSelectListItemwhich appliesoptionRowCompactstyle (minHeight: 52px, padding: 12px). This creates a visible height and spacing difference between the two filters, resulting in poor UX.A revert is the safest option as this is a large design system change affecting many components throughout the app.
Labels: This issue is only reproducible on staging (not production), and the causing PR is in the App repository. However, since the label was added by an internal employee (@nlemma), I will keep the
DeployBlockerCashlabel per the investigation guidelines.Detailed Analysis
Evidence
The issue reports that Type and Status filter options have different paddings when viewed in Reports > Reports.
PR #83799 was merged on 2026-03-27 at 11:17:04 UTC, which aligns with the 9.3.50-0 release where this bug was found. The PR made sweeping changes to selection list UI by:
RadioListItemwithSingleSelectListItemacross the codebaseMultiSelectListItemVerification
The affected files are:
/home/runner/_work/App/App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx(Type filter - usesSingleSelectListItem)/home/runner/_work/App/App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx(Status filter - usesMultiSelectListItem)PR #83799 modified the selection list components:
src/components/SelectionList/ListItem/SingleSelectListItem.tsxsrc/components/SelectionList/ListItem/MultiSelectListItem.tsxRoot Cause
In
SingleSelectListItem.tsx(line 60):In
MultiSelectListItem.tsx(lines 48, 67):The styles differ:
optionRow: minHeight 64px, paddingTop/Bottom 12pxoptionRowCompact: minHeight 52px, paddingTop/Bottom 12pxThis creates a 12px height difference between Type (single-select) and Status (multi-select) filters, causing the visual inconsistency reported in the issue.
MelvinBot commentedon Mar 27, 2026
Proposal
What is the root cause of that problem?
The Type and Status quick filter dropdowns use different list item components, which apply different row height styles:
SingleSelectPopup→SingleSelectListItem, which appliesstyles.optionRowwithminHeight: 64pxMultiSelectPopup→MultiSelectListItem, which appliesstyles.optionRowCompactwithminHeight: 52pxBoth ultimately delegate to
RadioListItem→BaseListItem, and the actual CSS padding is identical (12px vertical, 20px horizontal fromsidebarLinkInner). The visual "padding difference" is caused by the 12px difference inminHeight(64 vs 52), which creates more vertical space in the Type rows.This was introduced in #83799 which created the
SingleSelectListItemandMultiSelectListItemcomponents with these differing row height styles.Key code references:
SingleSelectListItem.tsx:60— appliesstyles.optionRow(minHeight: 64)MultiSelectListItem.tsx:48— appliesstyles.optionRowCompact(minHeight: 52)What changes do you think we should make in order to solve the problem?
Change
SingleSelectListItemto usestyles.optionRowCompactinstead ofstyles.optionRowin itswrapperStyle, so both Type and Status dropdown rows have the same compact height (52px). The compact style is more appropriate for popover dropdown menus.In
src/components/SelectionList/ListItem/SingleSelectListItem.tsx, change:to:
This makes SingleSelectListItem consistent with MultiSelectListItem's row height while preserving the existing padding and selection indicator differences (circular radio vs square checkbox) which are intentionally distinct.
What alternative solutions did you explore? (Optional)
An alternative would be to change
MultiSelectListItemto usestyles.optionRow(64px) instead, making Status rows taller. However, the compact height (52px) is more appropriate for dropdown filter menus where space efficiency matters, so aligning SingleSelectListItem to the compact style is preferable.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.m-natarajan commentedon Mar 27, 2026
Not Repro, Windows 10/ Chrome, v9.3.50-2
repro-.issue.86536.mp4
melvin-bot commentedon Mar 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
grgia commentedon Mar 30, 2026
PR reverted