Skip to content

Reports - Type options and Status options have different paddings #86536

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.50-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83799
Email or phone of affected tester (no customers): snodijosdnjoijiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Reports > Reports.
  3. Click Type quick filter.
  4. Click Status quick filter.

Expected Result:

Type options will have the same paddings as Status options.

Actual Result:

Type options and Status options have different paddings.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7114897_1774615638583.5.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @zfurtak

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 27, 2026
  2. melvin-bot commented on Mar 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #83799

  3. melvin-bot commented on Mar 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Mar 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Mar 27, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #83799 - "Enhance icons UI consistency" by @zfurtak (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #83799 introduced inconsistent padding between single-select and multi-select lists. The Type filter uses SingleSelectListItem which applies optionRow style (minHeight: 64px, padding: 12px), while the Status filter uses MultiSelectListItem which applies optionRowCompact style (minHeight: 52px, padding: 12px). This creates a visible height and spacing difference between the two filters, resulting in poor UX.

    A revert is the safest option as this is a large design system change affecting many components throughout the app.

    Labels: This issue is only reproducible on staging (not production), and the causing PR is in the App repository. However, since the label was added by an internal employee (@nlemma), I will keep the DeployBlockerCash label per the investigation guidelines.

    Detailed Analysis

    Evidence

    The issue reports that Type and Status filter options have different paddings when viewed in Reports > Reports.

    PR #83799 was merged on 2026-03-27 at 11:17:04 UTC, which aligns with the 9.3.50-0 release where this bug was found. The PR made sweeping changes to selection list UI by:

    • Replacing RadioListItem with SingleSelectListItem across the codebase
    • Replacing various list items with MultiSelectListItem
    • Adding radio buttons and checkboxes to lists for consistency

    Verification

    The affected files are:

    • /home/runner/_work/App/App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersTypePage.tsx (Type filter - uses SingleSelectListItem)
    • /home/runner/_work/App/App/src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersStatusPage.tsx (Status filter - uses MultiSelectListItem)

    PR #83799 modified the selection list components:

    • src/components/SelectionList/ListItem/SingleSelectListItem.tsx
    • src/components/SelectionList/ListItem/MultiSelectListItem.tsx

    Root Cause

    In SingleSelectListItem.tsx (line 60):

    wrapperStyle={[styles.optionRow, wrapperStyle]}

    In MultiSelectListItem.tsx (lines 48, 67):

    // When no icon:
    computedWrapperStyle: [wrapperStyle, styles.optionRowCompact],
    // When icon present:
    computedWrapperStyle: [wrapperStyle, styles.pv0, styles.mnh13],

    The styles differ:

    • optionRow: minHeight 64px, paddingTop/Bottom 12px
    • optionRowCompact: minHeight 52px, paddingTop/Bottom 12px

    This creates a 12px height difference between Type (single-select) and Status (multi-select) filters, causing the visual inconsistency reported in the issue.

  6. MelvinBot commented on Mar 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The Type and Status quick filter dropdowns use different list item components, which apply different row height styles:

    • Type uses SingleSelectPopup → SingleSelectListItem, which applies styles.optionRow with minHeight: 64px
    • Status uses MultiSelectPopup → MultiSelectListItem, which applies styles.optionRowCompact with minHeight: 52px

    Both ultimately delegate to RadioListItem → BaseListItem, and the actual CSS padding is identical (12px vertical, 20px horizontal from sidebarLinkInner). The visual "padding difference" is caused by the 12px difference in minHeight (64 vs 52), which creates more vertical space in the Type rows.

    This was introduced in #83799 which created the SingleSelectListItem and MultiSelectListItem components with these differing row height styles.

    Key code references:

    What changes do you think we should make in order to solve the problem?

    Change SingleSelectListItem to use styles.optionRowCompact instead of styles.optionRow in its wrapperStyle, so both Type and Status dropdown rows have the same compact height (52px). The compact style is more appropriate for popover dropdown menus.

    In src/components/SelectionList/ListItem/SingleSelectListItem.tsx, change:

    wrapperStyle={[styles.optionRow, wrapperStyle]}
    

    to:

    wrapperStyle={[styles.optionRowCompact, wrapperStyle]}
    

    This makes SingleSelectListItem consistent with MultiSelectListItem's row height while preserving the existing padding and selection indicator differences (circular radio vs square checkbox) which are intentionally distinct.

    What alternative solutions did you explore? (Optional)

    An alternative would be to change MultiSelectListItem to use styles.optionRow (64px) instead, making Status rows taller. However, the compact height (52px) is more appropriate for dropdown filter menus where space efficiency matters, so aligning SingleSelectListItem to the compact style is preferable.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. m-natarajan commented on Mar 27, 2026

    @m-natarajan

    Not Repro, Windows 10/ Chrome, v9.3.50-2

    repro-.issue.86536.mp4
  8. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. grgia commented on Mar 30, 2026

    @grgia
    Contributor

    PR reverted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions