Skip to content

Expense - New report opens and closes after creating new report #86544

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.50-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85570
Email or phone of affected tester (no customers): sdjsoidnsjoidjiosjnioj1@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with new account.
  3. Create a workspace.
  4. Go to Inbox.
  5. Open FAB > Create report.
  6. Go to Home tab.
  7. Open FAB > Create report.
  8. Click Create report.

Expected Result:

New report will open.

Actual Result:

New report opens and closes and app returns to workspace chat.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7114946_1774619644857.9.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 27, 2026
  2. melvin-bot commented on Mar 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #85570

  3. melvin-bot commented on Mar 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Mar 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Mar 27, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #85570 - "Show Create Report CTA for users without a workspace" by @mukhrr (High confidence)
    Related Issues: None found

    Recommendation: REVERT

    The PR introduced a Navigation.goBack() call that executes before navigating to the newly created report, causing the report to open and immediately close. This affects the create report flow when users go through the upgrade path.

    Labels: Keeping DeployBlockerCash (this is an App/frontend bug that blocks the mobile deploy)

    📋 Detailed Analysis

    Evidence

    PR #85570 modified the report creation flow by refactoring the logic into a new useCreateReportAction hook. The PR also modified IOURequestStepUpgrade.tsx which handles the upgrade flow when users without a workspace try to create a report.

    The bug is reproducible only on staging (where PR #85570 is deployed) and not on production (where it is not yet deployed).

    Verification

    The affected file is /home/runner/_work/App/App/src/pages/iou/request/step/IOURequestStepUpgrade.tsx, specifically lines 128-145 in the CONST.UPGRADE_PATHS.REPORTS case.

    PR #85570 modified this file (confirmed in the PR files list), and this file handles the exact flow described in the reproduction steps: creating a workspace and then creating a report.

    Root Cause

    In IOURequestStepUpgrade.tsx, the code calls Navigation.goBack() unconditionally at line 129, before the conditional logic that creates and navigates to the new report (lines 130-139). This causes the following sequence:

    1. User clicks "Create report"
    2. Navigation.goBack() executes, popping the navigation stack back to workspace chat
    3. createNewReport() is called and creates the report
    4. navigateWithMicrotask() attempts to navigate to the new report
    5. The navigation state is already back at workspace chat, causing the new report to open and immediately close

    The fix should move the Navigation.goBack() call to only execute in the branches where navigation to a new report does NOT occur, or remove it entirely from the report creation branch.

  6. added a commit that references this issue on Mar 27, 2026
    9ad2448
  7. MelvinBot commented on Mar 27, 2026

    @MelvinBot
    Contributor

    I ran out of time before I could finish helping you. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in the #melvinbot-ai.

    Run details: https://github.com/Expensify/Expensify/actions/runs/23650113075

  8. m-natarajan commented on Mar 27, 2026

    @m-natarajan

    Repro v9.3.50-2 web chrome

    Screen.Recording.2026-03-28.at.01.35.23.mp4
  9. marcaaron commented on Mar 27, 2026

    @marcaaron
    Contributor

    I'm confused. Did the revert fix it or not ?

  10. marcaaron commented on Mar 27, 2026

    @marcaaron
    Contributor

    Ok I'm reverting this PR since it was linked to quite a few blockers it seems. I will alert QA.

  11. mukhrr commented on Mar 28, 2026

    @mukhrr
    Contributor

    @marcaaron could you pls assign me here?! thanks

  12. mukhrr commented on Mar 28, 2026

    @mukhrr
    Contributor

    Btw, PR fixing this issue is ready

  13. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  14. m-natarajan commented on Mar 31, 2026

    @m-natarajan

    Reproduced, Windows 11 / Chrome, v9.3.50-4

    new.report.mp4
  15. jasperhuangg commented on Mar 31, 2026

    @jasperhuangg
    Contributor

    still happens with that revert cc @marcaaron

  16. mukhrr commented on Mar 31, 2026

    @mukhrr
    Contributor

    oh then @marcaaron could you pls assign me here. THis PR fixes issue

  17. jasperhuangg commented on Mar 31, 2026

    @jasperhuangg
    Contributor

    hold up, why did the CP message post 8 hours after QA checked it?? Did the CP fail? I'm gonna ask for another retest just to be safe.

  18. m-natarajan commented on Mar 31, 2026

    @m-natarajan

    Not Repro, Windows 10/ Chrome, v9.3.50-8

    repro.-.86544.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions