Skip to content

Reports - Next arrow button on report carousel is larger than the left arrow #86546

Closed

Description

@nlemma

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.50-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #76292
Email or phone of affected tester (no customers): sdjsoidnsjoidjiosjnioj1@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two reports.
  4. Go to Reports > Reports.
  5. Open any report.

Expected Result:

Left and right arrow button on report carousel will have the same size.

Actual Result:

Next arrow button on report carousel is larger than the left arrow.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7114960_1774620692179.10.mp4
Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @zfurtak

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 27, 2026
  2. melvin-bot commented on Mar 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #83799

  3. melvin-bot commented on Mar 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Mar 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Mar 27, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: Unable to determine with high confidence, but the bug exists in src/components/PrevNextButtons.tsx
    Confidence Level: Medium

    Recommendation: ROLL FORWARD

    The issue is caused by inconsistent icon sizing in the PrevNextButtons component used by the report carousel navigation. A simple fix is needed rather than a full revert.

    Labels: No label changes recommended - keeping DeployBlockerCash since this is a Frontend bug that only reproduces on staging.

    Detailed Analysis

    Evidence

    The bug is in /home/runner/_work/App/App/src/components/PrevNextButtons.tsx:

    Back/Prev button (lines 42-48):

    <Icon
        src={icons.BackArrow}
        small                    // Uses small prop
        fill={theme.icon}
        isButtonIcon
    />

    Next button (lines 60-66):

    <Icon
        src={icons.ArrowRight}
        fill={theme.icon}
        width={variables.iconSizeNormal}    // Explicit width
        height={variables.iconSizeNormal}   // Explicit height
        // No small prop
    />

    This creates inconsistent sizing - the back arrow uses the small prop while the next arrow uses explicit width/height values, causing the next arrow to appear larger.

    Verification

    • The bug only reproduces on staging, not production (confirmed in issue description)
    • The PrevNextButtons component is used by MoneyRequestReportNavigation.tsx for the report carousel navigation arrows
    • This matches the reproduction steps: "Go to Reports > Reports, Open any report" - this displays the report carousel with prev/next navigation arrows

    Root Cause

    The PrevNextButtons component was implemented with inconsistent icon sizing props. Both buttons should use the same sizing approach (either both use small prop or both use explicit width/height).

    Recommended Fix

    Change line 62-66 in PrevNextButtons.tsx to:

    <Icon
        src={icons.ArrowRight}
        small                    // Add small prop for consistency
        fill={theme.icon}
        isButtonIcon            // Add isButtonIcon for consistency
    />

    Or alternatively, make both buttons use explicit sizing for consistency.

  6. MelvinBot commented on Mar 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The back-left.svg (BackArrow) and arrow-right.svg (ArrowRight) SVG icons have different visual proportions within the same 20x20 viewBox. They are not mirror images of each other.

    • ArrowRight (arrow-right.svg): path fills ~8.99 x 13.46 units of the 20x20 viewBox
    • BackArrow (back-left.svg): path fills ~8.43 x 12.62 units of the 20x20 viewBox

    This means ArrowRight appears ~6-7% larger than BackArrow when rendered at the same pixel dimensions. Both icons were replaced in PR #76292 with new path data that introduced this asymmetry. The old icons were proper mirror images of each other and had identical proportions.

    In CarouselButtons.tsx:50-59 and :66-74, both buttons use identical props (small, same innerStyles={[styles.arrowIcon]}), so the component code is correct — the issue is purely in the SVG asset data.

    Note: PR #83799 ("Enhance icons UI consistency") did not modify any carousel, Icon, Button, or style files. The regression was introduced by PR #76292 which replaced both SVG icons.

    What changes do you think we should make in order to solve the problem?

    Update assets/images/back-left.svg to be a proper horizontal mirror of arrow-right.svg. The mirrored path (flipping x-coordinates around the center of the 20-unit viewBox: x' = 20 - x) would be:

    M13.53 3.27c-.62-.62-1.64-.62-2.26 0L4.54 10l6.73 6.73c.62.62 1.64.62 2.26 0s.62-1.64 0-2.26L9.06 10l4.47-4.47c.62-.62.62-1.64 0-2.26

    This ensures both arrows have identical visual weight and proportions, just mirrored horizontally.

    What alternative solutions did you explore? (Optional)

    • Updating arrow-right.svg to mirror back-left.svg instead: This would also work, but arrow-right.svg uses a cleaner, simpler SVG format (no extra xml:space, style, or class attributes), so it's better to keep ArrowRight as the reference and update BackArrow to match its proportions.
    • Adjusting icon size props per-button: Rejected because the icons should be inherently symmetrical — component-level workarounds would be fragile and inconsistent across other usages of these icons.

    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. grgia commented on Mar 27, 2026

    @grgia
    Contributor

    This is production

    Image
  8. m-natarajan commented on Mar 27, 2026

    @m-natarajan

    Repro v9.3.50-2 web chrome

    Screen.Recording.2026-03-28.at.01.33.42.mp4
  9. daledah commented on Mar 30, 2026

    @daledah
    Contributor

    I'll raise the follow up PR soon

  10. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. m-natarajan commented on Mar 30, 2026

    @m-natarajan

    Not Repro, Windows 10 / Chrome, v9.3.50-4

    bandicam.2026-03-30.15-35-56-068.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions