You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Tag option in Group by modal is missing bottom padding #86548
Version Number: 9.3.50-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#83799 Email or phone of affected tester (no customers):snodijosdnjoijiosnj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Chat Report View
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #83799 - "Update UI of lists with single and multi choice" by @zfurtak (High confidence) Related Issues: None
Recommendation: REVERT
PR #83799 changed SingleSelectListItem to use styles.optionRow (64px height) instead of styles.optionRowCompact (52px height), but the container height calculation in getSelectionListPopoverHeight still uses optionRowHeightCompact to calculate the list height. This mismatch causes the container to be too small, cutting off the bottom padding of the last item.
Labels: Keeping DeployBlockerCash as this is a frontend App issue that requires an App PR to fix. This issue is staging-only and reproducible, blocking the App deploy.
📋 Detailed Analysis
Evidence
The bug report mentions "Tag option is missing bottom padding" in the Group by modal
The function calculates container height using optionRowHeightCompact (52px), but items now render at 64px height, causing a 12px shortfall per item.
Root Cause
The PR changed list item rendering height from 52px to 64px without updating the container height calculation, causing the modal container to be undersized and cutting off the bottom padding of the last visible item.
PR #83799 changed SingleSelectListItem's wrapperStyle from styles.optionRowCompact (minHeight 52px) to styles.optionRow (minHeight 64px) in SingleSelectListItem.tsx.
However, the getSelectionListPopoverHeight function in styles/index.ts still uses variables.optionRowHeightCompact (52px) to calculate the popover container height. For the Group By dropdown with 2 items, this calculates a height of 2 × 52 + 12 = 116px, but the actual content needs 2 × 64 + padding ≈ 140px. The popover is ~24px too short, clipping the bottom padding of the last item ("Tag").
What changes do you think we should make in order to solve the problem?
Update getSelectionListPopoverHeight in src/styles/index.ts to use variables.optionRowHeight (64) instead of variables.optionRowHeightCompact (52) when estimating the list height, since SingleSelectListItem now uses styles.optionRow.
Note: There are 4 callers of this function — MoneyRequestReportTransactionList, MultiSelectPopup, SingleSelectPopup, and GroupByPopup in Search — all of which would benefit from this fix. Additionally, getUserSelectionListPopoverHeight on the next line also uses optionRowHeightCompact and may need the same update.
What alternative solutions did you explore? (Optional)
An alternative would be to revert SingleSelectListItem back to styles.optionRowCompact, but that would undo the intentional UI consistency improvement from the original PR. The better fix is to align the height calculation with the new item size.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Activity
melvin-bot commentedon Mar 27, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #83799
melvin-bot commentedon Mar 27, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Mar 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Mar 27, 2026
🔍 Investigation Summary
Classification: Frontend bug
Causing PR: #83799 - "Update UI of lists with single and multi choice" by @zfurtak (High confidence)
Related Issues: None
Recommendation: REVERT
PR #83799 changed
SingleSelectListItemto usestyles.optionRow(64px height) instead ofstyles.optionRowCompact(52px height), but the container height calculation ingetSelectionListPopoverHeightstill usesoptionRowHeightCompactto calculate the list height. This mismatch causes the container to be too small, cutting off the bottom padding of the last item.Labels: Keeping
DeployBlockerCashas this is a frontend App issue that requires an App PR to fix. This issue is staging-only and reproducible, blocking the App deploy.📋 Detailed Analysis
Evidence
styles.optionRowCompacttostyles.optionRowVerification
File affected:
src/components/Search/FilterDropdowns/GroupByPopup.tsxusesSingleSelectListItemandgetSelectionListPopoverHeightto calculate container height.PR #83799 changes to SingleSelectListItem.tsx (line 60):
Style definitions:
optionRowCompact: minHeight 52px, paddingTop/Bottom 12pxoptionRow: minHeight 64px, paddingTop/Bottom 12pxHeight calculation issue (
src/styles/index.tsline 6245):The function calculates container height using
optionRowHeightCompact(52px), but items now render at 64px height, causing a 12px shortfall per item.Root Cause
The PR changed list item rendering height from 52px to 64px without updating the container height calculation, causing the modal container to be undersized and cutting off the bottom padding of the last visible item.
MelvinBot commentedon Mar 27, 2026
Proposal
What is the root cause of that problem?
PR #83799 changed
SingleSelectListItem'swrapperStylefromstyles.optionRowCompact(minHeight 52px) tostyles.optionRow(minHeight 64px) inSingleSelectListItem.tsx.However, the
getSelectionListPopoverHeightfunction instyles/index.tsstill usesvariables.optionRowHeightCompact(52px) to calculate the popover container height. For the Group By dropdown with 2 items, this calculates a height of2 × 52 + 12 = 116px, but the actual content needs2 × 64 + padding ≈ 140px. The popover is ~24px too short, clipping the bottom padding of the last item ("Tag").What changes do you think we should make in order to solve the problem?
Update
getSelectionListPopoverHeightinsrc/styles/index.tsto usevariables.optionRowHeight(64) instead ofvariables.optionRowHeightCompact(52) when estimating the list height, sinceSingleSelectListItemnow usesstyles.optionRow.Note: There are 4 callers of this function —
MoneyRequestReportTransactionList,MultiSelectPopup,SingleSelectPopup, andGroupByPopupin Search — all of which would benefit from this fix. Additionally,getUserSelectionListPopoverHeighton the next line also usesoptionRowHeightCompactand may need the same update.What alternative solutions did you explore? (Optional)
An alternative would be to revert
SingleSelectListItemback tostyles.optionRowCompact, but that would undo the intentional UI consistency improvement from the original PR. The better fix is to align the height calculation with the new item size.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.grgia commentedon Mar 27, 2026
Demoting as a blocker, but we'll need to address this either in a follow up or if we revert and push again
m-natarajan commentedon Mar 27, 2026
Passed, Chrome / v9.3.50-2
Screen.Recording.2026-03-27.at.19.40.22.mp4
melvin-bot commentedon Mar 30, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
grgia commentedon Jun 11, 2026
This can be closed