Skip to content

Expense - Tag option in Group by modal is missing bottom padding #86548

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.50-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83799
Email or phone of affected tester (no customers): snodijosdnjoijiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Chat Report View

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Open the report.
  5. Click Group by.

Expected Result:

Tag option will have bottom padding.

Actual Result:

Tag option is missing bottom padding.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @zfurtak

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 27, 2026
  2. melvin-bot commented on Mar 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #83799

  3. melvin-bot commented on Mar 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Mar 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Mar 27, 2026

    @OSBotify
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: #83799 - "Update UI of lists with single and multi choice" by @zfurtak (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #83799 changed SingleSelectListItem to use styles.optionRow (64px height) instead of styles.optionRowCompact (52px height), but the container height calculation in getSelectionListPopoverHeight still uses optionRowHeightCompact to calculate the list height. This mismatch causes the container to be too small, cutting off the bottom padding of the last item.

    Labels: Keeping DeployBlockerCash as this is a frontend App issue that requires an App PR to fix. This issue is staging-only and reproducible, blocking the App deploy.

    📋 Detailed Analysis

    Evidence

    1. The bug report mentions "Tag option is missing bottom padding" in the Group by modal
    2. PR Enhance icons UI consistency #83799 was explicitly linked in the issue by melvin-bot
    3. The PR changed SingleSelectListItem wrapper style from styles.optionRowCompact to styles.optionRow

    Verification

    File affected: src/components/Search/FilterDropdowns/GroupByPopup.tsx uses SingleSelectListItem and getSelectionListPopoverHeight to calculate container height.

    PR #83799 changes to SingleSelectListItem.tsx (line 60):

    - wrapperStyle={[styles.optionRowCompact, wrapperStyle]}
    + wrapperStyle={[styles.optionRow, wrapperStyle]}

    Style definitions:

    • optionRowCompact: minHeight 52px, paddingTop/Bottom 12px
    • optionRow: minHeight 64px, paddingTop/Bottom 12px

    Height calculation issue (src/styles/index.ts line 6245):

    const ESTIMATED_LIST_HEIGHT = itemCount * variables.optionRowHeightCompact + ...

    The function calculates container height using optionRowHeightCompact (52px), but items now render at 64px height, causing a 12px shortfall per item.

    Root Cause

    The PR changed list item rendering height from 52px to 64px without updating the container height calculation, causing the modal container to be undersized and cutting off the bottom padding of the last visible item.

  6. MelvinBot commented on Mar 27, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR #83799 changed SingleSelectListItem's wrapperStyle from styles.optionRowCompact (minHeight 52px) to styles.optionRow (minHeight 64px) in SingleSelectListItem.tsx.

    However, the getSelectionListPopoverHeight function in styles/index.ts still uses variables.optionRowHeightCompact (52px) to calculate the popover container height. For the Group By dropdown with 2 items, this calculates a height of 2 × 52 + 12 = 116px, but the actual content needs 2 × 64 + padding ≈ 140px. The popover is ~24px too short, clipping the bottom padding of the last item ("Tag").

    What changes do you think we should make in order to solve the problem?

    Update getSelectionListPopoverHeight in src/styles/index.ts to use variables.optionRowHeight (64) instead of variables.optionRowHeightCompact (52) when estimating the list height, since SingleSelectListItem now uses styles.optionRow.

    Note: There are 4 callers of this function — MoneyRequestReportTransactionList, MultiSelectPopup, SingleSelectPopup, and GroupByPopup in Search — all of which would benefit from this fix. Additionally, getUserSelectionListPopoverHeight on the next line also uses optionRowHeightCompact and may need the same update.

    What alternative solutions did you explore? (Optional)

    An alternative would be to revert SingleSelectListItem back to styles.optionRowCompact, but that would undo the intentional UI consistency improvement from the original PR. The better fix is to align the height calculation with the new item size.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 27, 2026
  8. grgia commented on Mar 27, 2026

    @grgia
    Contributor

    Demoting as a blocker, but we'll need to address this either in a follow up or if we revert and push again

  9. m-natarajan commented on Mar 27, 2026

    @m-natarajan

    Passed, Chrome / v9.3.50-2

    Screen.Recording.2026-03-27.at.19.40.22.mp4
  10. melvin-bot commented on Mar 30, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. grgia commented on Jun 11, 2026

    @grgia
    Contributor

    This can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions