Skip to content

[Due for payment 2026-04-14] Wallet - Action required is shown when legal name is already filled #86803

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.51-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #80020
Email or phone of affected tester (no customers): snodijosdnjoijiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: User Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account > Wallet.
  3. Click Add bank account.
  4. Click Get reimbursed.
  5. Select United States > Next.
  6. Click Log into your bank.
  7. Complete Plaid flow.
  8. Select bank account, add legal name, address and phone, then click Confirm.
  9. Click Continue.
  10. Go to Account > Profile.
    → Legal name is filled in Private details section.
  11. Go to Account > Wallet.
  12. Click on the added personal account.

Expected Result:

No Action required will appear because Legal name is already filled in Private details section.

Actual Result:

Action required appears when Legal name is already filled in Private details section.
Clicking on the bank account opens Legal name page again.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7118374_1774987922448.11.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Mar 31, 2026
  2. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #80020

  3. melvin-bot commented on Mar 31, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Mar 31, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Mar 31, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #80020 - "feat: Update option missing for Personal Bank Accounts in ND compared to Classic" by @TaduJR (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #80020 should be reverted. The implementation has a logic flaw where isPersonalBankAccountMissingInfo() only checks the bank account's additionalData fields, but does not consider the user's privatePersonalDetails (Profile data).

    Labels: No label changes needed - this is a Frontend bug, so DeployBlockerCash should remain.

    Detailed Analysis

    Evidence

    The issue states that after completing the Plaid flow where legal name was filled (step 10 confirms "Legal name is filled in Private details section"), the bank account still shows "Action required" when it should not.

    According to the test steps in PR #80020:

    "Steps with info already in your profile should be automatically skipped"
    "If the user has multiple personal bank accounts missing info, verify completing the flow for one removes the badge from all of them"

    This indicates the system should check the user's profile data, not just individual bank account data.

    Verification

    File: src/libs/BankAccountUtils.ts (lines 60-78)

    The isPersonalBankAccountMissingInfo() function only checks accountData.additionalData:

    function isPersonalBankAccountMissingInfo(accountData: AccountData | undefined): boolean {
        // ... checks ...
        const {additionalData} = accountData;
        return !hasOwnerName(additionalData) || !hasOwnerAddress(additionalData) || !hasOwnerPhone(additionalData);
    }

    Where hasOwnerName, hasOwnerAddress, and hasOwnerPhone check fields like:

    • additionalData?.firstName and additionalData?.lastName
    • additionalData?.addressStreet, additionalData?.addressCity, etc.
    • additionalData?.companyPhone

    File: src/pages/settings/Wallet/UpdatePersonalBankAccountPage.tsx (lines 129-138)

    The update flow correctly falls back to privatePersonalDetails:

    const legalFirstName = personalBankAccountDraft?.legalFirstName ?? privatePersonalDetails?.legalFirstName ?? existingData?.firstName ?? ;
    const legalLastName = personalBankAccountDraft?.legalLastName ?? privatePersonalDetails?.legalLastName ?? existingData?.lastName ?? ;

    File: src/pages/settings/Wallet/InternationalDepositAccount/PersonalInfo/utils/getSkippedStepsPersonalInfo.ts

    During bank account creation, steps are skipped if data exists in privatePersonalDetails:

    if (!!data?.legalFirstName && !!data?.legalLastName) {
        skippedSteps.push(1);  // Skip legal name step
    }

    Root Cause

    When a user adds a personal bank account via Plaid:

    1. If they already have legal name in their profile (privatePersonalDetails), the legal name step is skipped
    2. The profile data is sent to the API when creating the account
    3. However, the API response may not populate the bank account's additionalData fields with this information
    4. When isPersonalBankAccountMissingInfo() runs, it only checks additionalData and finds it missing
    5. "Action required" badge is shown even though the user's profile already has the required information

    The function should check privatePersonalDetails as a fallback, similar to how the update flow and creation flow already do.

  6. OSBotify commented on Mar 31, 2026

    @OSBotify
    Contributor

    Label Update: Removed DeployBlocker label. This is a Frontend bug affecting the App deploy only, so DeployBlockerCash remains.

  7. 2 remaining items

  8. melvin-bot commented on Apr 1, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. m-natarajan commented on Apr 1, 2026

    @m-natarajan

    Not Repro, Windows 10 / chrome, v9.3.51-7

    bandicam.2026-04-01.18-18-53-109.mp4
  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 7, 2026
  11. changed the title [-]Wallet - Action required is shown when legal name is already filled[/-] [+][Due for payment 2026-04-14] Wallet - Action required is shown when legal name is already filled[/+] on Apr 7, 2026
  12. melvin-bot commented on Apr 7, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Apr 7, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.52-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-14. 🎊

  14. melvin-bot commented on Apr 7, 2026

    @melvin-bot

    @chuckdries The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. melvin-bot commented on Apr 7, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions