Skip to content

[Due for payment 2026-05-26] Decompose IOURequestStepConfirmation for Create Expense performance #86986

Closed

Description

@Julesssss

Sub-issue of #81849, coming from here.

Comment related to this task.

Task

IOURequestStepConfirmation is ~1700 lines with 41 Onyx subscriptions handling 8 submission flows. 58% of those subscriptions are only accessed on confirm press, causing unnecessary re-renders throughout the Create Expense flow.

  • Extract side-effect hooks into renderless components
  • Move callback-only subscriptions behind refs
  • Split into focused variant components per submission type

Initial PR here: #86865

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Apr 2, 2026
  2. Julesssss commented on Apr 7, 2026

    @Julesssss
    ContributorAuthor

    PR merged 🎉

  3. 42 remaining items

  4. melvin-bot commented on May 15, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. melvin-bot commented on May 19, 2026

    @melvin-bot

    @mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  6. melvin-bot commented on May 21, 2026

    @melvin-bot

    @mallenexpensify Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

  7. changed the title [-]Decompose IOURequestStepConfirmation for Create Expense performance[/-] [+][Due for payment 2026-05-26] Decompose IOURequestStepConfirmation for Create Expense performance[/+] on May 25, 2026
  8. cristipaval commented on May 25, 2026

    @cristipaval
    Contributor

    @mallenexpensify, this is awaiting payments. No checklist needed. @bernhardoj did the C+ review on 2 PRs.

  9. melvin-bot commented on May 26, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. melvin-bot commented on May 28, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. cristipaval commented on Jun 1, 2026

    @cristipaval
    Contributor

    I've just pinged @mallenexpensify internally about this one.

  12. mallenexpensify commented on Jun 1, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @bernhardoj due $500 via NewDot

    Apologies for the delay, unsure exactly what happened but, having 2 PRs might have played a role.
    What's weird is.. I checked both gmail notifications and K2 and didn't see ¯_(ツ)_/¯

  13. flaviadefaria commented on Jun 2, 2026

    @flaviadefaria
    Contributor

    Approved: @bernhardoj due $500 via NewDot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions