Skip to content

[$500] PR authoring & reviewing best practices guide and Proposal Police updates #87003

Closed

Description

@mallenexpensify

Coming from here in #bug-zero

@ikevin127 authored a new PR authoring & reviewing best practices guide for Expensify/App contributors (PR #80839), and fixed the proposal police GitHub Action that was incorrectly false-flagging bot comments and non-proposal comments containing the "Proposal" keyword (PRs #82734 and #83279). The documentation work involved writing 386 lines of standards and updating 3 existing guides. The proposal police fix involved modifying the GH Action's TypeScript source and constants to whitelist bots and improve proposal detection heuristics across 3 iterative PRs (2 payable).

Issue OwnerCurrent Issue Owner: @ikevin127

Activity

  1. melvin-bot commented on Apr 2, 2026

    @melvin-bot

    Current assignee @mallenexpensify is eligible for the Awaiting Payment assigner, not assigning anyone new.

  2. mallenexpensify commented on Apr 2, 2026

    @mallenexpensify
    ContributorAuthor

    Payment Summary

    Contributor+: @ikevin127 due $500 via NewDot

  3. garrettmknight commented on Apr 8, 2026

    @garrettmknight
    Contributor

    $500 approved for @ikevin127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions