Repository navigation
[HOLD for payment 2022-06-13] [$250] Update the IOU "Cancel" button so that it has a fixed size - reported by @Puneet-here #8715
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Request money from someone
- Cancel the money request the button size will increase when loading
Expected Result:
Update the logic of the Cancel button so that it doesn't re-size at all.
Actual Result:
After being clicked, the IOU Cancel button size increases momentarily and then disappears. That's strange visually.
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.1.56-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
XRecorder_Edited_31032022_001537.mp4
Upwork job link: https://www.upwork.com/jobs/~019f02e58e1d9ac630
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648666290760469
Activity
melvin-bot commentedon Apr 21, 2022
Triggered auto assignment to @flaviadefaria (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.melvin-bot commentedon Apr 25, 2022
Triggered auto assignment to @francoisl (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.thesahindia commentedon Apr 25, 2022
Proposal
We can just set a minWidth for this button.
minWidth: 61will be good for cancel/decline button andminWidth: 69for spanish ones. We can add a function inStyleUtilswhich will return minWidth based on thepreferredLocale.Or instead of this we can just set the minWidth to larger one (that's what we did for the resend link button #6958)
We can add the style like this -
App/src/styles/styles.js
Lines 937 to 939 in 65432d6
We will have to use the style here and we can remove line 96-
App/src/components/ReportTransaction.js
Lines 92 to 97 in 65432d6
52 remaining items
Santhosh-Sellavel commentedon Jun 1, 2022
PR got merged today, it's already on staging.
I'm going OOO, If there are any new breakages/regression while I am away, feel free to un-assign me and add a new C+ here thanks!
cc: @roryabraham
michaelhaxhiu commentedon Jun 1, 2022
@Santhosh-Sellavel want to apply for the job before you go OOO? https://www.upwork.com/jobs/~019f02e58e1d9ac630
Santhosh-Sellavel commentedon Jun 1, 2022
Ya, sure thanks! @michaelhaxhiu
[-][$250] Update the IOU "Cancel" button so that it has a fixed size - reported by @Puneet-here[/-][+][HOLD for payment 2022-06-13] [$250] Update the IOU "Cancel" button so that it has a fixed size - reported by @Puneet-here[/+]melvin-bot commentedon Jun 6, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.71-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-06-13. 🎊
michaelhaxhiu commentedon Jun 14, 2022
All are paid. Closing. Thanks for your assistance!