You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Infinite loading after adding an expense to report #87209
Version Number: 9.3.53-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#86636 Email or phone of affected tester (no customers):jsdjosidjiojisojio3@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an empty report.
Open the report.
Click + > Create expense > Manual.
Create a manual expense.
Expected Result:
Expense report will show the expense details after creating the expense.
Actual Result:
Expense report loads infinitely after creating the expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root Cause:reportTransactionsAndViolations.ts:32 mutates currentValue in-place instead of creating a new object reference. Onyx 3.0.58's reference-stable removeNestedNullValues (introduced in PR #86636) now returns the same reference when no nulls are found, so Onyx's keyChanged() sees lastConnectionCallbackData === value → skips subscriber notifications → useOnyx never re-renders → infinite loading.
This ensures the derived value compute function always returns a new top-level reference when data changes, so Onyx detects the update and notifies subscribers.
Likely duplicate of:#87179 ("Report Preview Not Updating After Adding Expense Until Manual Refresh") — the consolidated deploy blocker covering 4 other issues (#87197, #87199, #87200, #87201) all traced to the same root cause.
Investigation details
Data flow leading to the bug:
User creates expense → Onyx updates COLLECTION.TRANSACTION with optimistic data
reportTransactionsAndViolations derived value compute runs, reuses currentValue reference, mutates it in-place
setDerivedValue calls Onyx.set(key, value)
removeNestedNullValues(value) returns the same reference (no nulls to strip — new behavior in Onyx 3.0.58)
useOnyx hook never fires onStoreChange → React never re-renders → skeleton/loading persists
Why this worked before Onyx 3.0.58:
Before the structural sharing optimization, removeNestedNullValues always created a fresh object copy, which meant even mutated-in-place values got a new reference, masking the latent mutation bug.
Contributing factor:shouldWaitForTransactions in MoneyRequestReportUtils.ts:132-146 checks pendingFields?.createReport but optimistic data sets pendingFields.createChat, so the bypass for optimistic reports doesn't trigger. When transactions.length === 0 and report.total !== 0, the skeleton is shown.
Next Steps: This appears to be a duplicate of #87179. Reply with @MelvinBot implement this to create a draft PR, or @MelvinBot <your feedback> to refine this analysis.
changed the title [-]Expense - Infinite loading after adding an expense to report[/-][+][Due for payment 2026-04-23] Expense - Infinite loading after adding an expense to report[/+]on Apr 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.59-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Julesssss The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
changed the title [-][Due for payment 2026-04-23] Expense - Infinite loading after adding an expense to report[/-][+]Expense - Infinite loading after adding an expense to report[/+]on Apr 17, 2026
Activity
melvin-bot commentedon Apr 7, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #86636
melvin-bot commentedon Apr 7, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 7, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Apr 7, 2026
Issue Analysis
Root Cause:
reportTransactionsAndViolations.ts:32mutatescurrentValuein-place instead of creating a new object reference. Onyx 3.0.58's reference-stableremoveNestedNullValues(introduced in PR #86636) now returns the same reference when no nulls are found, so Onyx'skeyChanged()seeslastConnectionCallbackData === value→ skips subscriber notifications →useOnyxnever re-renders → infinite loading.Recommended Fix: Change line 32 of
src/libs/actions/OnyxDerived/configs/reportTransactionsAndViolations.tsfrom:to:
This ensures the derived value compute function always returns a new top-level reference when data changes, so Onyx detects the update and notifies subscribers.
Likely duplicate of: #87179 ("Report Preview Not Updating After Adding Expense Until Manual Refresh") — the consolidated deploy blocker covering 4 other issues (#87197, #87199, #87200, #87201) all traced to the same root cause.
Investigation details
Data flow leading to the bug:
COLLECTION.TRANSACTIONwith optimistic datareportTransactionsAndViolationsderived value compute runs, reusescurrentValuereference, mutates it in-placesetDerivedValuecallsOnyx.set(key, value)removeNestedNullValues(value)returns the same reference (no nulls to strip — new behavior in Onyx 3.0.58)keyChanged()checkslastConnectionCallbackData === value→ true → subscriber callback skippeduseOnyxhook never firesonStoreChange→ React never re-renders → skeleton/loading persistsWhy this worked before Onyx 3.0.58:
Before the structural sharing optimization,
removeNestedNullValuesalways created a fresh object copy, which meant even mutated-in-place values got a new reference, masking the latent mutation bug.Contributing factor:
shouldWaitForTransactionsinMoneyRequestReportUtils.ts:132-146checkspendingFields?.createReportbut optimistic data setspendingFields.createChat, so the bypass for optimistic reports doesn't trigger. Whentransactions.length === 0andreport.total !== 0, the skeleton is shown.Next Steps: This appears to be a duplicate of #87179. Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.pecanoro commentedon Apr 7, 2026
I read Melvin's explanation and it seems to be a front-end related bug so removing the web deploy blocker label
8 remaining items
m-natarajan commentedon Apr 7, 2026
Not Repro, Windows 10 / Chrome, Honor x6b /Android 14, v9.3.53-7
SVID_20260407_160855_1.mp4
bandicam.2026-04-07.16-01-03-616.mp4
Julesssss commentedon Apr 7, 2026
Thank you! Checking off
melvin-bot commentedon Apr 8, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Expense - Infinite loading after adding an expense to report[/-][+][Due for payment 2026-04-23] Expense - Infinite loading after adding an expense to report[/+]melvin-bot commentedon Apr 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.59-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-23. 🎊
melvin-bot commentedon Apr 16, 2026
@Julesssss The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][Due for payment 2026-04-23] Expense - Infinite loading after adding an expense to report[/-][+]Expense - Infinite loading after adding an expense to report[/+]