You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-23] Android - Chat - Different typing mode when rotating device from portrait to landscape #87310
Version Number: 9.3.54-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85229 Email or phone of affected tester (no customers):jsdjosidjiojisojio3@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Money Requests
Action Performed:
Launch Expensify app in landscape mode.
Go to workspace chat.
Tap on the composer.
→ Typing takes place directly on the composer.
Rotate the device to portrait, then back to landscape.
→ Typing takes place on a different modal.
Expected Result:
After rotating device from portrait to landscape, typing should take place inline on the composer.
Actual Result:
After rotating device from portrait to landscape, typing takes place on a different modal.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Android's IME (keyboard) reads the IME_FLAG_NO_FULLSCREEN flag only once — during onCreateInputConnection(), when the keyboard first connects to the text field. PR #85229 added disableFullscreenUI={isInLandscapeMode} to the Composer (src/components/Composer/implementation/index.native.tsx:139), which correctly sets this flag on rotation. However, React Native's ReactEditText.kt updates imeOptions on the view object but never calls InputMethodManager.restartInput(), so the already-connected IME never re-reads the updated flags.
Rotate to landscape: React re-renders with disableFullscreenUI=true → updateImeOptions() sets the flag on the view, but the IME has already cached its connection
Android's IME, now in landscape without the no-fullscreen flag, switches to extract/fullscreen (modal) editing
When starting directly in landscape, the flag is set beforeonCreateInputConnection(), so the IME respects it from the start.
What changes do you think we should make in order to solve the problem?
Add a key={String(isInLandscapeMode)} prop to the MarkdownTextInput in src/components/Composer/implementation/index.native.tsx so the component remounts on orientation change, forcing a fresh onCreateInputConnection() call with the correct disableFullscreenUI value.
The same fix should be applied to the RNMarkdownTextInput in src/components/TextInput/BaseTextInput/implementation/index.native.tsx:435 which also sets disableFullscreenUI={isInLandscapeMode}.
What alternative solutions did you explore?
Patch ReactEditText.kt to call restartInput() after updating imeOptions — this is the proper upstream fix but requires a React Native patch, which is heavier.
Dismiss and re-show the keyboard on orientation change — more complex, introduces UX flicker, and harder to get right across devices.
Blur the input on orientation change and let the user re-tap — poor UX, especially for a deploy blocker.
The key prop approach is the simplest, app-level fix that guarantees a fresh input connection with the correct flags.
src/components/TextInput/BaseTextInput/implementation/index.native.tsx:435 — same pattern
node_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt:176-181 — disableFullscreenUI setter calls updateImeOptions() but does NOT call restartInput()
ReactEditText.kt:957-976 — updateImeOptions() sets imeOptions with IME_FLAG_NO_FULLSCREEN on the view, but the IME doesn't re-read it
ReactEditText.kt:355-373 — onCreateInputConnection() is where the IME reads imeOptions, and it's only called when the IME first connects
No occurrences of restartInput found in React Native's TextInput implementation
AndroidManifest.xml:40 — configChanges includes orientation|screenSize, so the activity is NOT recreated (React Native handles it via dimension updates)
AndroidManifest.xml:45 — windowSoftInputMode=adjustResize makes the visible area very small in landscape, triggering Android's extract mode
Why Android-only: iOS doesn't have an equivalent "extract mode" — fullscreen text editing is an Android IME behavior specific to landscape + small visible area.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Android - Chat - Different typing mode when rotating device from portrait to landscape[/-][+][Due for payment 2026-04-23] Android - Chat - Different typing mode when rotating device from portrait to landscape[/+]on Apr 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.59-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 8, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #85229
melvin-bot commentedon Apr 8, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 8, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Apr 8, 2026
Proposal
What is the root cause of that problem?
Android's IME (keyboard) reads the
IME_FLAG_NO_FULLSCREENflag only once — duringonCreateInputConnection(), when the keyboard first connects to the text field. PR #85229 addeddisableFullscreenUI={isInLandscapeMode}to the Composer (src/components/Composer/implementation/index.native.tsx:139), which correctly sets this flag on rotation. However, React Native'sReactEditText.ktupdatesimeOptionson the view object but never callsInputMethodManager.restartInput(), so the already-connected IME never re-reads the updated flags.Flow:
disableFullscreenUI=false→onCreateInputConnection()creates connection withoutIME_FLAG_NO_FULLSCREENdisableFullscreenUI=true→updateImeOptions()sets the flag on the view, but the IME has already cached its connectionWhen starting directly in landscape, the flag is set before
onCreateInputConnection(), so the IME respects it from the start.What changes do you think we should make in order to solve the problem?
Add a
key={String(isInLandscapeMode)}prop to theMarkdownTextInputinsrc/components/Composer/implementation/index.native.tsxso the component remounts on orientation change, forcing a freshonCreateInputConnection()call with the correctdisableFullscreenUIvalue.The same fix should be applied to the
RNMarkdownTextInputinsrc/components/TextInput/BaseTextInput/implementation/index.native.tsx:435which also setsdisableFullscreenUI={isInLandscapeMode}.What alternative solutions did you explore?
ReactEditText.ktto callrestartInput()after updating imeOptions — this is the proper upstream fix but requires a React Native patch, which is heavier.The
keyprop approach is the simplest, app-level fix that guarantees a fresh input connection with the correct flags.Investigation details
Evidence chain:
src/components/Composer/implementation/index.native.tsx:139— setsdisableFullscreenUI={isInLandscapeMode}reactivelysrc/components/TextInput/BaseTextInput/implementation/index.native.tsx:435— same patternnode_modules/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactEditText.kt:176-181—disableFullscreenUIsetter callsupdateImeOptions()but does NOT callrestartInput()ReactEditText.kt:957-976—updateImeOptions()setsimeOptionswithIME_FLAG_NO_FULLSCREENon the view, but the IME doesn't re-read itReactEditText.kt:355-373—onCreateInputConnection()is where the IME readsimeOptions, and it's only called when the IME first connectsrestartInputfound in React Native's TextInput implementationAndroidManifest.xml:40—configChangesincludesorientation|screenSize, so the activity is NOT recreated (React Native handles it via dimension updates)AndroidManifest.xml:45—windowSoftInputMode=adjustResizemakes the visible area very small in landscape, triggering Android's extract modeWhy Android-only: iOS doesn't have an equivalent "extract mode" — fullscreen text editing is an Android IME behavior specific to landscape + small visible area.
Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.rushatgabhane commentedon Apr 8, 2026
I'd say this is not a blocker because landscape mode is a new feature. Let's fix it as a regular issue
13 remaining items
[-]Android - Chat - Different typing mode when rotating device from portrait to landscape[/-][+][Due for payment 2026-04-23] Android - Chat - Different typing mode when rotating device from portrait to landscape[/+]melvin-bot commentedon Apr 16, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 16, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.59-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-23. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 16, 2026
@truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 21, 2026
@truph01 Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Apr 22, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Apr 23, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Apr 23, 2026
Payment Summary
Contributor+: @truph01 due $125 via NewDot
regression