Skip to content

[Due for payment 2026-04-30] Android - QBD - "QuickBooks Desktop setup" page is not scrollable #87409

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.54-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85229
Email or phone of affected tester (no customers): jsdjosidjiojisojio3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Workspace Settings

Action Performed:

  1. Launch Expensify app in landscape mode.
  2. Go to workspace settings > Accounting (enable in More features).
  3. Tap Connect QuickBooks Desktop.
  4. Upgrade workspace if needed.
  5. Scroll "QuickBooks Desktop setup" page.

Expected Result:

"QuickBooks Desktop setup" page should be scrollable.

Actual Result:

"QuickBooks Desktop setup" page is not scrollable.
Part of the content is blocked by Got it button.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7125040_1775667447381.Screen_Recording_20260409_005524_Expensify.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @truph01

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 8, 2026
  2. melvin-bot commented on Apr 8, 2026

    @melvin-bot

    @mjasikowski recently merged #85229, but they are OOO right now, so I'll auto-assign someone else.

  3. melvin-bot commented on Apr 8, 2026

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 8, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 8, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Apr 8, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #85229 - "Unlock landscape mode" by @GCyganek (High confidence)
    Related Issues: None

    Recommendation: ROLL FORWARD

    PR #85229 unlocked landscape mode for all screens but fixed scrollability only for some pages (e.g., SageIntacctPrerequisitesPage) while missing QuickBooksDesktopSetupPage. The fix is straightforward - add a ScrollView wrapper to the QBD setup page - and reverting would re-lock landscape mode for all users, which is a bigger regression.

    Assigned: @GCyganek (PR author), @rushatgabhane, @truph01, @mjasikowski (approving reviewers)
    Labels: No label changes - DeployBlockerCash is correct (App PR caused the issue, staging-only)

    Detailed Analysis

    Evidence

    Verification

    • Affected file: src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsx
    • PR Unlock landscape mode #85229 does NOT directly modify QuickBooksDesktopSetupPage.tsx - confirmed via gh pr diff 85229
    • However, PR Unlock landscape mode #85229 did fix the similar SageIntacctPrerequisitesPage.tsx by replacing a plain View wrapper with a ScrollView (visible in the diff), while leaving the QBD page untreated
    • QuickBooksDesktopSetupPage.tsx uses a View with flex1 around its content with a FixedFooter inside - no ScrollView is present, so content is unscrollable in landscape when vertical space is reduced

    Root Cause

    Before PR #85229, landscape mode was locked on phones (Android orientation XML files enforced portrait-only). PR #85229 removed those locks and added landscape support, but the QuickBooks Desktop setup page was never updated to support landscape layout. The page renders its content in a non-scrollable View with a FixedFooter containing the "Done" button. In landscape mode on a phone, the reduced vertical height means the footer overlaps the content with no way to scroll past it. The fix is to wrap the page content in a ScrollView, the same pattern applied to SageIntacctPrerequisitesPage in that same PR.

  7. 12 remaining items

  8. changed the title [-]Android - QBD - "QuickBooks Desktop setup" page is not scrollable[/-] [+][Due for payment 2026-04-30] Android - QBD - "QuickBooks Desktop setup" page is not scrollable[/+] on Apr 23, 2026
  9. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-30. 🎊

    For reference, here are some details about the assignees on this issue:

    • @GCyganek does not require payment (Contractor)
    • @truph01 requires payment through NewDot Manual Requests
  11. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    @truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. melvin-bot commented on Apr 23, 2026

    @melvin-bot

    @truph01 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

  13. melvin-bot commented on Apr 27, 2026

    @melvin-bot

    @truph01 12 days overdue. Walking. Toward. The. Light...

  14. GCyganek commented on Apr 28, 2026

    @GCyganek
    Contributor

    Deployed to production

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions