You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-30] Android - QBD - "QuickBooks Desktop setup" page is not scrollable #87409
Version Number: 9.3.54-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#85229 Email or phone of affected tester (no customers):jsdjosidjiojisojio3@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Workspace Settings
Action Performed:
Launch Expensify app in landscape mode.
Go to workspace settings > Accounting (enable in More features).
Tap Connect QuickBooks Desktop.
Upgrade workspace if needed.
Scroll "QuickBooks Desktop setup" page.
Expected Result:
"QuickBooks Desktop setup" page should be scrollable.
Actual Result:
"QuickBooks Desktop setup" page is not scrollable.
Part of the content is blocked by Got it button.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #85229 - "Unlock landscape mode" by @GCyganek (High confidence) Related Issues: None
Recommendation: ROLL FORWARD
PR #85229 unlocked landscape mode for all screens but fixed scrollability only for some pages (e.g., SageIntacctPrerequisitesPage) while missing QuickBooksDesktopSetupPage. The fix is straightforward - add a ScrollView wrapper to the QBD setup page - and reverting would re-lock landscape mode for all users, which is a bigger regression.
Assigned: @GCyganek (PR author), @rushatgabhane, @truph01, @mjasikowski (approving reviewers) Labels: No label changes - DeployBlockerCash is correct (App PR caused the issue, staging-only)
PR Unlock landscape mode #85229 does NOT directly modify QuickBooksDesktopSetupPage.tsx - confirmed via gh pr diff 85229
However, PR Unlock landscape mode #85229 did fix the similar SageIntacctPrerequisitesPage.tsx by replacing a plain View wrapper with a ScrollView (visible in the diff), while leaving the QBD page untreated
QuickBooksDesktopSetupPage.tsx uses a View with flex1 around its content with a FixedFooter inside - no ScrollView is present, so content is unscrollable in landscape when vertical space is reduced
Root Cause
Before PR #85229, landscape mode was locked on phones (Android orientation XML files enforced portrait-only). PR #85229 removed those locks and added landscape support, but the QuickBooks Desktop setup page was never updated to support landscape layout. The page renders its content in a non-scrollable View with a FixedFooter containing the "Done" button. In landscape mode on a phone, the reduced vertical height means the footer overlaps the content with no way to scroll past it. The fix is to wrap the page content in a ScrollView, the same pattern applied to SageIntacctPrerequisitesPage in that same PR.
changed the title [-]Android - QBD - "QuickBooks Desktop setup" page is not scrollable[/-][+][Due for payment 2026-04-30] Android - QBD - "QuickBooks Desktop setup" page is not scrollable[/+]on Apr 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 8, 2026
@mjasikowski recently merged #85229, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Apr 8, 2026
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 8, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 8, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 8, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #85229 - "Unlock landscape mode" by @GCyganek (High confidence)
Related Issues: None
Recommendation: ROLL FORWARD
PR #85229 unlocked landscape mode for all screens but fixed scrollability only for some pages (e.g.,
SageIntacctPrerequisitesPage) while missingQuickBooksDesktopSetupPage. The fix is straightforward - add aScrollViewwrapper to the QBD setup page - and reverting would re-lock landscape mode for all users, which is a bigger regression.Assigned: @GCyganek (PR author), @rushatgabhane, @truph01, @mjasikowski (approving reviewers)
Labels: No label changes -
DeployBlockerCashis correct (App PR caused the issue, staging-only)Detailed Analysis
Evidence
Verification
src/pages/workspace/accounting/qbd/QuickBooksDesktopSetupPage.tsxQuickBooksDesktopSetupPage.tsx- confirmed viagh pr diff 85229SageIntacctPrerequisitesPage.tsxby replacing a plainViewwrapper with aScrollView(visible in the diff), while leaving the QBD page untreatedQuickBooksDesktopSetupPage.tsxuses aViewwithflex1around its content with aFixedFooterinside - noScrollViewis present, so content is unscrollable in landscape when vertical space is reducedRoot Cause
Before PR #85229, landscape mode was locked on phones (Android orientation XML files enforced portrait-only). PR #85229 removed those locks and added landscape support, but the QuickBooks Desktop setup page was never updated to support landscape layout. The page renders its content in a non-scrollable
Viewwith aFixedFootercontaining the "Done" button. In landscape mode on a phone, the reduced vertical height means the footer overlaps the content with no way to scroll past it. The fix is to wrap the page content in aScrollView, the same pattern applied toSageIntacctPrerequisitesPagein that same PR.12 remaining items
[-]Android - QBD - "QuickBooks Desktop setup" page is not scrollable[/-][+][Due for payment 2026-04-30] Android - QBD - "QuickBooks Desktop setup" page is not scrollable[/+]melvin-bot commentedon Apr 23, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 23, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.61-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 23, 2026
@truph01 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Apr 23, 2026
@truph01 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!
melvin-bot commentedon Apr 27, 2026
@truph01 12 days overdue. Walking. Toward. The. Light...
GCyganek commentedon Apr 28, 2026
Deployed to production