Skip to content

Attachment - "Take a photo" page is not scrollable in landscape mode #87444

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.55-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86981
Email or phone of affected tester (no customers): jsdjosidjiojisojio3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Chat Report View

Action Performed:

Precondition:

  • App camera access is denied.
  1. Launch Expensify app.
  2. Go to workspace chat.
  3. Tap + > Add attachment > Take photo.
  4. Rotate the device landscape.
  5. Scroll on the permission page.

Expected Result:

"Take a photo" page should be scrollable in landscape mode.

Actual Result:

"Take a photo" page is not scrollable in landscape mode.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7125387_1775697345138.Screen_Recording_20260409_091358_Expensify.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Apr 9, 2026
  2. melvin-bot commented on Apr 9, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #86981

  3. melvin-bot commented on Apr 9, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 9, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. MelvinBot commented on Apr 9, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    AttachmentCamera.tsx (line 170) renders the camera-permission-denied view inside a plain <View> with styles.permissionView (108px vertical padding). There is no ScrollView wrapper and no landscape-aware padding, so when the device is rotated to landscape the content overflows and is clipped with no way to scroll.

    The reference implementation in IOURequestStepScan/index.native.tsx (line 401) handles this correctly by wrapping the same view in <ScrollView contentContainerStyle={styles.flexGrow1}> and switching to styles.permissionViewLandscape (16px vertical padding) when in landscape mode.

    What changes do you think we should make in order to solve the problem?

    In src/components/AttachmentPicker/AttachmentCamera.tsx:

    1. Import ScrollView (from @components/ScrollView) and useIsInLandscapeMode (from @hooks/useIsInLandscapeMode).
    2. Call useIsInLandscapeMode() in the component body.
    3. Wrap the permission-denied <View> block in <ScrollView contentContainerStyle={styles.flexGrow1}>.
    4. Replace styles.permissionView with isInLandscapeMode ? styles.permissionViewLandscape : styles.permissionView.

    This matches the existing pattern in IOURequestStepScan.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  6. pecanoro commented on Apr 9, 2026

    @pecanoro
    Contributor

    This looks like a front-end blocker so removing the web blocker label

  7. removed
    DeployBlockerIndicates it should block deploying the API
    on Apr 9, 2026
  8. IuliiaHerets commented on Apr 10, 2026

    @IuliiaHerets

    Samsung A52 / Android 14
    v9.3.57-1

    can't repro if the scenario is taking photo in adding attachment, because "take photo" page isn't appeared.
    Then I try with scan receipt scenario, then "take photo" page is appeared, and it's not reproduced

    take.photo.mp4
  9. lakchote commented on Apr 10, 2026

    @lakchote
    Contributor

    Removing the blocker label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions