You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Attachment - "Take a photo" page is not scrollable in landscape mode #87444
Version Number: 9.3.55-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#86981 Email or phone of affected tester (no customers):jsdjosidjiojisojio3@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Samsung Galaxy S25 FE / Android 16 App Component: Chat Report View
Action Performed:
Precondition:
App camera access is denied.
Launch Expensify app.
Go to workspace chat.
Tap + > Add attachment > Take photo.
Rotate the device landscape.
Scroll on the permission page.
Expected Result:
"Take a photo" page should be scrollable in landscape mode.
Actual Result:
"Take a photo" page is not scrollable in landscape mode.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
AttachmentCamera.tsx (line 170) renders the camera-permission-denied view inside a plain <View> with styles.permissionView (108px vertical padding). There is no ScrollView wrapper and no landscape-aware padding, so when the device is rotated to landscape the content overflows and is clipped with no way to scroll.
The reference implementation in IOURequestStepScan/index.native.tsx (line 401) handles this correctly by wrapping the same view in <ScrollView contentContainerStyle={styles.flexGrow1}> and switching to styles.permissionViewLandscape (16px vertical padding) when in landscape mode.
What changes do you think we should make in order to solve the problem?
In src/components/AttachmentPicker/AttachmentCamera.tsx:
Import ScrollView (from @components/ScrollView) and useIsInLandscapeMode (from @hooks/useIsInLandscapeMode).
Call useIsInLandscapeMode() in the component body.
Wrap the permission-denied <View> block in <ScrollView contentContainerStyle={styles.flexGrow1}>.
Replace styles.permissionView with isInLandscapeMode ? styles.permissionViewLandscape : styles.permissionView.
This matches the existing pattern in IOURequestStepScan.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
can't repro if the scenario is taking photo in adding attachment, because "take photo" page isn't appeared.
Then I try with scan receipt scenario, then "take photo" page is appeared, and it's not reproduced
Activity
melvin-bot commentedon Apr 9, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #86981
melvin-bot commentedon Apr 9, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 9, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Apr 9, 2026
Proposal
What is the root cause of that problem?
AttachmentCamera.tsx(line 170) renders the camera-permission-denied view inside a plain<View>withstyles.permissionView(108px vertical padding). There is noScrollViewwrapper and no landscape-aware padding, so when the device is rotated to landscape the content overflows and is clipped with no way to scroll.The reference implementation in
IOURequestStepScan/index.native.tsx(line 401) handles this correctly by wrapping the same view in<ScrollView contentContainerStyle={styles.flexGrow1}>and switching tostyles.permissionViewLandscape(16px vertical padding) when in landscape mode.What changes do you think we should make in order to solve the problem?
In
src/components/AttachmentPicker/AttachmentCamera.tsx:ScrollView(from@components/ScrollView) anduseIsInLandscapeMode(from@hooks/useIsInLandscapeMode).useIsInLandscapeMode()in the component body.<View>block in<ScrollView contentContainerStyle={styles.flexGrow1}>.styles.permissionViewwithisInLandscapeMode ? styles.permissionViewLandscape : styles.permissionView.This matches the existing pattern in
IOURequestStepScan.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.pecanoro commentedon Apr 9, 2026
This looks like a front-end blocker so removing the web blocker label
IuliiaHerets commentedon Apr 10, 2026
Samsung A52 / Android 14
v9.3.57-1
can't repro if the scenario is taking photo in adding attachment, because "take photo" page isn't appeared.
Then I try with scan receipt scenario, then "take photo" page is appeared, and it's not reproduced
take.photo.mp4
lakchote commentedon Apr 10, 2026
Removing the blocker label.