Skip to content

[Due for payment 2026-05-18] [$250] Datepicker - Year is not found if any year prior to 2005 is entered in the search #87455

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.55-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85107
Email or phone of affected tester (no customers): fischer9966+053122@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: MacOS 26.4 / Chrome, Safari. Google Pixel 5 / Android 14
App Component: Search

Action Performed:

  1. Open Expensify App or go to staging.new.expensify.com
  2. Login with any account
  3. Click "+" > Create expense
  4. Input any amount > Next
  5. Select Date
  6. Click on Year to open year list
  7. Enter any full year prior to 2005 in search field. Eq 2000

Expected Result:

Entered year appeared in search result

Actual Result:

No results found if a year prior to 2005 is entered in full in the search field.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022042453113426418208
  • Upwork Job ID: 2042453113426418208
  • Last Price Increase: 2026-04-24

Activity

  1. mountiny commented on Apr 10, 2026

    @mountiny
    Contributor

    @jponikarchuk Why is this labelled as Monthly and Not a priority?

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed on Apr 10, 2026
  3. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 10, 2026
  4. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ChavdaSachin (External)

  5. changed the title [-]Datepicker - Year is not found if any year prior to 2005 is entered in the search[/-] [+][$250] Datepicker - Year is not found if any year prior to 2005 is entered in the search[/+] on Apr 10, 2026
  6. melvin-bot commented on Apr 10, 2026

    @melvin-bot
  7. MelvinBot commented on Apr 10, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The expense date picker (IOURequestStepDate.tsx:153) passes CONST.CALENDAR_PICKER.MIN_DATE as the minDate prop, which is defined as dateSubtract(new Date(), {years: 20}) (CONST/index.ts:54). This means the year list in CalendarPicker/index.tsx:105-112 is only populated with years from ~2006 to ~2027.

    When a user searches for "2000" (or any year outside this range) in YearPickerModal.tsx:35, the filter years.filter((year) => year.text?.includes(searchText)) correctly returns no matches because those years were never in the list to begin with.

    What changes do you think we should make in order to solve the problem?

    Change CONST.CALENDAR_PICKER.MIN_DATE in src/CONST/index.ts:54 from 20 years to a larger value (e.g., 100 years to match MIN_YEAR), so the year list includes older years. This single change would fix both the year search and the ability to select older dates across all date pickers that use this constant.

    Alternatively, if the 20-year limit is intentional for most contexts, update only IOURequestStepDate.tsx:153 to use a wider minDate (e.g., setYear(new Date(), CONST.CALENDAR_PICKER.MIN_YEAR)) so that the expense date picker specifically allows older dates while other pickers retain the current constraint.

    What alternative solutions did you explore? (Optional)

    Considered improving the search UX (e.g., showing "Year not available" instead of "No results found"), but that would just paper over the real issue — users legitimately need to select older dates for expenses.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  8. 42 remaining items

  9. melvin-bot commented on May 17, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. melvin-bot commented on May 18, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2042453113426418208/hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. melvin-bot commented on May 20, 2026

    @melvin-bot

    @mallenexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. melvin-bot commented on May 22, 2026

    @melvin-bot

    @mallenexpensify Eep! 4 days overdue now. Issues have feelings too...

  13. mallenexpensify commented on May 26, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @ChavdaSachin due $250 via NewDot

    ^ Test case created. Thx

  14. quinthar commented on May 30, 2026

    @quinthar
    Contributor

    Approved $250 to @ChavdaSachin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions