Skip to content

[Due for payment 2026-04-23] Web - Reports - Complete button in Reports > Task is truncated #87591

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.58-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86283
Email or phone of affected tester (no customers): jsdjosidjiojisojio3@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Search

Action Performed:

Precondition:

  • Have at least one incomplete task.
  1. Go to staging.new.expensify.com
  2. Go to Reports > Expenses.
  3. Click Type, select Task and click Apply.

Expected Result:

Complete button will not be truncated.

Actual Result:

Complete button is truncated.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 10, 2026
  2. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #86283

  3. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 10, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 10, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #86283 - "Add compact UI styles for search reports and expenses tables" by @Krishna2323 (High confidence)
    Related Issues: #86202

    Recommendation: REVERT

    PR #86283 reduced the ACTION column width in the search table from 80px to 68px, which is insufficient to display the "Complete" button text without truncation on large screen widths (Mac/Windows Chrome).

    Assigned: @Krishna2323 (PR author), @JS00001, @luacmartins, @situchan (approving reviewers)
    Labels: DeployBlockerCash kept (frontend App PR caused this); no label changes made.

    Detailed Analysis

    Evidence

    • PR Add compact UI styles for search reports and expenses tables  #86283 was merged on 2026-04-09, one day before this staging-only bug was reported (version 9.3.58-0).
    • The melvin-bot already identified this PR as the likely cause.
    • The PR made extensive changes to the Search list UI, specifically modifying column widths and padding across all search result types including Tasks.

    Verification

    • The affected file is src/components/Search/SearchList/ListItem/TaskListItemRow.tsx, which renders the "Complete" button inside a View styled with StyleUtils.getReportTableColumnStyles(CONST.SEARCH.TABLE_COLUMNS.ACTION).
    • PR Add compact UI styles for search reports and expenses tables  #86283 modifies src/styles/utils/index.ts and changes the ACTION column width from w80 (80px) to w68 (68px).
    • Additionally, UserInfoAndActionButtonRow.tsx was modified to use variables.w68 instead of variables.w80 for the action button container width on large screens.

    Root Cause

    The ACTION column was narrowed from 80px to 68px as part of a compact UI redesign for the search table. The "Complete" button text does not fit within a 68px-wide container on large screen widths, causing it to be visually truncated. The bug only manifests on large screens (Mac/Windows Chrome) because the small-screen path retains variables.w72.

  6. MelvinBot commented on Apr 10, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The ACTION column in the search table is set to 68px wide (variables.w68) in src/styles/utils/index.ts:1919-1921. The "Complete" button in TaskListItemRow.tsx:104-114 is rendered with styles.w100 (width: 100%), forcing it to fill that 68px container. With 12px horizontal padding on each side (24px total from the buttonSmall style), only 44px remains for the "Complete" text — not enough, so numberOfLines={1} on the Button's Text component truncates it with an ellipsis.

    What changes do you think we should make in order to solve the problem?

    Remove styles.w100 from the Button in the ActionCell component in TaskListItemRow.tsx. Without the forced 100% width, the button will size naturally to fit its content text. The parent View already has alignItemsCenter from the column style, so the button will remain centered.

    What alternative solutions did you explore?

    1. Increase the ACTION column width from w68 to w80 in getReportTableColumnStyles — this would fix tasks but also widen the action column for all search table types (expenses, reports), potentially causing unintended layout shifts elsewhere.
    2. Override the column width specifically in TaskListItemRow — more targeted than option 1, but still introduces a special case. Removing w100 is simpler and lets the button be only as wide as it needs to be.

    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. shawnborton commented on Apr 10, 2026

    @shawnborton
    Contributor

    @Krishna2323 maybe we need to beef up the button size for only this view.

  8. 2 remaining items

  9. Krishna2323 commented on Apr 10, 2026

    @Krishna2323
    Contributor

    @shawnborton @situchan PR is ready for review: #87619

  10. melvin-bot commented on Apr 10, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 10, 2026
  12. JS00001 commented on Apr 10, 2026

    @JS00001
    Contributor

    PR merged to fix this. This is a minor UI issue, demoting

  13. luacmartins commented on Apr 10, 2026

    @luacmartins
    Contributor

    Thank you!

  14. JS00001 commented on Apr 14, 2026

    @JS00001
    Contributor

    closing this issue since its part of #86202

  15. changed the title [-]Web - Reports - Complete button in Reports > Task is truncated[/-] [+][Due for payment 2026-04-23] Web - Reports - Complete button in Reports > Task is truncated[/+] on Apr 16, 2026
  16. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.59-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-23. 🎊

    For reference, here are some details about the assignees on this issue:

    • @Krishna2323 requires payment through NewDot Manual Requests
    • @situchan requires payment through NewDot Manual Requests
  18. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    @Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions