You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Tax fields are shown in IOU expense after submitting it from self DM #87616
Version Number: 9.3.58-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84769 Email or phone of affected tester (no customers):sjdiosjondoidosd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable Taxes in workspace settings.
Go to staging.new.expensify.com
Go to self DM.
Create a manual expense with tax.
Click Submit it to someone.
Select a user (not workspace).
→ Tax fields are not shown on confirm page.
Click Create expense.
Open the IOU expense.
→ Tax fields are shown on confirm page.
Expected Result:
Tax fields should be hidden in IOU expense.
Actual Result:
Tax fields are shown in IOU expense after submitting it from self DM.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #84769 - "Show an alert and allow to delete tax if tax tracking is disabled in the workspace" by @dominictb (High confidence) Related Issues: #70058, #83157
Recommendation: REVERT
PR #84769 introduced a logic regression in shouldShowTax that makes tax fields visible on IOU expenses (person-to-person) when they should be hidden. Reverting this PR is the cleanest path to restore correct behavior.
Assigned: @dominictb (PR author), @hoangzinh, @youssef-lr, @trjExpensify (approving reviewers) Labels: No label changes — DeployBlockerCash is correctly set; this is a Frontend bug caused by an App PR.
Detailed Analysis
Evidence
The issue is staging-only (not reproducible in production), confirmed to be caused by a change in the current staging release (9.3.58-0). The melvin-bot and the StagingDeployCash checklist both confirm PR #84769 is part of this release (merged 2026-04-09).
The bug reproduces specifically when:
A manual expense with tax is created in a self DM (or from a workspace with taxes enabled)
It is submitted to a person (not a workspace) via "Submit it to someone"
After creating the IOU expense, tax fields appear on the expense view -- they should not
Verification
The affected file is src/components/ReportActionItem/MoneyRequestView.tsx, which PR #84769 directly modifies (47 additions, 2 deletions to this file).
For an IOU expense (submitted to a person, not a workspace):
isPolicyExpenseChat = false (the IOU report is not in a group policy)
isExpenseUnreported = false (it has a valid reportID, not the unreported sentinel ID)
Therefore isTaxEnabled = false
If the transaction carries a taxCode from when it was originally created in a workspace with tax tracking enabled, then shouldShowTaxDisabledAlert evaluates to true, which causes shouldShowTax to be true -- incorrectly displaying tax fields in the IOU expense view.
The PR was intended to show a "Tax disabled" alert for expenses moved into non-tax workspaces, but the shouldShowTaxDisabledAlert condition (!isTaxEnabled && !!transaction?.taxCode) does not distinguish between "expense in a non-tax workspace" and "IOU expense with a person", making it fire in the wrong context.
The intent was to show tax fields (with an "invalid" violation) when a taxed transaction is merged/moved into a non-tax workspace. However, the fallback conditions (!!transaction?.taxName and shouldShowTaxDisabledAlert = !isTaxEnabled && !!transaction?.taxCode) are not gated to workspace expenses. They fire for any transaction that carries tax data — including personal IOUs between users.
When a user creates a taxed expense in self DM and submits it to another user (not a workspace), the transaction retains its taxName and taxCode from the original context. Since the IOU has no workspace, isTaxEnabled is correctly false, but the fallbacks make shouldShowTax evaluate to true.
Note: the confirmation page (MoneyRequestConfirmationList.tsx:343) correctly uses only isTaxTrackingEnabled(...) without fallbacks, which is why tax fields are hidden on the confirm step but appear after the expense is created.
What changes do you think we should make in order to solve the problem?
Gate the fallback conditions in MoneyRequestView.tsx so they only apply to workspace expenses (where the merge/move scenario is relevant):
Personal IOUs between users never show tax fields when the policy doesn't have tax enabled
What alternative solutions did you explore? (Optional)
An alternative would be to clear taxName/taxCode from the transaction when submitting to a non-workspace user, but that changes the data layer and could cause issues if the expense is later moved to a tax-enabled workspace. The UI-level guard is simpler and consistent with how the confirmation page already handles this.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
@dominictb I think the tax should be cleared from the transaction when you take this action, as shown in the confirmation step here without tax included:
As this is P2P/IOU which nobody is using really apart from some internal folks, I think you can demote this as well.
@hoangzinh@youssef-lr@trjExpensify@dominictb this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
melvin-bot commentedon Apr 10, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #84769
melvin-bot commentedon Apr 10, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 10, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 10, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #84769 - "Show an alert and allow to delete tax if tax tracking is disabled in the workspace" by @dominictb (High confidence)
Related Issues: #70058, #83157
Recommendation: REVERT
PR #84769 introduced a logic regression in
shouldShowTaxthat makes tax fields visible on IOU expenses (person-to-person) when they should be hidden. Reverting this PR is the cleanest path to restore correct behavior.Assigned: @dominictb (PR author), @hoangzinh, @youssef-lr, @trjExpensify (approving reviewers)
Labels: No label changes —
DeployBlockerCashis correctly set; this is a Frontend bug caused by an App PR.Detailed Analysis
Evidence
The issue is staging-only (not reproducible in production), confirmed to be caused by a change in the current staging release (
9.3.58-0). The melvin-bot and the StagingDeployCash checklist both confirm PR #84769 is part of this release (merged 2026-04-09).The bug reproduces specifically when:
Verification
The affected file is
src/components/ReportActionItem/MoneyRequestView.tsx, which PR #84769 directly modifies (47 additions, 2 deletions to this file).Root Cause
Before PR #84769, the tax visibility logic was:
After PR #84769, the logic became:
For an IOU expense (submitted to a person, not a workspace):
isPolicyExpenseChat=false(the IOU report is not in a group policy)isExpenseUnreported=false(it has a valid reportID, not the unreported sentinel ID)isTaxEnabled=falseIf the transaction carries a
taxCodefrom when it was originally created in a workspace with tax tracking enabled, thenshouldShowTaxDisabledAlertevaluates totrue, which causesshouldShowTaxto betrue-- incorrectly displaying tax fields in the IOU expense view.The PR was intended to show a "Tax disabled" alert for expenses moved into non-tax workspaces, but the
shouldShowTaxDisabledAlertcondition (!isTaxEnabled && !!transaction?.taxCode) does not distinguish between "expense in a non-tax workspace" and "IOU expense with a person", making it fire in the wrong context.MelvinBot commentedon Apr 10, 2026
Proposal
What is the root cause of that problem?
PR #84769 modified the
shouldShowTaxlogic inMoneyRequestView.tsx:454-456to:The intent was to show tax fields (with an "invalid" violation) when a taxed transaction is merged/moved into a non-tax workspace. However, the fallback conditions (
!!transaction?.taxNameandshouldShowTaxDisabledAlert = !isTaxEnabled && !!transaction?.taxCode) are not gated to workspace expenses. They fire for any transaction that carries tax data — including personal IOUs between users.When a user creates a taxed expense in self DM and submits it to another user (not a workspace), the transaction retains its
taxNameandtaxCodefrom the original context. Since the IOU has no workspace,isTaxEnabledis correctlyfalse, but the fallbacks makeshouldShowTaxevaluate totrue.Note: the confirmation page (
MoneyRequestConfirmationList.tsx:343) correctly uses onlyisTaxTrackingEnabled(...)without fallbacks, which is why tax fields are hidden on the confirm step but appear after the expense is created.What changes do you think we should make in order to solve the problem?
Gate the fallback conditions in
MoneyRequestView.tsxso they only apply to workspace expenses (where the merge/move scenario is relevant):This ensures:
What alternative solutions did you explore? (Optional)
An alternative would be to clear
taxName/taxCodefrom the transaction when submitting to a non-workspace user, but that changes the data layer and could cause issues if the expense is later moved to a tax-enabled workspace. The UI-level guard is simpler and consistent with how the confirmation page already handles this.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.trjExpensify commentedon Apr 10, 2026
@dominictb I think the tax should be cleared from the transaction when you take this action, as shown in the confirmation step here without tax included:
As this is P2P/IOU which nobody is using really apart from some internal folks, I think you can demote this as well.
11 remaining items
trjExpensify commentedon Apr 20, 2026
@dominictb @youssef-lr what's the latest here?
melvin-bot commentedon Apr 20, 2026
@dominictb Huh... This is 4 days overdue. Who can take care of this?
dominictb commentedon Apr 21, 2026
Backend PR ☝️
melvin-bot commentedon Apr 24, 2026
@hoangzinh @youssef-lr @trjExpensify @dominictb this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Apr 24, 2026
@dominictb Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
dominictb commentedon Apr 27, 2026
@youssef-lr is reviewing the PR
dominictb commentedon Apr 28, 2026
PR is merged. Awaiting deploy
dominictb commentedon Apr 29, 2026
PR reaches prod. Closed as fixed.
Screen.Recording.2026-04-29.at.18.00.34.mov