Skip to content

[Due for payment 2026-04-23] Add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST #87633

New issue
New issue
Closed
Closed
[Due for payment 2026-04-23] Add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST#87633
Assignees
mallenexpensifyJS00001BartekObudzinskiZhenjaHorbach
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Description

@JS00001
JS00001
opened on Apr 10, 2026

AccountManagerBanner was subscribing to the entire PERSONAL_DETAILS_LIST Onyx key and then extracting a single account manager's personal details using getPersonalDetailsForAccountIDs. This caused the component to re-render whenever any user's personal details changed, even though it only needs the account manager's data.

This change replaces that full subscription with a targeted useOnyx selector that extracts only the account manager's personal details by account ID. The getPersonalDetailsForAccountIDs helper and its import are no longer needed and have been removed.

PR: #87558

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. JS00001
    assigned
    JS00001
    and
    BartekObudzinski
    on Apr 10, 2026
  2. JS00001
    added this to [#whatsnext] #qualityon Apr 10, 2026
  3. JS00001
    added a parent issue on Apr 10, 2026
  4. JS00001
    added
    DailyKSv2
    on Apr 10, 2026
  5. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    DailyKSv2
    on Apr 10, 2026

  6. ZhenjaHorbach commented on Apr 13, 2026

    @ZhenjaHorbach
    ZhenjaHorbach
    on Apr 13, 2026
    Contributor

    @JS00001
    Can you assign me here, please?
    Since I was a reviewer?

  7. JS00001
    assigned
    ZhenjaHorbach
    on Apr 14, 2026
  8. melvin-bot
    added
    DailyKSv2
    and removed
    ReviewingHas a PR in review
    WeeklyKSv2
    on Apr 16, 2026
  9. melvin-bot
    changed the title [-]Add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST[/-] [+][Due for payment 2026-04-23] Add selector to AccountManagerBanner for PERSONAL_DETAILS_LIST[/+] on Apr 16, 2026

  10. melvin-bot commented on Apr 16, 2026

    @melvin-bot
    melvin-botBot
    on Apr 16, 2026 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Apr 16, 2026

    @melvin-bot
    melvin-botBot
    on Apr 16, 2026 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.59-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-23. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot
    added
    Overdue
    on Apr 16, 2026

  13. melvin-bot commented on Apr 21, 2026

    @melvin-bot
    melvin-botBot
    on Apr 21, 2026 – with Melvin Bot

    @ZhenjaHorbach Huh... This is 4 days overdue. Who can take care of this?

  14. melvin-bot
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Apr 22, 2026
  15. melvin-bot
    assigned
    mallenexpensify
    on Apr 22, 2026

  16. melvin-bot commented on Apr 22, 2026

    @melvin-bot
    melvin-botBot
    on Apr 22, 2026 – with Melvin Bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  17. melvin-bot
    removed
    Overdue
    on Apr 22, 2026

  18. ZhenjaHorbach commented on Apr 22, 2026

    @ZhenjaHorbach
    ZhenjaHorbach
    on Apr 22, 2026
    Contributor

    I think we don't need a checklist here
    It's an optimization issue

  19. melvin-bot commented on Apr 23, 2026

    @melvin-bot
    melvin-botBot
    on Apr 23, 2026 – with Melvin Bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  20. mallenexpensify commented on Apr 23, 2026

    @mallenexpensify
    mallenexpensify
    on Apr 23, 2026
    Contributor

    Payment Summary

    Contributor+: @ZhenjaHorbach due $250 via NewDot

    Unless @JS00001 thinks it should be less. If so, reopen.
    We state $250 if tests are involved, we got one 3 second test!

    Image
  21. mallenexpensify
    closed this as completedon Apr 23, 2026
  22. github-project-automation
    moved this to Done in [#whatsnext] #qualityon Apr 23, 2026

  23. ZhenjaHorbach commented on Apr 24, 2026

    @ZhenjaHorbach
    ZhenjaHorbach
    on Apr 24, 2026
    Contributor

    Payment Summary

    Contributor+: @ZhenjaHorbach due $250 via NewDot

    Unless @JS00001 thinks it should be less. If so, reopen. We state $250 if tests are involved, we got one 3 second test!

    Oh
    Sorry
    Looks like I forgot to attach or record videos 🥲
    But in this case, it took time to get into this flow and check it

  24. garrettmknight commented on Apr 27, 2026

    @garrettmknight
    garrettmknight
    on Apr 27, 2026
    Contributor

    $250 approved for @ZhenjaHorbach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions