[Due for payment 2026-04-28] [Card Rules] - Hide deactivated cards from rule summary and selection lists #87669

Activity

1. luacmartins

   self-assigned this

   on Apr 10, 2026
2. luacmartins

   changed the title [-]Spend rules - Hide deactivated cards from rule summary and selection lists[/-] [+][Card Rules] - Hide deactivated cards from rule summary and selection lists[/+] on Apr 10, 2026
3. luacmartins

   added

   DailyKSv2KSv2

   on Apr 10, 2026
4. luacmartins commented on Apr 10, 2026

   

   luacmartins

   on Apr 10, 2026

   ContributorAuthor

   More actions

   @MelvinBot work on a proposal for this
5. MelvinBot commented on Apr 10, 2026

   

   MelvinBot

   on Apr 10, 2026

   Contributor

   More actions

   Proposal

   What is the root cause of that problem?

   The rule summary in SpendRulesSection.tsx and the card menu in SpendRulePageBase.tsx build card display text by iterating over formValues.cardIDs from the rule's filter AST. Although cardsList is fetched with the filterInactiveCards selector (which excludes deactivated/closed cards), when a card ID is missing from cardsList, the code falls back to displaying the raw numeric card ID instead of hiding the entry.

   Specifically in SpendRulesSection.tsx:127-139:

   const card = cardsList?.[cardID];
   if (!card || !isCard(card)) {
       return cardID;  // ← shows raw ID for deactivated cards
   }
   

   The same pattern exists in SpendRulePageBase.tsx:109-122.

   The card selection list (SpendRuleCardPage.tsx) is already correct — it uses the filterInactiveCards selector and only shows active cards.

   What changes do you think we should make in order to solve the problem?

   Filter out deactivated card IDs (those not present in the active cardsList) before building the display summaries:

   1. SpendRulesSection.tsx — In the createdRules mapping (~line 127), filter formValues.cardIDs to only include IDs present in cardsList before passing them to getTruncatedSpendRuleSummary. Also filter formValues.cardIDs the same way before passing to getSelectedCardsSharedCurrency. If a rule ends up with zero active cards after filtering, skip rendering it (return undefined so it's filtered out).

   2. SpendRulePageBase.tsx — In getCardsMenuTitle (~line 109), apply the same filter: skip card IDs not found in cardsList rather than falling back to displaying the raw ID.

   This approach keeps the rules data intact on the backend (no data loss) while simply hiding deactivated cards from the UI, consistent with how the card selection list already works.

   What alternative solutions did you explore? (Optional)

   • Backend cleanup on card deactivation — Removing card IDs from rules when a card is deactivated. This is being tracked separately in Spend rules - Card number appears in Spend rule after deactivating card #87450 and would be complementary, but a frontend filter is still needed as a defensive measure.
   • Showing a "deactivated" indicator instead of hiding — This adds UI complexity without clear user benefit, since deactivated cards can't be used.

   ---

   Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
6. luacmartins commented on Apr 10, 2026

   

   luacmartins

   on Apr 10, 2026

   ContributorAuthor

   More actions

   @MelvinBot implement this
7. MelvinBot commented on Apr 10, 2026

   

   MelvinBot

   on Apr 10, 2026

   Contributor

   More actions

   🤖 Draft PR created: #87679
   Please mark it as "Ready for review" when it is ready for review.
8. melvin-bot

   added

   Overdue

   on Apr 13, 2026
9. luacmartins

   assigned

   suneox

   on Apr 13, 2026
10. melvin-bot

    added

    ReviewingHas a PR in reviewHas a PR in review

    WeeklyKSv2KSv2

    and removed

    Overdue

    DailyKSv2KSv2

    on Apr 13, 2026
11. luacmartins

    closed this as completedon Apr 20, 2026
12. melvin-bot

    added

    DailyKSv2KSv2

    and removed

    ReviewingHas a PR in reviewHas a PR in review

    WeeklyKSv2KSv2

    on Apr 21, 2026
13. melvin-bot

    changed the title [-][Card Rules] - Hide deactivated cards from rule summary and selection lists[/-] [+][Due for payment 2026-04-28] [Card Rules] - Hide deactivated cards from rule summary and selection lists[/+] on Apr 21, 2026
14. melvin-bot commented on Apr 21, 2026

    

    melvin-botBot

    on Apr 21, 2026 – with Melvin Bot

    More actions

    Reviewing label has been removed, please complete the "BugZero Checklist".
15. melvin-bot commented on Apr 21, 2026

    

    melvin-botBot

    on Apr 21, 2026 – with Melvin Bot

    More actions

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.60-22 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    • [Card Rules] Hide deactivated cards from rule summary and selection #87679

    If no regressions arise, payment will be issued on 2026-04-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @suneox requires payment through NewDot Manual Requests