Skip to content

Home - Link company cards task is no longer checked off after reset app or relogin #87729

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.58-7
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #86663
Email or phone of affected tester (no customers): famona8013@parsitv.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Other

Action Performed:

Precondition:

  • User has added direct feed in workspace settings > Company cards.
  1. Go to staging.new.expensify.com
  2. Go to Home.
    → Link company cards task is checked off.
  3. Go to Account > Troubleshoot > Clear cache and restart > Reset and refresh OR relogin.
  4. Go to Home.
    → Link company cards task is not checked off.
  5. Click Link company cards task.
  6. Go to Home.
    → Link company cards task is checked off.

Expected Result:

In Step 4, after reset app or relogin, Link company cards task will remain checked off.

Actual Result:

In Step 4, after reset app or relogin, Link company cards task is no longer checked off.
In Step 6, the task is only checked off after opening Company cards page.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7128207_1776011125651.1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @WojtekBoman

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Apr 13, 2026
  2. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    @mountiny recently merged #86663, but they are OOO right now, so I'll auto-assign someone else.

  3. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 13, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. OSBotify commented on Apr 13, 2026

    @OSBotify
    Contributor

    Investigation Summary: Classification: Frontend bug. Causing PR: #86663 by @adamgrzybowski (High confidence). Recommendation: REVERT. The new GettingStartedSection feature (src/pages/home/GettingStartedSection/hooks/useGettingStartedItems.ts) depends on ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER data that is only fetched when the user visits the company cards page (WorkspaceCompanyCardsPage). After a cache clear or relogin, the Onyx store is empty and hasCompanyCardFeeds(allCardFeeds) returns false, causing the Link company cards task to appear unchecked until the user explicitly navigates to the company cards page. This matches exactly the workaround described in step 6. Assigned: @adamgrzybowski (PR author), @ZhenjaHorbach @JmillsExpensify @mountiny (approving reviewers). Label action: keeping DeployBlockerCash, removing DeployBlocker since this is a frontend App bug.

  7. 6 remaining items

  8. MelvinBot commented on Apr 13, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The "Link company cards" checklist item determines its completion state via hasCompanyCardFeeds(allCardFeeds) (useGettingStartedItems.ts:104). The allCardFeeds data comes from the Onyx key SHARED_NVP_PRIVATE_DOMAIN_MEMBER (useCardFeeds.tsx:25).

    This Onyx key is only populated on-demand when the user navigates to the company cards page — specifically via the OPEN_POLICY_COMPANY_CARDS_PAGE API call in WorkspaceCompanyCardsPage.tsx:62. It is not fetched during OpenApp or ReconnectApp at startup.

    After a cache clear or relogin, the Onyx store is empty for this key, so hasCompanyCardFeeds returns false and the item appears unchecked — until the user visits the company cards page and triggers the fetch.

    All other checklist items are unaffected because they read from Policy or PolicyCategories Onyx keys, which are populated at startup by OpenApp.

    What changes do you think we should make in order to fix the problem?

    The useGettingStartedItems hook should trigger a fetch of the card feeds data when it's needed but not yet available in Onyx. Specifically:

    1. In useGettingStartedItems.ts, when the "Link company cards" item is about to be added to the checklist (i.e., the workspace has company cards enabled), call openPolicyCompanyCardsPage (or a lighter-weight equivalent) to ensure the card feeds data is fetched if it's not already present in Onyx.

    2. Alternatively, a simpler approach: add a useEffect in the hook that calls the existing openPolicyCompanyCardsPage action when activePolicyID is set and the card feeds data is not yet loaded. This mirrors what WorkspaceCompanyCardsPage already does, ensuring the data is available without requiring the user to navigate there first.

    What alternative solutions did you explore? (Optional)

    • Include SHARED_NVP_PRIVATE_DOMAIN_MEMBER in the OpenApp/ReconnectApp response: This would fix the issue at the backend level, but it would add data to the startup payload for all users (not just those with the onboarding checklist), which may not be desirable.
    • Cache a boolean flag in a separate Onyx key: When card feeds are first detected, persist a simple hasCardFeeds: true flag that survives cache clears. This avoids re-fetching the full card feeds data but adds complexity.

    The recommended approach (fetching from the hook) is the most targeted fix — it only fetches when the checklist is actually displayed and the data is missing.

    Investigation details

    Evidence chain:

    1. useGettingStartedItems.ts:104 — isComplete: hasCompanyCardFeeds(allCardFeeds) determines checked state
    2. useCardFeeds.tsx:25 — reads ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_DOMAIN_MEMBER from Onyx
    3. WorkspaceCompanyCardsPage.tsx:62,71-77 — only place that calls openPolicyCompanyCardsPage to populate this Onyx key
    4. App.ts — SHARED_NVP_PRIVATE_DOMAIN_MEMBER is absent from OpenApp/ReconnectApp, confirming it's never loaded at startup

    Comparison with other checklist items:

    • "Create a workspace" (line 74): isComplete: true — hardcoded, always checked
    • "Connect to accounting" (line 85): hasAccountingConnections(policy) — reads from POLICY collection, loaded at startup
    • "Customize categories" (line 94): hasCustomCategories(policyCategories) — reads from POLICY_CATEGORIES, loaded at startup
    • "Setup rules" (line 115): hasNonDefaultRules(policy) — reads from POLICY collection, loaded at startup

    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  9. mountiny commented on Apr 13, 2026

    @mountiny
    Contributor
  10. mountiny commented on Apr 13, 2026

    @mountiny
    Contributor

    Seems quite minor and specific flow, we do not have to block on this and we will follow up quickly

  11. JmillsExpensify commented on Apr 13, 2026

    @JmillsExpensify
    Contributor

    Agreed

  12. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    @WojtekBoman Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. mountiny commented on Apr 17, 2026

    @mountiny
    Contributor

    Asking for a retest

  14. IuliiaHerets commented on Apr 17, 2026

    @IuliiaHerets

    @mountiny Not repro anymore on Web/Android/iOS

    company.card.ios.MP4
    1000193036.mp4
    bandicam.2026-04-17.12-33-57-693.mp4
  15. ZhenjaHorbach commented on Apr 17, 2026

    @ZhenjaHorbach
    Contributor

    @JmillsExpensify @grgia
    Let's close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions