You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-04-28] Spend rule is not grayed out when created offline, no strikethrough when deleted offline #87802
Version Number: 9.3.59-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87180 Email or phone of affected tester (no customers):applausetester+khcategory20@applause.expensifail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Workspace is set up with Expensify Card feature.
Rules are enabled.
Go to staging.new.expensify.com
Go to workspace settings > Rules.
Go offline.
Click Add spend rule.
Create a spend rule.
Open the created rule.
Click Delete rule > Delete.
Expected Result:
Spend rule row will be grayed out when created offline, and shows strikethrough when deleted offline.
Actual Result:
Spend rule row is not grayed out when created offline, and does not show strikethrough when deleted offline.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Investigation Summary - Classification: Frontend bug - Causing PR: #87180 Allow spend rule edits/delete by @luacmartins (High confidence) - Recommendation: REVERT - PR #87180 introduced spend rule edit/delete but omitted the pendingAction field in optimistic Onyx data for both setExpensifyCardRule and deleteExpensifyCardRule in Card.ts, so SpendRulesSection.tsx has no signal to render the grayed-out (created offline) or strikethrough (deleted offline) states. The PR author marked offline tests as N/A confirming this was never tested offline. Assigned: @luacmartins@JS00001@suneox
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.
changed the title [-]Spend rule is not grayed out when created offline, no strikethrough when deleted offline[/-][+][Due for payment 2026-04-28] Spend rule is not grayed out when created offline, no strikethrough when deleted offline[/+]on Apr 21, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.60-22 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 13, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87180
melvin-bot commentedon Apr 13, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 13, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 13, 2026
Investigation Summary - Classification: Frontend bug - Causing PR: #87180 Allow spend rule edits/delete by @luacmartins (High confidence) - Recommendation: REVERT - PR #87180 introduced spend rule edit/delete but omitted the pendingAction field in optimistic Onyx data for both setExpensifyCardRule and deleteExpensifyCardRule in Card.ts, so SpendRulesSection.tsx has no signal to render the grayed-out (created offline) or strikethrough (deleted offline) states. The PR author marked offline tests as N/A confirming this was never tested offline. Assigned: @luacmartins @JS00001 @suneox
7 remaining items
MelvinBot commentedon Apr 13, 2026
🤖 Draft PR created: #87822
Please mark it as "Ready for review" when it is ready for review.
MelvinBot commentedon Apr 13, 2026
⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.
Run details
suneox commentedon Apr 14, 2026
I'll take a look at this one in a few hours
[-]Spend rule is not grayed out when created offline, no strikethrough when deleted offline[/-][+][Due for payment 2026-04-28] Spend rule is not grayed out when created offline, no strikethrough when deleted offline[/+]melvin-bot commentedon Apr 21, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 21, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.60-22 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-04-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 21, 2026
@suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]