Skip to content

[Due for payment 2026-04-28] Spend rule is not grayed out when created offline, no strikethrough when deleted offline #87802

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.59-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87180
Email or phone of affected tester (no customers): applausetester+khcategory20@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Workspace is set up with Expensify Card feature.
  • Rules are enabled.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Rules.
  3. Go offline.
  4. Click Add spend rule.
  5. Create a spend rule.
  6. Open the created rule.
  7. Click Delete rule > Delete.

Expected Result:

Spend rule row will be grayed out when created offline, and shows strikethrough when deleted offline.

Actual Result:

Spend rule row is not grayed out when created offline, and does not show strikethrough when deleted offline.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Bug7129091_1776113408274.2.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @suneox

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Apr 13, 2026
  2. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #87180

  3. melvin-bot commented on Apr 13, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 13, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 13, 2026

    @OSBotify
    Contributor

    Investigation Summary - Classification: Frontend bug - Causing PR: #87180 Allow spend rule edits/delete by @luacmartins (High confidence) - Recommendation: REVERT - PR #87180 introduced spend rule edit/delete but omitted the pendingAction field in optimistic Onyx data for both setExpensifyCardRule and deleteExpensifyCardRule in Card.ts, so SpendRulesSection.tsx has no signal to render the grayed-out (created offline) or strikethrough (deleted offline) states. The PR author marked offline tests as N/A confirming this was never tested offline. Assigned: @luacmartins @JS00001 @suneox

  6. 7 remaining items

  7. MelvinBot commented on Apr 13, 2026

    @MelvinBot
    Contributor

    🤖 Draft PR created: #87822
    Please mark it as "Ready for review" when it is ready for review.

  8. MelvinBot commented on Apr 13, 2026

    @MelvinBot
    Contributor

    ⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

    Run details

  9. suneox commented on Apr 14, 2026

    @suneox
    Contributor

    I'll take a look at this one in a few hours

  10. changed the title [-]Spend rule is not grayed out when created offline, no strikethrough when deleted offline[/-] [+][Due for payment 2026-04-28] Spend rule is not grayed out when created offline, no strikethrough when deleted offline[/+] on Apr 21, 2026
  11. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.60-22 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-04-28. 🎊

    For reference, here are some details about the assignees on this issue:

    • @suneox requires payment through NewDot Manual Requests
  13. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    @suneox The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions