Skip to content

[$250] Onboarding - No set up tags task when create a new account selecting the Track and Budget #87851

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.3.59-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41237675
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11 / Chrome
App Component: Other

Action Performed:

  1. Sign up with a new account
  2. Select Track and budget expenses
  3. Fill in with any name and continue
  4. Go to Inbox and select Concierge

Expected Result:

Verify you see tasks for an admin in the Concierge: Create a workspace (should be auto-completed), Take a test drive, Set up categories, Set up tags, Add expense approvals, Invite your accountant

Actual Result:

No set up tags task when create a new account selecting the Track and Budget

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @huult
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~022043981509016837499
  • Upwork Job ID: 2043981509016837499
  • Last Price Increase: 2026-04-14

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 14, 2026
  2. MelvinBot commented on Apr 14, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The onboardingTrackWorkspaceMessage task list in OnboardingFlow.ts:352 was never updated to include setupTagsTask or addExpenseApprovalsTask. When a user selects "Track and budget expenses" (PERSONAL_SPEND → remapped to TRACK_WORKSPACE), the tasks array only contains: createWorkspaceTask, testDriveAdminTask, createReportTask, setupCategoriesTask, inviteAccountantTask, reviewWorkspaceSettingsTask.

    Both setupTagsTask (line 273) and addExpenseApprovalsTask (line 178) are defined and used in the MANAGE_TEAM flow but were simply never added to the TRACK_WORKSPACE flow.

    What changes do you think we should make in order to solve the problem?

    Update the tasks array in onboardingTrackWorkspaceMessage to include the missing tasks and match the expected order from the issue:

    In src/libs/actions/Welcome/OnboardingFlow.ts, change the tasks array to:
    [createWorkspaceTask, testDriveAdminTask, setupCategoriesTask, setupTagsTask, addExpenseApprovalsTask, inviteAccountantTask]

    This adds setupTagsTask and addExpenseApprovalsTask, and removes createReportTask and reviewWorkspaceSettingsTask which aren't in the expected task list per the issue requirements.

    What alternative solutions did you explore? (Optional)

    Simply appending the two missing tasks to the existing array was considered, but the expected task list in the issue description doesn't include createReportTask or reviewWorkspaceSettingsTask, so reordering to match the spec is more appropriate.

    Investigation details

    Data flow:

    1. User selects "Track and budget expenses" → maps to CONST.ONBOARDING_CHOICES.PERSONAL_SPEND
    2. App.ts:722 remaps PERSONAL_SPEND → TRACK_WORKSPACE during workspace creation
    3. completeOnboarding() fetches onboardingMessages[TRACK_WORKSPACE] → onboardingTrackWorkspaceMessage
    4. The task array lacks setupTagsTask and addExpenseApprovalsTask

    Comparison: The onboardingManageTeamMessage (line 339) correctly includes both tasks.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 14, 2026
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 14, 2026
  5. melvin-bot commented on Apr 14, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @huult (External)

  6. changed the title [-]Onboarding - No set up tags task when create a new account selecting the Track and Budget[/-] [+][$250] Onboarding - No set up tags task when create a new account selecting the Track and Budget[/+] on Apr 14, 2026
  7. melvin-bot commented on Apr 14, 2026

    @melvin-bot
  8. twilight2294 commented on Apr 14, 2026

    @twilight2294
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When a user creates a new account and selects "Track and budget expenses," the onboarding task list is missing the "Set up tags" and "Add expense approvals" tasks.

    What is the root cause of that problem?

    The onboardingTrackWorkspaceMessage tasks array in OnboardingFlow never included setupTagsTask or addExpenseApprovalsTask. Both tasks are defined (setupTagsTask at L273, addExpenseApprovalsTask at L178) and used in the MANAGE_TEAM flow but were simply omitted from the TRACK_WORKSPACE flow.

    What changes do you think we should make in order to solve the problem?

    In OnboardingFlow, add the two missing tasks to the existing array:

    - tasks: [createWorkspaceTask, testDriveAdminTask, createReportTask, setupCategoriesTask, inviteAccountantTask, reviewWorkspaceSettingsTask],
    + tasks: [createWorkspaceTask, testDriveAdminTask, createReportTask, setupCategoriesTask, setupTagsTask, addExpenseApprovalsTask, inviteAccountantTask, reviewWorkspaceSettingsTask],

    What alternative solutions did you explore? (Optional)

    MelvinBot's proposal adds the same two tasks but also removes createReportTask and reviewWorkspaceSettingsTask, inferring their absence from the issue's expected task list. The issue title and description only report missing tasks — removing existing tasks that were intentionally placed in this flow risks a regression. A safer fix is to only add what's missing without removing what already works.

  9. trasnake87 commented on Apr 14, 2026

    @trasnake87
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When a new user signs up and picks "Track and budget expenses", the Concierge task list is missing the "Set up tags" (and "Add expense approvals") admin setup tasks that are expected for an auto-created workspace owner.

    What is the root cause of that problem?

    The TRACK_WORKSPACE flow is dispatched from src/hooks/useAutoCreateTrackWorkspace.ts#L97-L98, which passes onboardingMessages[TRACK_WORKSPACE] straight into completeOnboarding. Because a workspace is being auto-created and the user becomes its admin, the hook should be surfacing the same admin-setup tasks defined for MANAGE_TEAM (which already includes SETUP_TAGS and ADD_EXPENSE_APPROVALS task entries), but instead it forwards the track-specific tasks as-is. The fix therefore belongs at the caller that selects the task list for this specific "auto-created admin workspace" scenario, not at the generic task config.

    What changes do you think we should make in order to solve the problem?

    In src/hooks/useAutoCreateTrackWorkspace.ts, merge the missing admin tasks from the MANAGE_TEAM onboarding message into the TRACK_WORKSPACE message before calling completeOnboarding:

    const trackMsg = onboardingMessages[CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE];
    const teamTasks = onboardingMessages[CONST.ONBOARDING_CHOICES.MANAGE_TEAM].tasks;
    const missingTypes = [CONST.ONBOARDING_TASK_TYPE.SETUP_TAGS, CONST.ONBOARDING_TASK_TYPE.ADD_EXPENSE_APPROVALS];
    const extraTasks = teamTasks.filter((t) => missingTypes.includes(t.type) && !trackMsg.tasks.some((x) => x.type === t.type));
    const mergedMessage = {...trackMsg, tasks: [...trackMsg.tasks, ...extraTasks]};
    
    completeOnboarding({
        engagementChoice: CONST.ONBOARDING_CHOICES.TRACK_WORKSPACE,
        onboardingMessage: mergedMessage,
        ...
    });

    This keeps the TRACK_WORKSPACE welcome copy intact while restoring the admin tasks expected for an auto-created workspace owner, localized to the single call site that actually provisions the admin workspace.

  10. trasnake87 commented on Apr 14, 2026

    @trasnake87
    Contributor

    Contributor details
    Your Expensify account email: trasnake87@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~010f770315ab181656

  11. melvin-bot commented on Apr 14, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  12. JasimMalook commented on Apr 14, 2026

    @JasimMalook

    🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

  13. 2 remaining items

  14. JasimMalook commented on Apr 14, 2026

    @JasimMalook

    Contributor details
    Your Expensify account email:jasimmalook@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~014c25762fc2275193

  15. melvin-bot commented on Apr 14, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  16. avasis-ai commented on Apr 14, 2026

    @avasis-ai

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When creating a new account and selecting "Track and Budget expenses" onboarding flow, the "Set up tags" task does not appear in the task list.

    What is the root cause of that problem?

    In src/libs/actions/Welcome/OnboardingFlow.ts, the onboardingTrackWorkspaceMessage (line 352) defines the tasks for the Track workspace flow but is missing setupTagsTask and addExpenseApprovalsTask from its tasks array:

    // Line 352 - current (missing tasks):
    tasks: [createWorkspaceTask, testDriveAdminTask, createReportTask, setupCategoriesTask, inviteAccountantTask, reviewWorkspaceSettingsTask]

    By comparison, the onboardingManageTeamMessage (line 338-339) correctly includes both:

    setupTagsTask,
    addExpenseApprovalsTask,

    Both task objects (setupTagsTask at lines 273-278 and addExpenseApprovalsTask) are already defined and used in the Manage Team flow. The downstream code in ReportUtils.ts already handles both task types (ONBOARDING_TASK_TYPE.SETUP_TAGS at line 11870, ONBOARDING_TASK_TYPE.ADD_EXPENSE_APPROVALS at line 11942).

    What changes do you think we should make?

    Add setupTagsTask and addExpenseApprovalsTask to the tasks array in onboardingTrackWorkspaceMessage at line 352 of OnboardingFlow.ts.

    Change is in one file, one line (array contents):

    // Before:
    tasks: [createWorkspaceTask, testDriveAdminTask, createReportTask, setupCategoriesTask, inviteAccountantTask, reviewWorkspaceSettingsTask]
    
    // After:
    tasks: [createWorkspaceTask, testDriveAdminTask, createReportTask, setupCategoriesTask, setupTagsTask, addExpenseApprovalsTask, inviteAccountantTask, reviewWorkspaceSettingsTask]

    No other changes needed — the task definitions, handlers, onboarding checkpoint tracking, and ReportUtils filtering all already support these task types.

    What alternative solutions did you explore?

    None — this is a straightforward omission in the task array. The task infrastructure is complete; only the array membership is wrong.

  17. huult commented on Apr 17, 2026

    @huult
    Contributor

    @jponikarchuk I think this is expected behavior and not a bug. This was updated in #85226 (commit).

    cc @dylanexpensify @jayeshmangwani What are your thoughts?

  18. jayeshmangwani commented on Apr 17, 2026

    @jayeshmangwani
    Contributor

    Yes, this is expected behavior. Only three tasks will be shown to track-intent users .

    • Take a test drive
    • Create your first report
    • Set up categories
  19. huult commented on Apr 19, 2026

    @huult
    Contributor

    Thanks, we can close this issue.

  20. huult commented on Apr 21, 2026

    @huult
    Contributor

    @MelvinBot This is expected behavior, so we can close this ticket

  21. MelvinBot commented on Apr 21, 2026

    @MelvinBot
    Contributor

    Closing as expected behavior per confirmation from jayeshmangwani and huult. The track-intent onboarding flow intentionally shows only three tasks (Take a test drive, Create your first report, Set up categories) as updated in #85226.

  22. huult commented on Apr 21, 2026

    @huult
    Contributor

    @MelvinBot Please close this ticket as expected behavior.

  23. removed
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 21, 2026
  24. huult commented on Apr 21, 2026

    @huult
    Contributor

    @MelvinBot Please close this as completed.

  25. MelvinBot commented on Apr 21, 2026

    @MelvinBot
    Contributor

    I attempted to close this issue as requested, but I don't have permission to close issues. Please close it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions