You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Onboarding - No set up tags task when create a new account selecting the Track and Budget #87851
Version Number: v9.3.59-3 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/projects/2219752/folder/13176677/test-cases/41237675 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: Windows 11 / Chrome App Component: Other
Action Performed:
Sign up with a new account
Select Track and budget expenses
Fill in with any name and continue
Go to Inbox and select Concierge
Expected Result:
Verify you see tasks for an admin in the Concierge: Create a workspace (should be auto-completed), Take a test drive, Set up categories, Set up tags, Add expense approvals, Invite your accountant
Actual Result:
No set up tags task when create a new account selecting the Track and Budget
The onboardingTrackWorkspaceMessage task list in OnboardingFlow.ts:352 was never updated to include setupTagsTask or addExpenseApprovalsTask. When a user selects "Track and budget expenses" (PERSONAL_SPEND → remapped to TRACK_WORKSPACE), the tasks array only contains: createWorkspaceTask, testDriveAdminTask, createReportTask, setupCategoriesTask, inviteAccountantTask, reviewWorkspaceSettingsTask.
Both setupTagsTask (line 273) and addExpenseApprovalsTask (line 178) are defined and used in the MANAGE_TEAM flow but were simply never added to the TRACK_WORKSPACE flow.
What changes do you think we should make in order to solve the problem?
Update the tasks array in onboardingTrackWorkspaceMessage to include the missing tasks and match the expected order from the issue:
In src/libs/actions/Welcome/OnboardingFlow.ts, change the tasks array to: [createWorkspaceTask, testDriveAdminTask, setupCategoriesTask, setupTagsTask, addExpenseApprovalsTask, inviteAccountantTask]
This adds setupTagsTask and addExpenseApprovalsTask, and removes createReportTask and reviewWorkspaceSettingsTask which aren't in the expected task list per the issue requirements.
What alternative solutions did you explore? (Optional)
Simply appending the two missing tasks to the existing array was considered, but the expected task list in the issue description doesn't include createReportTask or reviewWorkspaceSettingsTask, so reordering to match the spec is more appropriate.
Investigation details
Data flow:
User selects "Track and budget expenses" → maps to CONST.ONBOARDING_CHOICES.PERSONAL_SPEND
App.ts:722 remaps PERSONAL_SPEND → TRACK_WORKSPACE during workspace creation
The task array lacks setupTagsTask and addExpenseApprovalsTask
Comparison: The onboardingManageTeamMessage (line 339) correctly includes both tasks.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
changed the title [-]Onboarding - No set up tags task when create a new account selecting the Track and Budget[/-][+][$250] Onboarding - No set up tags task when create a new account selecting the Track and Budget[/+]on Apr 14, 2026
Please re-state the problem that we are trying to solve in this issue.
When a user creates a new account and selects "Track and budget expenses," the onboarding task list is missing the "Set up tags" and "Add expense approvals" tasks.
What is the root cause of that problem?
The onboardingTrackWorkspaceMessage tasks array in OnboardingFlow never included setupTagsTask or addExpenseApprovalsTask. Both tasks are defined (setupTagsTask at L273, addExpenseApprovalsTask at L178) and used in the MANAGE_TEAM flow but were simply omitted from the TRACK_WORKSPACE flow.
What changes do you think we should make in order to solve the problem?
In OnboardingFlow, add the two missing tasks to the existing array:
What alternative solutions did you explore? (Optional)
MelvinBot's proposal adds the same two tasks but also removes createReportTask and reviewWorkspaceSettingsTask, inferring their absence from the issue's expected task list. The issue title and description only report missing tasks — removing existing tasks that were intentionally placed in this flow risks a regression. A safer fix is to only add what's missing without removing what already works.
Please re-state the problem that we are trying to solve in this issue.
When a new user signs up and picks "Track and budget expenses", the Concierge task list is missing the "Set up tags" (and "Add expense approvals") admin setup tasks that are expected for an auto-created workspace owner.
What is the root cause of that problem?
The TRACK_WORKSPACE flow is dispatched from src/hooks/useAutoCreateTrackWorkspace.ts#L97-L98, which passes onboardingMessages[TRACK_WORKSPACE] straight into completeOnboarding. Because a workspace is being auto-created and the user becomes its admin, the hook should be surfacing the same admin-setup tasks defined for MANAGE_TEAM (which already includes SETUP_TAGS and ADD_EXPENSE_APPROVALS task entries), but instead it forwards the track-specific tasks as-is. The fix therefore belongs at the caller that selects the task list for this specific "auto-created admin workspace" scenario, not at the generic task config.
What changes do you think we should make in order to solve the problem?
In src/hooks/useAutoCreateTrackWorkspace.ts, merge the missing admin tasks from the MANAGE_TEAM onboarding message into the TRACK_WORKSPACE message before calling completeOnboarding:
This keeps the TRACK_WORKSPACE welcome copy intact while restoring the admin tasks expected for an auto-created workspace owner, localized to the single call site that actually provisions the admin workspace.
Please re-state the problem that we are trying to solve in this issue.
When creating a new account and selecting "Track and Budget expenses" onboarding flow, the "Set up tags" task does not appear in the task list.
What is the root cause of that problem?
In src/libs/actions/Welcome/OnboardingFlow.ts, the onboardingTrackWorkspaceMessage (line 352) defines the tasks for the Track workspace flow but is missing setupTagsTask and addExpenseApprovalsTask from its tasks array:
// Line 352 - current (missing tasks):
tasks: [createWorkspaceTask,testDriveAdminTask,createReportTask,setupCategoriesTask,inviteAccountantTask,reviewWorkspaceSettingsTask]
By comparison, the onboardingManageTeamMessage (line 338-339) correctly includes both:
setupTagsTask,addExpenseApprovalsTask,
Both task objects (setupTagsTask at lines 273-278 and addExpenseApprovalsTask) are already defined and used in the Manage Team flow. The downstream code in ReportUtils.ts already handles both task types (ONBOARDING_TASK_TYPE.SETUP_TAGS at line 11870, ONBOARDING_TASK_TYPE.ADD_EXPENSE_APPROVALS at line 11942).
What changes do you think we should make?
Add setupTagsTask and addExpenseApprovalsTask to the tasks array in onboardingTrackWorkspaceMessage at line 352 of OnboardingFlow.ts.
No other changes needed — the task definitions, handlers, onboarding checkpoint tracking, and ReportUtils filtering all already support these task types.
What alternative solutions did you explore?
None — this is a straightforward omission in the task array. The task infrastructure is complete; only the array membership is wrong.
Closing as expected behavior per confirmation from jayeshmangwani and huult. The track-intent onboarding flow intentionally shows only three tasks (Take a test drive, Create your first report, Set up categories) as updated in #85226.
Activity
MelvinBot commentedon Apr 14, 2026
Proposal
What is the root cause of that problem?
The
onboardingTrackWorkspaceMessagetask list inOnboardingFlow.ts:352was never updated to includesetupTagsTaskoraddExpenseApprovalsTask. When a user selects "Track and budget expenses" (PERSONAL_SPEND→ remapped toTRACK_WORKSPACE), the tasks array only contains:createWorkspaceTask,testDriveAdminTask,createReportTask,setupCategoriesTask,inviteAccountantTask,reviewWorkspaceSettingsTask.Both
setupTagsTask(line 273) andaddExpenseApprovalsTask(line 178) are defined and used in theMANAGE_TEAMflow but were simply never added to theTRACK_WORKSPACEflow.What changes do you think we should make in order to solve the problem?
Update the
tasksarray inonboardingTrackWorkspaceMessageto include the missing tasks and match the expected order from the issue:In
src/libs/actions/Welcome/OnboardingFlow.ts, change the tasks array to:[createWorkspaceTask, testDriveAdminTask, setupCategoriesTask, setupTagsTask, addExpenseApprovalsTask, inviteAccountantTask]This adds
setupTagsTaskandaddExpenseApprovalsTask, and removescreateReportTaskandreviewWorkspaceSettingsTaskwhich aren't in the expected task list per the issue requirements.What alternative solutions did you explore? (Optional)
Simply appending the two missing tasks to the existing array was considered, but the expected task list in the issue description doesn't include
createReportTaskorreviewWorkspaceSettingsTask, so reordering to match the spec is more appropriate.Investigation details
Data flow:
CONST.ONBOARDING_CHOICES.PERSONAL_SPENDApp.ts:722remapsPERSONAL_SPEND→TRACK_WORKSPACEduring workspace creationcompleteOnboarding()fetchesonboardingMessages[TRACK_WORKSPACE]→onboardingTrackWorkspaceMessagesetupTagsTaskandaddExpenseApprovalsTaskComparison: The
onboardingManageTeamMessage(line 339) correctly includes both tasks.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.melvin-bot commentedon Apr 14, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @huult (
External)[-]Onboarding - No set up tags task when create a new account selecting the Track and Budget[/-][+][$250] Onboarding - No set up tags task when create a new account selecting the Track and Budget[/+]melvin-bot commentedon Apr 14, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022043981509016837499
twilight2294 commentedon Apr 14, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a user creates a new account and selects "Track and budget expenses," the onboarding task list is missing the "Set up tags" and "Add expense approvals" tasks.
What is the root cause of that problem?
The
onboardingTrackWorkspaceMessagetasks array in OnboardingFlow never includedsetupTagsTaskoraddExpenseApprovalsTask. Both tasks are defined (setupTagsTaskat L273,addExpenseApprovalsTaskat L178) and used in theMANAGE_TEAMflow but were simply omitted from theTRACK_WORKSPACEflow.What changes do you think we should make in order to solve the problem?
In OnboardingFlow, add the two missing tasks to the existing array:
What alternative solutions did you explore? (Optional)
MelvinBot's proposal adds the same two tasks but also removes
createReportTaskandreviewWorkspaceSettingsTask, inferring their absence from the issue's expected task list. The issue title and description only report missing tasks — removing existing tasks that were intentionally placed in this flow risks a regression. A safer fix is to only add what's missing without removing what already works.trasnake87 commentedon Apr 14, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a new user signs up and picks "Track and budget expenses", the Concierge task list is missing the "Set up tags" (and "Add expense approvals") admin setup tasks that are expected for an auto-created workspace owner.
What is the root cause of that problem?
The TRACK_WORKSPACE flow is dispatched from
src/hooks/useAutoCreateTrackWorkspace.ts#L97-L98, which passesonboardingMessages[TRACK_WORKSPACE]straight intocompleteOnboarding. Because a workspace is being auto-created and the user becomes its admin, the hook should be surfacing the same admin-setup tasks defined forMANAGE_TEAM(which already includesSETUP_TAGSandADD_EXPENSE_APPROVALStask entries), but instead it forwards the track-specific tasks as-is. The fix therefore belongs at the caller that selects the task list for this specific "auto-created admin workspace" scenario, not at the generic task config.What changes do you think we should make in order to solve the problem?
In
src/hooks/useAutoCreateTrackWorkspace.ts, merge the missing admin tasks from theMANAGE_TEAMonboarding message into the TRACK_WORKSPACE message before callingcompleteOnboarding:This keeps the TRACK_WORKSPACE welcome copy intact while restoring the admin tasks expected for an auto-created workspace owner, localized to the single call site that actually provisions the admin workspace.
trasnake87 commentedon Apr 14, 2026
Contributor details
Your Expensify account email: trasnake87@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010f770315ab181656
melvin-bot commentedon Apr 14, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
JasimMalook commentedon Apr 14, 2026
🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.
2 remaining items
JasimMalook commentedon Apr 14, 2026
Contributor details
Your Expensify account email:jasimmalook@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~014c25762fc2275193
melvin-bot commentedon Apr 14, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
avasis-ai commentedon Apr 14, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When creating a new account and selecting "Track and Budget expenses" onboarding flow, the "Set up tags" task does not appear in the task list.
What is the root cause of that problem?
In
src/libs/actions/Welcome/OnboardingFlow.ts, theonboardingTrackWorkspaceMessage(line 352) defines the tasks for the Track workspace flow but is missingsetupTagsTaskandaddExpenseApprovalsTaskfrom itstasksarray:By comparison, the
onboardingManageTeamMessage(line 338-339) correctly includes both:Both task objects (
setupTagsTaskat lines 273-278 andaddExpenseApprovalsTask) are already defined and used in the Manage Team flow. The downstream code inReportUtils.tsalready handles both task types (ONBOARDING_TASK_TYPE.SETUP_TAGSat line 11870,ONBOARDING_TASK_TYPE.ADD_EXPENSE_APPROVALSat line 11942).What changes do you think we should make?
Add
setupTagsTaskandaddExpenseApprovalsTaskto thetasksarray inonboardingTrackWorkspaceMessageat line 352 ofOnboardingFlow.ts.Change is in one file, one line (array contents):
No other changes needed — the task definitions, handlers, onboarding checkpoint tracking, and ReportUtils filtering all already support these task types.
What alternative solutions did you explore?
None — this is a straightforward omission in the task array. The task infrastructure is complete; only the array membership is wrong.
huult commentedon Apr 17, 2026
@jponikarchuk I think this is expected behavior and not a bug. This was updated in #85226 (commit).
cc @dylanexpensify @jayeshmangwani What are your thoughts?
jayeshmangwani commentedon Apr 17, 2026
Yes, this is expected behavior. Only three tasks will be shown to track-intent users .
huult commentedon Apr 19, 2026
Thanks, we can close this issue.
huult commentedon Apr 21, 2026
@MelvinBot This is expected behavior, so we can close this ticket
MelvinBot commentedon Apr 21, 2026
Closing as expected behavior per confirmation from
jayeshmangwaniandhuult. The track-intent onboarding flow intentionally shows only three tasks (Take a test drive, Create your first report, Set up categories) as updated in #85226.huult commentedon Apr 21, 2026
@MelvinBot Please close this ticket as expected behavior.
huult commentedon Apr 21, 2026
@MelvinBot Please close this as completed.
MelvinBot commentedon Apr 21, 2026
I attempted to close this issue as requested, but I don't have permission to close issues. Please close it manually.