You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-05-23] [$250] Validate password complexity in the front end #8794
Error message is shown and we do not call Authenticate command
Actual Result:
Authenticate command is called and error message is shown
Workaround:
Yes
Platform:
Where is this issue occurring?
Web
iOS
Android
Desktop App
Mobile Web
Version Number: Reproducible in staging?: Yes Reproducible in production?: Yes Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Expensify/Expensify Issue URL: Issue reported by: Slack conversation:
changed the title [-][$250] Validate password complexity in the front end[/-][+][HOLD for payment 2022-05-23] [$250] Validate password complexity in the front end[/+]on May 16, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
📣 @thesahindia You have been assigned to this job by @mallenexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
Activity
melvin-bot commentedon Apr 26, 2022
Triggered auto assignment to @muttmuure (
AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.melvin-bot commentedon May 2, 2022
@muttmuure Eep! 4 days overdue now. Issues have feelings too...
melvin-bot commentedon May 2, 2022
@muttmuure Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon May 2, 2022
Triggered auto assignment to @kevinksullivan (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.tgolen commentedon May 2, 2022
@thesahindia Care to put a quick proposal together for this?
thesahindia commentedon May 3, 2022
Yeah sure.
Proposal
We have a function for this already -
App/src/libs/ValidationUtils.js
Lines 276 to 277 in bd54857
We can just use it inside
validateAndSubmitFormApp/src/pages/signin/PasswordForm.js
Lines 93 to 100 in bd54857
Just a quick question, we wanna show the same error message right?
tgolen commentedon May 3, 2022
Looks good to me! @kevinksullivan Can you spin up something in Upwork for this and hire @thesahindia?
Yeah, I think
passwordForm.error.incorrectLoginOrPasswordis fine to use for now.20 remaining items
[-][$250] Validate password complexity in the front end[/-][+][HOLD for payment 2022-05-23] [$250] Validate password complexity in the front end[/+]melvin-bot commentedon May 16, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-05-23. 🎊
mananjadhav commentedon May 24, 2022
@kevinksullivan Bump for the payment on Upwork. I had applied as a C+, which isn't accepted I guess.
mallenexpensify commentedon May 26, 2022
Hired ya @mananjadhav , let us know when you accept
Paid @thesahindia $250 for the fix,
melvin-bot commentedon May 26, 2022
📣 @thesahindia You have been assigned to this job by @mallenexpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
mananjadhav commentedon May 26, 2022
Accepted @mallenexpensify
mallenexpensify commentedon May 26, 2022
Paid @mananjadhav $250 for C+
Thanks for the help y'all