Skip to content

[Due for payment 2026-05-11] [CFI] Add distinct icon for custom export formats vs default exports #88096

Closed

Description

@trjExpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/622924
Issue reported by: @lschurr
Slack conversation (hyperlinked to channel name): #migrate

Action Performed:

  1. Add an IS template to your account (so you have both default and custom export CSV templates)
  2. Select report1 > Export
  3. Verify the icons in the popover menu are accurate for default and custom templates
  4. Export the report to a custom template
  5. Select a report2 > Export
  6. Export to the report to a default template
  7. Got to "Columns" > Enable "Exported to"
  8. Verify the icon for report1 is the custom icon (spreedsheet + pencil)
  9. Verify the icon for report2 is the default icon (spreadsheet)

Expected Result:

This is an improvement.

Use a different icon for custom CSV templates and default templates to help distiguish between the two:

Image Image

Icon file:
Table Pencil.svg.zip

Actual Result:

All CSV export templates use the same icon.

Workaround:

Go back to Classic where they use different icons.

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

In-line above.

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Apr 16, 2026

    @melvin-bot

    Current assignee @dannymcclain is eligible for the NewFeature assigner, not assigning anyone new.

  2. trjExpensify commented on Apr 16, 2026

    @trjExpensify
    ContributorAuthor

    @samranahm as you worked on #80005 and can test it, can you take this on?

  3. samranahm commented on Apr 16, 2026

    @samranahm
    Contributor

    Sure thing, I'm open to take this on.

  4. trjExpensify commented on Apr 16, 2026

    @trjExpensify
    ContributorAuthor

    Nice one, thanks!

  5. samranahm commented on Apr 16, 2026

    @samranahm
    Contributor

    @trjExpensify Can you share the Icon file again please, seems like the file in OP is corrupted.

  6. dannymcclain commented on Apr 16, 2026

    @dannymcclain
    Contributor

    Try this one:
    Table Pencil.svg.zip

  7. samranahm commented on Apr 16, 2026

    @samranahm
    Contributor

    Thanks a lot.

  8. added
    ReviewingHas a PR in review
    and removed on Apr 16, 2026
  9. 23 remaining items

  10. melvin-bot commented on May 10, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  11. melvin-bot commented on May 11, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  12. aimane-chnaif commented on May 11, 2026

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: new design update

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/635936

    Regression Test Proposal

    Test:

    1. Add custom export templates and include IS export template
    2. Open Reports page > FIlters > "Exported to"
    3. Verify any custom export template has table-pencil icon and standard export templates has simple table icon
    4. Select any template > Save > View Results and press Exported to: Valuebutton next to search input
    5. Verify the icons for Custom and Standard export templates
    6. Press Display > Edit columns > Select "Exported to" > Save
    7. Check icon cell in "Exported to" column and verify Custom export templates and Standard templates have different icon
    8. Open the expense report > Press "More" in report header > Export
    9. Verify the icons based on step 3

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-a670-a59e-e2dc-46742ced6aa4
  13. mallenexpensify commented on May 12, 2026

    @mallenexpensify
    Contributor

    @samranahm @aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022054052451235917872

  14. samranahm commented on May 12, 2026

    @samranahm
    Contributor

    Thanks @mallenexpensify, I've accepted the offer.

  15. mallenexpensify commented on May 12, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor: @samranahm paid $250 via Upwork
    Contributor+: @aimane-chnaif paid $250 via Upwork.

    @aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.

  16. melvin-bot commented on May 15, 2026

    @melvin-bot

    @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  17. aimane-chnaif commented on May 15, 2026

    @aimane-chnaif
    Contributor

    @mallenexpensify accepted offer

  18. mallenexpensify commented on May 15, 2026

    @mallenexpensify
    Contributor

    @aimane-chnaif paid, summary updated above. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions