[Due for payment 2026-04-30] [$250] Workspace - Missing subheader under “Select features to copy” in duplication flow

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: V9.3.60-17
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/TR-20165/folder/13177080/44744009/1343292522
Email or phone of affected tester (no customers): dreamnitethedragon+vegst@gmail.com
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Redmi note 10s android 13
App Component: Workspace Settings

Action Performed:

Launch app
Login with new gmail account and complete onboarding via track & budget expense
Go to workspace settings
Tap 3 dots next to workspace and select duplicate workspace
Tap next

Expected Result:

The sub header must show the text “Which features do you want to copy over to your new workspace?

Actual Result:

The subheader text is missing under the “Select features to copy” heading during the workspace duplication flow.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug7132814_1776501770418.Screenrecorder-2026-04-18-13-56-07-5.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~022045521476047714281
Upwork Job ID: 2045521476047714281
Last Price Increase: 2026-04-18

Proposal

What is the root cause of that problem?

The subheader <Text> at WorkspaceDuplicateSelectFeaturesForm.tsx:353 uses styles.webViewStyles.baseFontStyle, which is a style designed for react-native-render-html — not regular <Text> components. That style includes flex: 1 (index.ts:247), which causes the text to collapse to zero height on Android inside the auto-height parent <View>.

What changes do you think we should make in order to solve the problem?

Remove styles.webViewStyles.baseFontStyle from the subheader's style array at line 353 and use only styles.textSupporting (plus styles.mt1 for a small top margin), matching the pattern used by other similar screens (e.g., WorkspaceCompanyCardAddWorkEmailPage.tsx:143).

Change:

<Text style={[styles.webViewStyles.baseFontStyle, styles.textSupporting]}>

to:

<Text style={[styles.mt1, styles.textSupporting]}>

What alternative solutions did you explore? (Optional)

Could override flex: 1 by adding flex: undefined to the style array, but that's a workaround. The correct fix is to not use a WebView-specific style on a regular Text component.

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

@dukenv0307

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

Job added to Upwork: https://www.upwork.com/jobs/~022045521476047714281

Proposal

Please re-state the problem that we are trying to solve in this issue.

During the workspace duplication flow, the subheader text "Which features do you want to copy over to your new workspace?" is missing beneath the "Select features to copy" heading on Android.

What is the root cause of that problem?

The subheader <Text> component on line 353 of WorkspaceDuplicateSelectFeaturesForm.tsx is styled with styles.webViewStyles.baseFontStyle, which includes flex: 1. This style was designed for use in WebView/HTML rendering contexts (it is the base style passed to TRenderEngineProvider), not for plain React Native <Text> components. When flex: 1 is applied to a <Text> inside a <View> that has no constrained height, React Native on Android distributes flex space by collapsing the text to zero visible height, effectively making it invisible. The issue does not reproduce on iOS because iOS handles flex: 1 on <Text> elements more permissively.

App/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx

Lines 351 to 354 in 03023c1

    
           <View style={[styles.ph5, styles.pv3]}> 
        
               <Text style={[styles.textHeadline]}>{translate('workspace.duplicateWorkspace.selectFeatures')}</Text> 
        
               <Text style={[styles.webViewStyles.baseFontStyle, styles.textSupporting]}>{translate('workspace.duplicateWorkspace.whichFeatures')}</Text> 
        
           </View>

What changes do you think we should make in order to solve the problem?

Replace styles.webViewStyles.baseFontStyle with styles.textNormal on the subheader <Text> at line 353. styles.textNormal provides the same font size and family without flex: 1, making it safe to use in standard React Native layout contexts. styles.textSupporting is already applied for the muted color, so we only need a style that contributes font sizing — styles.textNormal is appropriate.

App/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx

Line 353 in 03023c1

    
           <Text style={[styles.webViewStyles.baseFontStyle, styles.textSupporting]}>{translate('workspace.duplicateWorkspace.whichFeatures')}</Text>

- <Text style={[styles.webViewStyles.baseFontStyle, styles.textSupporting]}>{translate('workspace.duplicateWorkspace.whichFeatures')}</Text>
+ <Text style={[styles.textNormal, styles.textSupporting]}>{translate('workspace.duplicateWorkspace.whichFeatures')}</Text>

What alternative solutions did you explore? (Optional)

N/A

Proposal

What is the root cause of that problem?

The missing subheader is rendered in src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx, but it uses styles.webViewStyles.baseFontStyle on a normal Text component.

App/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx

Lines 351 to 354 in 03023c1

    
           <View style={[styles.ph5, styles.pv3]}> 
        
               <Text style={[styles.textHeadline]}>{translate('workspace.duplicateWorkspace.selectFeatures')}</Text> 
        
               <Text style={[styles.webViewStyles.baseFontStyle, styles.textSupporting]}>{translate('workspace.duplicateWorkspace.whichFeatures')}</Text> 
        
           </View>

styles.webViewStyles.baseFontStyle is defined in src/styles/index.ts and includes flex: 1.

App/src/styles/index.ts

Lines 243 to 250 in 03023c1

    
           baseFontStyle: { 
        
               color: theme.text, 
        
               fontSize: variables.fontSizeNormal, 
        
               ...FontUtils.fontFamily.platform.EXP_NEUE, 
        
               flex: 1, 
        
               lineHeight: variables.fontSizeNormalHeight, 
        
               ...writingDirection.ltr, 
        
           },

That style is intended for rendered HTML base text, not a regular React Native Text. On Android, applying flex: 1 to this Text inside the auto-height header View causes the text layout to collapse, so the translated subheader is present in code but not visible.

What changes do you think we should make in order to solve the problem?

The original code in src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx applies the HTML base style directly to the subheader Text.

App/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx

Line 353 in 03023c1

    
           <Text style={[styles.webViewStyles.baseFontStyle, styles.textSupporting]}>{translate('workspace.duplicateWorkspace.whichFeatures')}</Text>

Replace the WebView/HTML style with the Text component's existing typography defaults and pass only the supporting color through the component API. The shared Text component already defaults to normal font size, normal line height, and the app's normal font family.

App/src/components/Text.tsx

Lines 39 to 54 in 03023c1

    
           function Text({color, fontSize = variables.fontSizeNormal, textAlign = 'left', children, family = 'EXP_NEUE', style = {}, shouldUseDefaultLineHeight = true, ref, ...props}: TextProps) { 
        
               const theme = useTheme(); 
        
               const customStyle = useContext(CustomStylesForChildrenContext); 
        
               const componentStyle: TextStyle = { 
        
                   color: color ?? theme.text, 
        
                   fontSize, 
        
                   textAlign, 
        
                   ...FontUtils.fontFamily.platform[family], 
        
                   ...StyleSheet.flatten(style), 
        
                   ...StyleSheet.flatten(customStyle), 
        
               }; 
        
               if (!componentStyle.lineHeight && componentStyle.fontSize === variables.fontSizeNormal && shouldUseDefaultLineHeight) { 
        
                   componentStyle.lineHeight = variables.fontSizeNormalHeight; 
        
               }

diff --git a/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx b/src/pages/workspace/duplicate/WorkspaceDuplicateSelectFeaturesForm.tsx
@@
 import useLocalize from '@hooks/useLocalize';
 import useOnyx from '@hooks/useOnyx';
 import usePolicy from '@hooks/usePolicy';
+import useTheme from '@hooks/useTheme';
 import useThemeStyles from '@hooks/useThemeStyles';
@@
 function WorkspaceDuplicateSelectFeaturesForm({policyID}: WorkspaceDuplicateFormProps) {
     const styles = useThemeStyles();
+    const theme = useTheme();
     const {translate} = useLocalize();
@@
-                    <Text style={[styles.webViewStyles.baseFontStyle, styles.textSupporting]}>{translate('workspace.duplicateWorkspace.whichFeatures')}</Text>
+                    <Text color={theme.textSupporting}>{translate('workspace.duplicateWorkspace.whichFeatures')}</Text>

This removes the invalid flex: 1 from the subheader while preserving the same normal supporting-text appearance. The subheader can then take its natural height on Android and render under the "Select features to copy" title.

What alternative solutions did you explore? (Optional)

I considered replacing styles.webViewStyles.baseFontStyle with styles.textNormal plus styles.textSupporting. That also removes flex: 1, but it duplicates defaults that the shared Text component already provides.

I also considered using styles.textSupportingNormal. That is valid, but it still solves the issue by swapping one text style for another. Passing color={theme.textSupporting} is more explicit here because the only behavior we need beyond the Text defaults is the supporting color.

I considered overriding the bad style with flex: undefined or flex: 0, but that keeps an HTML-rendering style on a normal Text and hides the real problem.

fixed_sub_header_workspace.mp4

@MelvinBot

@MelvinBot Implement this

🤖 Draft PR created: #88299
Please mark it as "Ready for review" when it is ready for review.

BugZero Checklist:

[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to the comment on the PR: https://github.com/Expensify/App/pull/69146/changes#r3142909935
Link to the comment on the Issue: [Due for payment 2025-09-19] [Due for payment 2025-09-04] Implement Duplicate Workspace feature #67289 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue: https://github.com/Expensify/Expensify/issues/631775

Regression Test Proposal

Precondition:

Test:

Login with any account
Go to workspace settings
Tap 3 dots next to workspace and select duplicate workspace
Tap next
Verify that: The sub header must show the text Which features do you want to copy over to your new workspace?

Do we agree 👍 or 👎

Zapier Logs

Run ID: 00040eee-7bd5-aee8-48cd-ff1c299f1db4

@dukenv0307

Payment Summary

Upwork Job

Reviewer: @dukenv0307 owed $250 via NewDot

BugZero Checklist (@mallenexpensify)

(if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
I have verified the correct assignees and roles are listed above and updated the necessary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/2045521476047714281/hired)
I have verified the PR was not reverted
I have applied any discounts due to bugs/regressions introduced by this PR
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@dukenv0307

Payment Summary

Contributor+: @dukenv0307 due $250 via NewDot

^ Test case created

@dukenv0307

Approved $250 to @dukenv0307

Navigation Menu

Repository navigation

[Due for payment 2026-04-30] [$250] Workspace - Missing subheader under “Select features to copy” in duplication flow #88255

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

13 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Payment Summary

BugZero Checklist (@mallenexpensify)

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<View style={[styles.ph5, styles.pv3]}>
	<Text style={[styles.textHeadline]}>{translate('workspace.duplicateWorkspace.selectFeatures')}</Text>
	<Text style={[styles.webViewStyles.baseFontStyle, styles.textSupporting]}>{translate('workspace.duplicateWorkspace.whichFeatures')}</Text>
	</View>

	baseFontStyle: {
	color: theme.text,
	fontSize: variables.fontSizeNormal,
	...FontUtils.fontFamily.platform.EXP_NEUE,
	flex: 1,
	lineHeight: variables.fontSizeNormalHeight,
	...writingDirection.ltr,
	},

	function Text({color, fontSize = variables.fontSizeNormal, textAlign = 'left', children, family = 'EXP_NEUE', style = {}, shouldUseDefaultLineHeight = true, ref, ...props}: TextProps) {
	const theme = useTheme();
	const customStyle = useContext(CustomStylesForChildrenContext);

	const componentStyle: TextStyle = {
	color: color ?? theme.text,
	fontSize,
	textAlign,
	...FontUtils.fontFamily.platform[family],
	...StyleSheet.flatten(style),
	...StyleSheet.flatten(customStyle),
	};

	if (!componentStyle.lineHeight && componentStyle.fontSize === variables.fontSizeNormal && shouldUseDefaultLineHeight) {
	componentStyle.lineHeight = variables.fontSizeNormalHeight;
	}

[Due for payment 2026-04-30] [$250] Workspace - Missing subheader under “Select features to copy” in duplication flow #88255

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

MelvinBot commented on Apr 18, 2026

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Apr 18, 2026

melvin-bot commented on Apr 18, 2026

MobileMage commented on Apr 18, 2026

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

emkhalid commented on Apr 19, 2026

Proposal

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dukenv0307 commented on Apr 20, 2026

MelvinBot commented on Apr 20, 2026

13 remaining items

dukenv0307 commented on Apr 26, 2026

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

melvin-bot commented on Apr 30, 2026

Payment Summary

BugZero Checklist (@mallenexpensify)

mallenexpensify commented on Apr 30, 2026

Payment Summary

quinthar commented on May 12, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions