You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-07] Expense-Hold violation is not shown in preview for duplicate split expenses. #88300
Version Number: V9.3.60-17 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#84657 Email or phone of affected tester (no customers):dreamnitethedragon+vegst@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Redmi note 10s android 13 App Component: Money Requests
Action Performed:
Launch app
Open workspace chat
Create 2 distance manual expense
Open one expense and split the expense
Select both split expense and hold them
Select them again and duplicate the expenses
Note in duplicate expense preview hold violation is not shown
Open one of duplicate expense and note expense hold message mentioned above
Expected Result:
Hold violation must be shown in preview for duplicate split expenses.
Actual Result:
Hold violation is not shown in preview for duplicate split expenses.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #84657 - "[Duplicate Expense] Allow bulk duplication." by @Krishna2323 (High confidence) Related Issues: #84281
Recommendation: REVERT
The bulk duplication feature introduced by PR #84657 does not preserve the hold status when duplicating split expenses. The fix requires changes in src/libs/actions/IOU/Duplicate.ts within the App repo. Reverting the PR is the safest path since this is a new feature with no production presence.
Assigned: @Krishna2323 (PR author), @situchan (approving reviewer), @JS00001 (approving reviewer) Labels: DeployBlockerCash kept (frontend App PR caused the issue). DeployBlocker removed — this is a frontend bug requiring changes in the App repo only.
The buildDuplicateTransactionParams function spreads transactionWithoutLinkedAction (which includes transaction.comment as an object containing hold, waypoints, customUnit, etc.) and then overwrites it on line 534:
This replaces the entire comment object with a plain string. The hold field stored in transaction.comment.hold is therefore stripped out during duplication.
The isOnHold utility function in TransactionUtils/index.ts returns !!transaction.comment?.hold. With comment set to a string, comment.hold is undefined, so the hold state is lost.
In TransactionPreviewUtils.ts line 237, the hold message display depends on !!transaction?.comment?.hold — which will always be falsy for transactions duplicated via this new bulk-duplicate path.
Root Cause
buildDuplicateTransactionParams in src/libs/actions/IOU/Duplicate.ts (introduced/modified by PR #84657) overwrites the comment field with a plain markdown string, discarding all structured sub-fields of transaction.comment including the hold field. When split expenses on hold are duplicated via the new bulk duplication action, the resulting transactions have no comment.hold value, so the hold violation and hold message do not appear in the expense preview.
changed the title [-]Expense-Hold violation is not shown in preview for duplicate split expenses.[/-][+][Due for payment 2026-05-07] Expense-Hold violation is not shown in preview for duplicate split expenses.[/+]on Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 20, 2026
@JS00001 recently merged #84657, but they are OOO right now, so I'll auto-assign someone else.
melvin-bot commentedon Apr 20, 2026
Triggered auto assignment to @rlinoz (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 20, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 20, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 20, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #84657 - "[Duplicate Expense] Allow bulk duplication." by @Krishna2323 (High confidence)
Related Issues: #84281
Recommendation: REVERT
The bulk duplication feature introduced by PR #84657 does not preserve the
holdstatus when duplicating split expenses. The fix requires changes insrc/libs/actions/IOU/Duplicate.tswithin the App repo. Reverting the PR is the safest path since this is a new feature with no production presence.Assigned: @Krishna2323 (PR author), @situchan (approving reviewer), @JS00001 (approving reviewer)
Labels:
DeployBlockerCashkept (frontend App PR caused the issue).DeployBlockerremoved — this is a frontend bug requiring changes in the App repo only.Detailed Analysis
Evidence
Verification
Affected file:
src/libs/actions/IOU/Duplicate.ts— specificallybuildDuplicateTransactionParams()starting at line 521.PR #84657 modifies
src/libs/actions/IOU/Duplicate.ts(confirmed viagh pr view 84657 --json files).The
buildDuplicateTransactionParamsfunction spreadstransactionWithoutLinkedAction(which includestransaction.commentas an object containinghold,waypoints,customUnit, etc.) and then overwrites it on line 534:This replaces the entire
commentobject with a plain string. Theholdfield stored intransaction.comment.holdis therefore stripped out during duplication.The
isOnHoldutility function inTransactionUtils/index.tsreturns!!transaction.comment?.hold. Withcommentset to a string,comment.holdisundefined, so the hold state is lost.In
TransactionPreviewUtils.tsline 237, the hold message display depends on!!transaction?.comment?.hold— which will always be falsy for transactions duplicated via this new bulk-duplicate path.Root Cause
buildDuplicateTransactionParamsinsrc/libs/actions/IOU/Duplicate.ts(introduced/modified by PR #84657) overwrites thecommentfield with a plain markdown string, discarding all structured sub-fields oftransaction.commentincluding theholdfield. When split expenses on hold are duplicated via the new bulk duplication action, the resulting transactions have nocomment.holdvalue, so the hold violation and hold message do not appear in the expense preview.15 remaining items
melvin-bot commentedon Apr 28, 2026
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-]Expense-Hold violation is not shown in preview for duplicate split expenses.[/-][+][Due for payment 2026-05-07] Expense-Hold violation is not shown in preview for duplicate split expenses.[/+]melvin-bot commentedon Apr 30, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 30, 2026
@Krishna2323 / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon May 4, 2026
@Krishna2323 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Krishna2323 commentedon May 5, 2026
@JS00001 we can close this PR.