Skip to content

[Due for payment 2026-05-07] Expense - "You already have an empty report" modal does not show updated name "All reports" #88419

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.61-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #88181
Email or phone of affected tester (no customers): sodijsdodjsoijsnioj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an empty report.
  4. Click + > Create report.

Expected Result:

"You already have an empty report" modal will show the updated destination name "All report".

Actual Result:

"You already have an empty report" modal does not show the updated destination name "All report".

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @bernhardoj

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 21, 2026
  2. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #88181

  3. melvin-bot commented on Apr 21, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 21, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #88181 - "Update search groupings and suggested search names in LHN" by @aimane-chnaif (High confidence)
    Related Issues: #84881 (the original feature issue this PR fixed)

    Recommendation: ROLL FORWARD

    The fix is a small, targeted string update—changing emptyReportConfirmationPromptLink from 'Reports' to 'All reports' in the language files—which is simpler and less risky than reverting a large rename PR that touched many language files and search utilities.

    Assigned: @aimane-chnaif (PR author), @JS00001, @bernhardoj, @joekaufmanexpensify, @luacmartins (approving reviewers)
    Labels: No label changes made. DeployBlockerCash is correct and is kept—this is a frontend bug requiring an App fix.

    Detailed Analysis

    Evidence

    • The bug report states: the "You already have an empty report" modal does not show the updated destination name "All reports"—it still shows the old name "Reports".
    • PR Update search groupings and suggested search names in LHN #88181 renamed the "Reports" suggested search in the LHN to "All reports" by adding new translation keys under search.tabs.reports = 'All reports' in all language files.
    • However, PR Update search groupings and suggested search names in LHN #88181 did NOT update the separate translation key report.newReport.emptyReportConfirmationPromptLink, which is used as the link text inside the empty report confirmation modal. This key still contains the old string 'Reports' (in English) and its equivalents in all other languages.
    • The modal text reads: "...You can access your empty reports in Reports." — but after the rename, it should read "...in All reports."
    • The bug is staging-only (new feature, not in production), which is consistent with this being caused by a PR in the current staging release.
    • The melvin-bot correctly identified PR Update search groupings and suggested search names in LHN #88181 as the cause.

    Verification

    • Affected file: /home/runner/_work/App/App/src/languages/en.ts — specifically report.newReport.emptyReportConfirmationPromptLink at line 7853, which still holds 'Reports'.
    • The hook consuming this key is /home/runner/_work/App/App/src/hooks/useCreateEmptyReportConfirmation.tsx (line 42).
    • PR Update search groupings and suggested search names in LHN #88181 confirmed to modify the language files (src/languages/en.ts and all other language files) but did not touch emptyReportConfirmationPromptLink.

    Root Cause

    PR #88181 introduced new search.tabs.* translation keys to rename the LHN search sections (e.g., "Reports" -> "All reports") but did not update the older, pre-existing report.newReport.emptyReportConfirmationPromptLink key used in the "You already have an empty report" confirmation modal. This key lives separately in the language files and still reads 'Reports', while the UI now labels that destination "All reports".

  6. MelvinBot commented on Apr 21, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    PR Expensify/App#88181 renamed the search tab from "Reports" to "All reports" by updating the search.tabs.reports translation key, but did not update the corresponding link text in the empty report confirmation modal.

    The modal is rendered by useCreateEmptyReportConfirmation.tsx:42 and displays the link text from report.newReport.emptyReportConfirmationPromptLink, which still says 'Reports' instead of 'All reports'.

    What changes do you think we should make in order to solve the problem?

    Update emptyReportConfirmationPromptLink in all language files to match the corresponding search.tabs.reports value:

    • en.ts: 'Reports' → 'All reports'
    • de.ts, es.ts, fr.ts, it.ts, ja.ts, nl.ts, pl.ts, pt-BR.ts, zh-hans.ts: update each to the translated equivalent already present in their respective search.tabs.reports key.

    No logic changes needed — this is a string-only fix.


    Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

  7. JS00001 commented on Apr 21, 2026

    @JS00001
    Contributor

    PR open for this: #88421

  8. JS00001 commented on Apr 21, 2026

    @JS00001
    Contributor

    I dont think this is major enough to CP or block though, demoting

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 21, 2026
  10. joekaufmanexpensify commented on Apr 27, 2026

    @joekaufmanexpensify
    Contributor

    PR merged today

  11. JS00001 commented on Apr 27, 2026

    @JS00001
    Contributor

    The issue here has been fixed

  12. changed the title [-]Expense - "You already have an empty report" modal does not show updated name "All reports"[/-] [+][Due for payment 2026-05-07] Expense - "You already have an empty report" modal does not show updated name "All reports"[/+] on Apr 30, 2026
  13. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-07. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    @bernhardoj / @aimane-chnaif The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions