Skip to content

[Due for payment 2026-05-07] Onboarding - QA guide avatar and user name disappear after reopening #admins #88544

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.61-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #87166
Email or phone of affected tester (no customers): sdosidjosidjnoisjniosj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Chat Report View

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new Gmail account.
  3. Complete onboarding.
  4. Create a workspace.
  5. Go to #admins room.
  6. Open another report.
  7. Go to #admins room.
  8. Might need to repeat Step 6 and 7.

Expected Result:

QA guide avatar and email will not disappear.

Actual Result:

QA guide avatar and email disappear after reopening #admins room.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

123-123.mp4
Image

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Apr 22, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #87166

  2. melvin-bot commented on Apr 22, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Apr 22, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. marcaaron commented on Apr 22, 2026

    @marcaaron
    Contributor

    I think @mountiny is out. Trying to repro...

  5. 29 remaining items

  6. MelvinBot commented on May 1, 2026

    @MelvinBot
    Contributor

    The offending PR is #85114 ("Migrate main chat to FlashList with inverted flag") by VickyStash, merged on 2026-04-15.

    How it introduced the bug: PR #85114 introduced useFlashListScrollKey.ts which slices the data array (data.slice(targetIndex)) on initial render when a deep-link targets a specific action. However, renderItem still used the FlashList-provided index (relative to the sliced array) to look up adjacent actions in the full sortedVisibleReportActions array for the displayAsGroup computation. This index mismatch caused isConsecutiveActionMadeByPreviousActor to compare the wrong actions, incorrectly returning true and hiding the guide's avatar/name.

    The fix was delivered in #88571.

  7. aimane-chnaif commented on May 1, 2026

    @aimane-chnaif
    Contributor

    BugZero Checklist:

    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Came from FlashList migration

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue: https://github.com/Expensify/Expensify/issues/634708

    Regression Test Proposal

    Test:

    1. Create a new Gmail account.
    2. Complete onboarding.
    3. Create a workspace.
    4. Go to #admins room.
    5. Open another report.
    6. Go to #admins room.
    7. Verify that QA guide avatar and email don't disappear.

    Do we agree 👍 or 👎

    Zapier Logs Run ID: 00040eee-5c9e-ab62-a301-a42c0d8bb7f4
  8. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 1, 2026
  9. melvin-bot commented on May 6, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  10. melvin-bot commented on May 7, 2026

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@mallenexpensify)

    • (if NewFeature) I have created a PR for any necessary HelpDot updates, or I confirmed no updates are necessary.
    • I have verified the correct assignees and roles are listed above and updated the necessary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have verified the PR was not reverted
    • I have applied any discounts due to bugs/regressions introduced by this PR
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  11. mallenexpensify commented on May 7, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @aimane-chnaif paid $250 via Upwork

    @aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
    https://www.upwork.com/jobs/~022052528985453492332

  12. aimane-chnaif commented on May 8, 2026

    @aimane-chnaif
    Contributor

    @mallenexpensify accepted offer

  13. mallenexpensify commented on May 9, 2026

    @mallenexpensify
    Contributor

    @aimane-chnaif paid, summary updated above. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions