You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-07] Onboarding - QA guide avatar and user name disappear after reopening #admins #88544
Version Number: 9.3.61-2 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87166 Email or phone of affected tester (no customers):sdosidjosidjnoisjniosj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Chat Report View
Action Performed:
Go to staging.new.expensify.com
Create a new Gmail account.
Complete onboarding.
Create a workspace.
Go to #admins room.
Open another report.
Go to #admins room.
Might need to repeat Step 6 and 7.
Expected Result:
QA guide avatar and email will not disappear.
Actual Result:
QA guide avatar and email disappear after reopening #admins room.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The offending PR is #85114 ("Migrate main chat to FlashList with inverted flag") by VickyStash, merged on 2026-04-15.
How it introduced the bug: PR #85114 introduced useFlashListScrollKey.ts which slices the data array (data.slice(targetIndex)) on initial render when a deep-link targets a specific action. However, renderItem still used the FlashList-provided index (relative to the sliced array) to look up adjacent actions in the full sortedVisibleReportActions array for the displayAsGroup computation. This index mismatch caused isConsecutiveActionMadeByPreviousActor to compare the wrong actions, incorrectly returning true and hiding the guide's avatar/name.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Activity
melvin-bot commentedon Apr 22, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87166
melvin-bot commentedon Apr 22, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 22, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
marcaaron commentedon Apr 22, 2026
I think @mountiny is out. Trying to repro...
29 remaining items
MelvinBot commentedon May 1, 2026
The offending PR is #85114 ("Migrate main chat to FlashList with inverted flag") by
VickyStash, merged on 2026-04-15.How it introduced the bug: PR #85114 introduced
useFlashListScrollKey.tswhich slices the data array (data.slice(targetIndex)) on initial render when a deep-link targets a specific action. However,renderItemstill used the FlashList-provided index (relative to the sliced array) to look up adjacent actions in the fullsortedVisibleReportActionsarray for thedisplayAsGroupcomputation. This index mismatch causedisConsecutiveActionMadeByPreviousActorto compare the wrong actions, incorrectly returningtrueand hiding the guide's avatar/name.The fix was delivered in #88571.
aimane-chnaif commentedon May 1, 2026
BugZero Checklist:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Came from FlashList migration
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue: https://github.com/Expensify/Expensify/issues/634708
Regression Test Proposal
Test:
Do we agree 👍 or 👎
Zapier Logs
Run ID: 00040eee-5c9e-ab62-a301-a42c0d8bb7f4melvin-bot commentedon May 6, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon May 7, 2026
Payment Summary
Upwork Job
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon May 7, 2026
Payment Summary
Contributor+: @aimane-chnaif paid $250 via Upwork
@aimane-chnaif can you please accept the job below? Please reply here and tag me once you have.
https://www.upwork.com/jobs/~022052528985453492332
aimane-chnaif commentedon May 8, 2026
@mallenexpensify accepted offer
mallenexpensify commentedon May 9, 2026
@aimane-chnaif paid, summary updated above. Thx.