Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.2.62-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #83127
Email or phone of affected tester (no customers): jnsdijsnodjonjiosjdio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests
Action Performed:
- Go to staging.new.expensify.com
- Go to workspace chat.
- Create two expenses.
- Open the report.
- Click Date field.
- Click Month or Year.
Expected Result:
There will be background blur when opening Month/Year RHP when inline editing.
Actual Result:
There is no background blur when opening Month/Year RHP when inline editing.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome / Safari
Screenshots/Videos
Bug7136935_1776975839161.3.mp4
Metadata
Metadata
Assignees
Labels
Type
Projects
- StatusShow more project fieldsDone
Activity
github-actions commentedon Apr 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 23, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #83127 - "feat: Add inline editing for tables on desktop" by @mohammadjafarinejad (High confidence)
Related Issues: None
Recommendation: REVERT
PR #83127 introduced the inline editing feature for expense table cells, including the
DateCellcomponent that usesDatePickerModal. The missing background blur when opening Month/Year RHP is a direct consequence of this new code path, and the feature does not exist in production. Reverting this PR will remove the regression.Assigned: @mohammadjafarinejad (PR author), @ahmedGaber93, @puneetlath (approving reviewers) from highest-confidence causing PR only
Labels:
DeployBlockerCashkept (frontend App PR caused the issue);DeployBlockernot present, no changes made.Detailed Analysis
Evidence
StagingDeployCash(issue Deploy Checklist: New Expensify 2026-04-23 #88633) checklist.DateCell.tsx(src/components/Search/SearchList/ListItem/DateCell.tsx), a new component that rendersDatePickerModalinside a popover as part of inline editing for expense table rows.DatePickerModalrenders aCalendarPicker, which containsYearPickerModalandMonthPickerModal. These areRIGHT_DOCKEDmodals that useshouldUseCustomBackdrop, which renders anOverlaycomponent driven by React Navigation'suseCardAnimation. WhenDatePickerModalis invoked from the new inline editing popover context (rather than a full navigation screen), the background blur for nested Month/Year modals is not produced.Verification
src/components/DatePicker/CalendarPicker/YearPickerModal.tsx,src/components/DatePicker/CalendarPicker/MonthPickerModal.tsx,src/components/Search/SearchList/ListItem/DateCell.tsxDateCell.tsx(new file) and modifiesDatePickerModal.tsx(addingshouldDisplayBelowModalsprop).YearPickerModal,MonthPickerModal) have always usedshouldUseCustomBackdropfor the blur overlay. The blur regression only occurs in the new inline-editing popover context introduced by feat: Add inline editing for tables on desktop #83127, not in existing non-inline-editing date picker flows.Root Cause
PR #83127 introduced
DateCell.tsxwhich rendersDatePickerModalas a popover within an inline editing flow. When a user clicks Month or Year inside the calendar,MonthPickerModalorYearPickerModalis opened as aRIGHT_DOCKEDmodal withshouldUseCustomBackdrop=true. TheOverlaycomponent behind this custom backdrop usesuseCardAnimationfrom React Navigation, which relies on a navigation stack context. In the new inline-editing popover rendering context created by #83127, the navigation animation progress available toOverlaydoes not produce the expected background blur/dim effect. The blur worked correctly in the pre-existing non-inline-editing flows because those date pickers were opened in a proper navigation context.ahmedGaber93 commentedon Apr 23, 2026
I believe we can disable the opening of Month/Year RHP in the inline edit and instead use the arrow keys.
Let's get @Expensify/design Thoughts?
trjExpensify commentedon Apr 23, 2026
Mhm, I think we probably just need to blur the background like we do the quick filter date popover. Happy to defer to design though!
shawnborton commentedon Apr 24, 2026
Agree, we should add that overlay scrim/background blur here.
trjExpensify commentedon Apr 24, 2026
Cool, @ahmedGaber93 another one to move forward with. 👍
ahmedGaber93 commentedon Apr 24, 2026
@mohammadjafarinejad Based on the comment at the end of line here
App/src/components/Modal/BaseModal.tsx
Lines 304 to 307 in f094ea5
The backdrops are disabled when opening on the same RHP to prevent overlapping backdrop opacity (see video below).
Screen.Recording.2026-04-24.at.9.11.52.PM.mov
We need to enable it for the current issue while preserving the existing behavior elsewhere. I think the best approach is to introduce a new flag to force-enable it on narrow layouts and pass it down through:
DatePickerModal > YearPicker / MonthPickeron DateCell componentcode diff
mohammadjafarinejad commentedon Apr 24, 2026
@ahmedGaber93 Thanks!
puneetlath commentedon Apr 24, 2026
Inline editing reverted.