You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Pressing space during inline editing opens the expense #88646
Version Number: 9.2.62-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#83127 Email or phone of affected tester (no customers):jnsdijsnodjonjiosjdio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Open the report.
Click Merchant field.
Press space.
Expected Result:
Space will be entered without opening the expense.
Actual Result:
Pressing space during inline editing opens the expense.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #83127 - "Adds inline editing to transaction table cells on desktop" by @mohammadjafarinejad (High confidence) Related Issues: None
Recommendation: REVERT
PR #83127 introduced the inline editing feature but has a bug where pressing Space during inline editing of the Merchant field fires the row's onPress handler (opening the expense) instead of entering a space character in the input.
PR feat: Add inline editing for tables on desktop #83127 adds inline editing to transaction table cells (MoneyRequestReportTransactionItem, TransactionItemRow, EditableCell, etc.) — exactly the code path the bug report describes.
The bug occurs on MacOS/Chrome (web), which is consistent with a react-native-web behavior where pressing Space fires onPress on elements with role="button".
PR #83127 modifies this file and introduces the wasEditingOnMouseDownRef guard in onPress, but omits the isEditingCell guard that was added to the Search TransactionListItem equivalent.
The PR diff for the Search TransactionListItem explicitly includes this comment and check:
// react-native-web fires onPress on Space for role="button" elements; suppress it while a cell is being edited.
if (isEditingCell) {
return;
}
This guard was not added to MoneyRequestReportTransactionItem.tsx. The current code (post-PR) only has:
onPress={()=>{if(wasEditingOnMouseDownRef.current){// guards against click blurwasEditingOnMouseDownRef.current=false;return;}handleOnPress(transaction.transactionID);// still fires on Space key}}
Without the isEditingCell guard, pressing Space while the Merchant text input is focused causes the outer PressableWithFeedback (which has role="button") to receive the Space keypress event and fire its onPress, navigating into the expense.
Root Cause
PR #83127 added the isEditingCell Space-key suppression logic to TransactionListItem (used in Search) but did not apply the same fix to MoneyRequestReportTransactionItem (used in the expense report view). This inconsistency means Space key presses during inline editing are only suppressed in the Search flow, not in the Money Request Report view where the bug occurs.
The fix is either to revert PR #83127 entirely, or to add if (isEditingCell) { return; } to the onPress handler in MoneyRequestReportTransactionItem.tsx (the isEditingCell value is already available at line 96 of that file).
Activity
github-actions commentedon Apr 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 23, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #83127 - "Adds inline editing to transaction table cells on desktop" by @mohammadjafarinejad (High confidence)
Related Issues: None
Recommendation: REVERT
PR #83127 introduced the inline editing feature but has a bug where pressing Space during inline editing of the Merchant field fires the row's
onPresshandler (opening the expense) instead of entering a space character in the input.Assigned: @mohammadjafarinejad (PR author), @puneetlath (approving reviewer)
Labels:
DeployBlockerCashkept (frontend App bug).DeployBlockerremoved — no backend involvement.Detailed Analysis
Evidence
MoneyRequestReportTransactionItem,TransactionItemRow,EditableCell, etc.) — exactly the code path the bug report describes.react-native-webbehavior where pressing Space firesonPresson elements withrole="button".Verification
Affected files:
src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsxPR #83127 modifies this file and introduces the
wasEditingOnMouseDownRefguard inonPress, but omits theisEditingCellguard that was added to the SearchTransactionListItemequivalent.The PR diff for the Search
TransactionListItemexplicitly includes this comment and check:This guard was not added to
MoneyRequestReportTransactionItem.tsx. The current code (post-PR) only has:Without the
isEditingCellguard, pressing Space while the Merchant text input is focused causes the outerPressableWithFeedback(which hasrole="button") to receive the Space keypress event and fire itsonPress, navigating into the expense.Root Cause
PR #83127 added the
isEditingCellSpace-key suppression logic toTransactionListItem(used in Search) but did not apply the same fix toMoneyRequestReportTransactionItem(used in the expense report view). This inconsistency means Space key presses during inline editing are only suppressed in the Search flow, not in the Money Request Report view where the bug occurs.The fix is either to revert PR #83127 entirely, or to add
if (isEditingCell) { return; }to theonPresshandler inMoneyRequestReportTransactionItem.tsx(theisEditingCellvalue is already available at line 96 of that file).trjExpensify commentedon Apr 24, 2026
I can repro this one in the report view, agree we should fix it. CC: @ahmedGaber93
ahmedGaber93 commentedon Apr 24, 2026
@mohammadjafarinejad returning early before here if fix the issue with me
App/src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsx
Line 152 in 7bc98b6
puneetlath commentedon Apr 24, 2026
Inline editing reverted.