You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Multi line description changes to single line description after inline editing #88651
Version Number: 9.3.62-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#83127 Email or phone of affected tester (no customers):sdsodijnosdjoij@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create an expense with multi line description.
Go to Spend > All expenses.
Click Description field.
Type anything and hit Enter.
Open the expense.
Expected Result:
Multi line description will be preserved after inline editing.
Actual Result:
Multi line description changes to single line description after inline editing.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #83127 - "feat: Add inline editing for tables on desktop" by @mohammadjafarinejad (High confidence) Related Issues: #82534
Recommendation: REVERT
PR #83127 introduced the inline editing feature for transaction table cells and contains a bug in the description field handling that destroys multiline content on save. Reverting this PR will resolve the issue since it is a new feature that does not yet exist in production.
Assigned: @mohammadjafarinejad (PR author), @ahmedGaber93, @puneetlath (approving reviewers) from highest-confidence causing PR only Labels: DeployBlockerCash kept (frontend App PR caused the issue). DeployBlocker removed (no backend fix required).
PR feat: Add inline editing for tables on desktop #83127 adds inline editing to transaction table cells (date, merchant, description, category, amount) in the search/expenses view — exactly the code path described in the reproduction steps.
The bug appears only on staging and is marked as a "new feature, doesn't exist in prod", which is consistent with this feature being introduced in the current staging batch.
This strips newlines from the description for display purposes. However, this same text value is passed directly into useInlineEditState as the initial value, meaning localValue — the value that gets saved on blur/submit — is initialized from the already-flattened (single-line) string rather than the raw multiline description.
When the user opens the inline editor for a multiline description, types anything, and hits Enter (triggering save), the hook calls onSave(localValue). Because localValue was seeded from the display-formatted (newlines-stripped) text, the multiline content is overwritten with a single-line version. The fix requires separating the display-formatted text from the value passed to useInlineEditState — the latter should use the raw (unstripped) description.
Activity
melvin-bot commentedon Apr 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #83127
melvin-bot commentedon Apr 23, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 23, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #83127 - "feat: Add inline editing for tables on desktop" by @mohammadjafarinejad (High confidence)
Related Issues: #82534
Recommendation: REVERT
PR #83127 introduced the inline editing feature for transaction table cells and contains a bug in the description field handling that destroys multiline content on save. Reverting this PR will resolve the issue since it is a new feature that does not yet exist in production.
Assigned: @mohammadjafarinejad (PR author), @ahmedGaber93, @puneetlath (approving reviewers) from highest-confidence causing PR only
Labels:
DeployBlockerCashkept (frontend App PR caused the issue).DeployBlockerremoved (no backend fix required).Detailed Analysis
Evidence
Verification
src/components/TransactionItemRow/DataCells/MerchantCell.tsx, which was added/modified by PR feat: Add inline editing for tables on desktop #83127.isDescriptionprop) and is where the multiline-to-single-line conversion occurs.Root Cause
In
MerchantCell.tsx, the display-modetextvariable is computed as:This strips newlines from the description for display purposes. However, this same
textvalue is passed directly intouseInlineEditStateas the initialvalue, meaninglocalValue— the value that gets saved on blur/submit — is initialized from the already-flattened (single-line) string rather than the raw multiline description.When the user opens the inline editor for a multiline description, types anything, and hits Enter (triggering
save), the hook callsonSave(localValue). BecauselocalValuewas seeded from the display-formatted (newlines-stripped) text, the multiline content is overwritten with a single-line version. The fix requires separating the display-formatted text from the value passed touseInlineEditState— the latter should use the raw (unstripped) description.ahmedGaber93 commentedon Apr 23, 2026
We’ve decided to address this issue in a follow-up for deep investigation #83127 (comment)
trjExpensify commentedon Apr 24, 2026
Agreed, going to close this.