You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-05-07] Expense - Tax defaults to 0% after creating unreported expense with other tax rate #88656
Version Number: 9.3.62-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#87911 Email or phone of affected tester (no customers):sjdosjdnsdiojsd@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Enable Taxes in workspace settings.
Go to staging.new.expensify.com
Go to self DM.
Create an expense with 5% tax rate.
Open the expense.
Expected Result:
Tax field will show 5% tax rate.
Actual Result:
Tax field shows 0% tax rate.
The selected tax during creation s not saved.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@mitarachim do you have any more context about the test case? Is there any way to tell when the regression was originally created, what issue it was associated with?
Classification: Frontend bug Causing PR: #87993 - "Fix: Time expenses are created with tax" by @dominictb (Medium confidence) Related Issues: The melvin-bot flagged #87911 based on which PR the tester was regressing when they found the bug, but that PR's changes are isolated to distance-rate tax code selection and cannot affect regular expense creation.
Recommendation: NEEDS INVESTIGATION
PR #87993 is the most likely cause based on code analysis, but the exact reproduction path needs confirmation from the PR author or QA. The PR author (@dominictb) and reviewers should verify whether the isTaxTrackingEnabled gate in useExpenseSubmission.ts drops the user-selected tax code in certain policy configurations.
Assigned: @dominictb (PR author), @hoangzinh and @youssef-lr (approving reviewers) from highest-confidence causing PR Labels: Keeping both DeployBlockerCash and DeployBlocker labels — this is a frontend bug in Expensify/App but exact reproduction path needs confirmation before removing DeployBlocker.
PR #87993 ("Fix: Time expenses are created with tax", merged April 21, 2026) modified src/pages/iou/request/step/confirmation/useExpenseSubmission.ts to add an isTaxTrackingEnabled gate around the transactionTaxCode computation:
If isTaxTrackingEnabled returns false for any reason (e.g., policy is undefined or policy.tax.trackingEnabled is falsy), the user's explicitly selected transaction.taxCode (5% tax rate) is discarded and '' is submitted instead, causing the expense to show 0% tax.
PR #87911 ("fix: Wrong tax rate is used when selecting a distance rate", merged April 22, 2026) modified getDefaultTaxCode in TransactionUtils/index.ts and IOURequestStepDistanceRate.tsx. All changes in PR #87911 are inside the if (isDistanceRequest(transaction)) guard. The bug reports a regular manual expense (not distance) created in self DM - the distance-specific code path is never triggered for this scenario.
Why the bug is staging-only:
Both PR #87911 and PR #87993 are in the 9.3.62-0 staging release and not in production, consistent with the bug being staging-only.
The bug symptom (tax defaults to 0% on submit) matches exactly what happens when transactionTaxCode is set to '' instead of the user's selected tax code
Root Cause
isTaxTrackingEnabled(isPolicyExpenseChat || isUnreported, policy, ...) can return false for an unreported self-DM expense if:
policy (the policyForMovingExpenses) is undefined — this happens when usePolicyForMovingExpenses resolves to undefined (e.g., user has multiple workspaces and none is selected as active, or no valid workspace exists)
policy.tax.trackingEnabled is false or undefined
In either case, the user's selected 5% tax code stored in the draft transaction (transaction.taxCode) is silently discarded, and the expense is submitted with taxCode: '' and taxAmount: 0, resulting in 0% tax being displayed when the expense is opened.
The original code before PR #87993 did not have this gate and would always use transaction.taxCode if it was set, preserving the user's tax selection.
Normally we prefer to revert, but the fix-forward patch is very simple and was prepared promptly, so I've merged it. Going to request a CP to staging now
changed the title [-]Expense - Tax defaults to 0% after creating unreported expense with other tax rate[/-][+][Due for payment 2026-05-07] Expense - Tax defaults to 0% after creating unreported expense with other tax rate[/+]on Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Apr 23, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #87911
melvin-bot commentedon Apr 23, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 23, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
chuckdries commentedon Apr 23, 2026
Hm, I do wonder whether workspace tax rates are really expected to work correctly in selfDM, since those reports are not associated with the workspace
chuckdries commentedon Apr 23, 2026
@mitarachim do you have any more context about the test case? Is there any way to tell when the regression was originally created, what issue it was associated with?
OSBotify commentedon Apr 23, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #87993 - "Fix: Time expenses are created with tax" by @dominictb (Medium confidence)
Related Issues: The melvin-bot flagged #87911 based on which PR the tester was regressing when they found the bug, but that PR's changes are isolated to distance-rate tax code selection and cannot affect regular expense creation.
Recommendation: NEEDS INVESTIGATION
PR #87993 is the most likely cause based on code analysis, but the exact reproduction path needs confirmation from the PR author or QA. The PR author (@dominictb) and reviewers should verify whether the
isTaxTrackingEnabledgate inuseExpenseSubmission.tsdrops the user-selected tax code in certain policy configurations.Assigned: @dominictb (PR author), @hoangzinh and @youssef-lr (approving reviewers) from highest-confidence causing PR
Labels: Keeping both
DeployBlockerCashandDeployBlockerlabels — this is a frontend bug inExpensify/Appbut exact reproduction path needs confirmation before removingDeployBlocker.Details
Evidence
Why PR #87993 is the primary suspect:
PR #87993 ("Fix: Time expenses are created with tax", merged April 21, 2026) modified
src/pages/iou/request/step/confirmation/useExpenseSubmission.tsto add anisTaxTrackingEnabledgate around thetransactionTaxCodecomputation:Before PR #87993:
After PR #87993:
If
isTaxTrackingEnabledreturnsfalsefor any reason (e.g.,policyisundefinedorpolicy.tax.trackingEnabledis falsy), the user's explicitly selectedtransaction.taxCode(5% tax rate) is discarded and''is submitted instead, causing the expense to show 0% tax.Why PR #87911 is NOT the cause:
PR #87911 ("fix: Wrong tax rate is used when selecting a distance rate", merged April 22, 2026) modified
getDefaultTaxCodeinTransactionUtils/index.tsandIOURequestStepDistanceRate.tsx. All changes in PR #87911 are inside theif (isDistanceRequest(transaction))guard. The bug reports a regular manual expense (not distance) created in self DM - the distance-specific code path is never triggered for this scenario.Why the bug is staging-only:
Both PR #87911 and PR #87993 are in the
9.3.62-0staging release and not in production, consistent with the bug being staging-only.Verification
src/pages/iou/request/step/confirmation/useExpenseSubmission.tsisTaxTrackingEnabledguarduseExpenseSubmission.tstransactionTaxCodeis set to''instead of the user's selected tax codeRoot Cause
isTaxTrackingEnabled(isPolicyExpenseChat || isUnreported, policy, ...)can returnfalsefor an unreported self-DM expense if:policy(thepolicyForMovingExpenses) isundefined— this happens whenusePolicyForMovingExpensesresolves toundefined(e.g., user has multiple workspaces and none is selected as active, or no valid workspace exists)policy.tax.trackingEnabledisfalseorundefinedIn either case, the user's selected 5% tax code stored in the draft transaction (
transaction.taxCode) is silently discarded, and the expense is submitted withtaxCode: ''andtaxAmount: 0, resulting in 0% tax being displayed when the expense is opened.The original code before PR #87993 did not have this gate and would always use
transaction.taxCodeif it was set, preserving the user's tax selection.5 remaining items
chuckdries commentedon Apr 24, 2026
Normally we prefer to revert, but the fix-forward patch is very simple and was prepared promptly, so I've merged it. Going to request a CP to staging now
arosiclair commentedon Apr 27, 2026
Requested a retest here
IuliiaHerets commentedon Apr 27, 2026
@arosiclair Issue is not reproduced anymore on Windows 10/Chrome and iPhone 13/iOS 26.3, v9.3.62-5
ScreenRecording_04-27-2026.18-38-39_1.MP4
bandicam.2026-04-27.18-30-05-762.mp4
[-]Expense - Tax defaults to 0% after creating unreported expense with other tax rate[/-][+][Due for payment 2026-05-07] Expense - Tax defaults to 0% after creating unreported expense with other tax rate[/+]melvin-bot commentedon Apr 30, 2026
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 30, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-05-07. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 30, 2026
@hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]