Skip to content

[Due for payment 2026-06-09] [Bulk workspace edits] Page 3 (Double-check confirmation) [5] #88672

Closed

Description

@francoisl

Task

Build pages/workspace/copyPolicySettings/CopyPolicySettingsConfirmPage.tsx, the final RHP step before the copy kicks off.

  • Header: "Let's double-check to make sure everything looks right."
  • Subheader: "We'll begin updating workspaces once you tap 'Copy configuration'"
  • Two PressableWithFeedback rows styled as menu items with right chevrons:
    • Configuration — shows the parts selected in Page 2; tapping navigates back to SELECT_FEATURES
    • Workspaces — shows the targets selected in Page 1; tapping navigates back to ROOT
  • Primary button "Copy configuration" calls copyPolicySettings(...) and dismisses the RHP (progress modal takes over from there — see Issue 6)

Read targetPolicyIDs and parts from ONYXKEYS.COPY_POLICY_SETTINGS.

Add the necessary translation keys.

Relevant design doc section: "[App] Page 3: Double-check".

Depends on Issues 1 and 2.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. self-assigned this
    on Apr 24, 2026
  2. added
    InternalRequires API changes or must be handled by Expensify staff
    on Apr 24, 2026
  3. self-assigned this
    on May 12, 2026
  4. self-assigned this
    on May 26, 2026
  5. mitarachim commented on Jun 2, 2026

    @mitarachim

    Deploy Blocker #92329 was identified to be related to the PR #91241 that attempted to fix this issue.

  6. mitarachim commented on Jun 2, 2026

    @mitarachim

    Deploy Blocker #92332 was identified to be related to the PR #91241 that attempted to fix this issue.

  7. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. melvin-bot commented on Jun 2, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  9. 25 remaining items

  10. shubham1206agra commented on Jun 29, 2026

    @shubham1206agra
    Contributor
  11. mallenexpensify commented on Jul 1, 2026

    @mallenexpensify
    Contributor

    Recommendation: no regression penalty. Every linked deploy blocker was demoted (none actually blocked a deploy) because the Copy Settings feature is gated behind the BULK_EDIT_WORKSPACES beta and never reached production users — which is exactly what the beta is for.

    @MelvinBot the above is partially true. We don't want any regressions because, even if they're on staging or in beta, the still require time and resources. I think a better litmus test to decide if the regression should lower the price of a job is "should the contributor and/or C+ have caught the regressions" With features being new it's more likely that, because it's new, it would be more difficult for teh C+ to have caught the regression (if at all possible).

  12. mallenexpensify commented on Jul 1, 2026

    @mallenexpensify
    Contributor

    @shubham1206agra please address the deploy blockers and fill out the BZ checklist once Melv has completed their review

  13. MelvinBot commented on Jul 1, 2026

    @MelvinBot
    Contributor

    🤖 Fair — I'll drop "behind a beta" as the deciding factor. Staging/beta regressions still burn CME, Applause, and C+ time, so the right question is your litmus test: should the contributor and/or C+ have reasonably caught each one? Re-scoring the four on that basis:

    DB Should-have-caught? Penalize?
    #92385 Not a regression. Reviewers (fedirjh/ishpaul777) agreed it wasn't a bug; re-scoped as enhancement (#91792, its own PR + payment). No
    #92397 Not this PR. Pre-existing known backend issue (can't remove bank / change currency on non-USD WS), not introduced here. No
    #92329 Backend root cause. The server reconstructs the rates; the App PR only sends parts and never touches rate data (CopyPolicySettings.ts:317-323), so neither code review nor a normal App-side test would surface it. Durable fix is backend. Lean no
    #92332 The one genuine App-side gap. The copy flow copied approval chains but not the default approver, producing a spurious workflow entry — that logic lives in reviewable App code (CopyPolicySettings.ts). Arguably catchable, but a subtle omission on a brand-new feature. Judgment call

    Bottom line under your test: at most one of the four (#92332) is a "should-have-caught" App regression. The other three are not a bug, pre-existing, or backend root-cause — and as you note, catchability is lower on a brand-new feature.

    Payment options for C+ shubham1206agra (base $250; fedirjh is a contractor, no payment):

    My recommendation: penalize at most #92332 (→ $125); lean to no penalty if you weight the new-feature difficulty heavily. #92329 / #92385 / #92397 shouldn't reduce payment.

    Final call is yours on the checklist.

  14. added and removed on Jul 1, 2026
  15. shubham1206agra commented on Jul 2, 2026

    @shubham1206agra
    Contributor

    @mallenexpensify #92332 is also BE issue. So, there should be no penalty here

  16. shubham1206agra commented on Jul 2, 2026

    @shubham1206agra
    Contributor

    Also, checklist is not required here as it should be covered under docs

  17. mallenexpensify commented on Jul 2, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @shubham1206agra due $250 via NewDot

  18. JmillsExpensify commented on Jul 12, 2026

    @JmillsExpensify
    Contributor

    $250 approved for @shubham1206agra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2InternalRequires API changes or must be handled by Expensify staffTask

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions