You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Scan - Merchant field shows "Scanning..." text when editing inline #88737
Version Number: 9.3.62-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#83127 Email or phone of affected tester (no customers):ijsjdnosijoisnjodsnjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.2 / Chrome App Component: Money Requests
Action Performed:
Go to staging.new.expensify.com
Go to workspace chat.
Create a scan expense.
Go to Spend > All expenses.
Open the expense.
Click Merchant.
→ Merchant field does not show "Scanning..." text.
Close the RHP.
Click inline Merchant field.
Expected Result:
Merchant field will not show "Scanning..." text.
Actual Result:
Merchant field shows "Scanning..." text when editing inline.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #83127 - "feat: Add inline editing for tables on desktop" by @mohammadjafarinejad (High confidence) Related Issues: None
Recommendation: REVERT
PR #83127 introduced inline editing for transaction table cells and directly caused this regression by passing the "Scanning..." placeholder text as the initial editable value for the merchant cell when a receipt is still being scanned.
Assigned: @mohammadjafarinejad (PR author), @ahmedGaber93 (approving reviewer), @puneetlath (approving reviewer) Labels: No label changes — DeployBlockerCash is correctly applied since the fix must happen in the App repo. DeployBlocker was not present.
Detailed Analysis
Evidence
The issue is reproducible only on staging, not production. The issue body explicitly states "N/A - new feature, doesn't exist in prod."
The bug manifests in the inline merchant cell specifically: clicking the inline merchant field on a scanning expense shows "Scanning..." as editable text, which is exactly the new behavior introduced by this PR.
PR feat: Add inline editing for tables on desktop #83127 also modified src/components/TransactionItemRow/index.tsx, which contains the getMerchantName function that substitutes the merchant value with translate('iou.receiptStatusTitle') (the "Scanning..." string) when isScanning(transactionItem) is true.
Root Cause
In src/components/TransactionItemRow/index.tsx, the getMerchantName() function returns the localized string "Scanning..." (via translate('iou.receiptStatusTitle')) when the transaction receipt is still being scanned. This string is passed as merchant to MerchantOrDescriptionCell as the merchantOrDescription prop.
Before PR #83127, MerchantOrDescriptionCell was read-only and simply rendered the text in a TextWithTooltip. After the PR, the component passes this text as the initial value to useInlineEditState, which stores it in localValue. The TextWithTooltip child now renders text={localValue} instead of the original text={text}. When the user clicks the cell to edit, it enters edit mode with localValue = "Scanning...", making that placeholder string editable and displayed.
The fix would require either: (a) preventing canEditMerchant from being true while the transaction is scanning, or (b) filtering out the "Scanning..." placeholder in MerchantOrDescriptionCell before passing it to useInlineEditState. Reverting PR #83127 is the safest option given the scope of changes.
getMerchantName() replaces the raw merchant value with the translated "Scanning..." string for scanning transactions. This display-only string is then passed as the initial editable value to MerchantOrDescriptionCell, which feeds it into useInlineEditState as the text input's initial value. So when the user clicks to edit inline, the input is pre-filled with "Scanning...".
The RHP doesn't have this problem because it reads the raw transaction merchant ('(none)'/PARTIAL_TRANSACTION_MERCHANT), detects it as invalid via isInvalidMerchantValue(), and initializes the input with an empty string instead.
What changes do you think we should make in order to solve the problem?
In TransactionItemRow, when the transaction isScanning, pass an empty string as the editable merchant value to MerchantOrDescriptionCell while keeping the "Scanning..." display text. This can be done by passing the raw (non-display-formatted) merchant through isInvalidMerchantValue() the same way the RHP does, so the edit input initializes with '' instead of "Scanning...".
Alternatively, disable inline merchant editing entirely while isScanning is true (set canEditMerchant to false), since SmartScan is actively populating the field — this mirrors how the RHP likely handles it.
What alternative solutions did you explore?
Sanitizing inside useInlineEditState — rejected because it would require locale-aware string comparison and is the wrong abstraction layer for this fix.
Checking in MerchantOrDescriptionCell directly — possible but less clean than fixing at the source in TransactionItemRow where the display vs edit value split should happen.
Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.
Activity
melvin-bot commentedon Apr 24, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #83127
melvin-bot commentedon Apr 24, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 24, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
OSBotify commentedon Apr 24, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #83127 - "feat: Add inline editing for tables on desktop" by @mohammadjafarinejad (High confidence)
Related Issues: None
Recommendation: REVERT
PR #83127 introduced inline editing for transaction table cells and directly caused this regression by passing the "Scanning..." placeholder text as the initial editable value for the merchant cell when a receipt is still being scanned.
Assigned: @mohammadjafarinejad (PR author), @ahmedGaber93 (approving reviewer), @puneetlath (approving reviewer)
Labels: No label changes —
DeployBlockerCashis correctly applied since the fix must happen in the App repo.DeployBlockerwas not present.Detailed Analysis
Evidence
Verification
src/components/TransactionItemRow/DataCells/MerchantCell.tsxTextWithTooltipdisplay to anEditableCellwithuseInlineEditState.src/components/TransactionItemRow/index.tsx, which contains thegetMerchantNamefunction that substitutes the merchant value withtranslate('iou.receiptStatusTitle')(the "Scanning..." string) whenisScanning(transactionItem)is true.Root Cause
In
src/components/TransactionItemRow/index.tsx, thegetMerchantName()function returns the localized string "Scanning..." (viatranslate('iou.receiptStatusTitle')) when the transaction receipt is still being scanned. This string is passed asmerchanttoMerchantOrDescriptionCellas themerchantOrDescriptionprop.Before PR #83127,
MerchantOrDescriptionCellwas read-only and simply rendered the text in aTextWithTooltip. After the PR, the component passes this text as the initial value touseInlineEditState, which stores it inlocalValue. TheTextWithTooltipchild now renderstext={localValue}instead of the originaltext={text}. When the user clicks the cell to edit, it enters edit mode withlocalValue = "Scanning...", making that placeholder string editable and displayed.The fix would require either: (a) preventing
canEditMerchantfrom being true while the transaction is scanning, or (b) filtering out the "Scanning..." placeholder inMerchantOrDescriptionCellbefore passing it touseInlineEditState. Reverting PR #83127 is the safest option given the scope of changes.MelvinBot commentedon Apr 24, 2026
Proposal
What is the root cause of that problem?
getMerchantName()replaces the raw merchant value with the translated"Scanning..."string for scanning transactions. This display-only string is then passed as the initial editable value toMerchantOrDescriptionCell, which feeds it intouseInlineEditStateas the text input's initial value. So when the user clicks to edit inline, the input is pre-filled with"Scanning...".The RHP doesn't have this problem because it reads the raw transaction merchant (
'(none)'/PARTIAL_TRANSACTION_MERCHANT), detects it as invalid viaisInvalidMerchantValue(), and initializes the input with an empty string instead.What changes do you think we should make in order to solve the problem?
In
TransactionItemRow, when the transactionisScanning, pass an empty string as the editable merchant value toMerchantOrDescriptionCellwhile keeping the"Scanning..."display text. This can be done by passing the raw (non-display-formatted) merchant throughisInvalidMerchantValue()the same way the RHP does, so the edit input initializes with''instead of"Scanning...".Alternatively, disable inline merchant editing entirely while
isScanningis true (setcanEditMerchanttofalse), since SmartScan is actively populating the field — this mirrors how the RHP likely handles it.What alternative solutions did you explore?
useInlineEditState— rejected because it would require locale-aware string comparison and is the wrong abstraction layer for this fix.MerchantOrDescriptionCelldirectly — possible but less clean than fixing at the source inTransactionItemRowwhere the display vs edit value split should happen.Next Steps for Contributor+ team: Reply with
@MelvinBot implement thisto create a draft PR,@MelvinBot <your feedback>to refine this analysis, or explain why you are rejecting Melvin's proposal.puneetlath commentedon Apr 24, 2026
Inline editing reverted.