Skip to content

[Due for payment 2026-05-11] [Due for payment 2026-05-07] Android & iOS - Spend - Date quick filter is missing when Date filter is applied #88946

Closed

Description

@jponikarchuk

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.62-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #85234
Email or phone of affected tester (no customers): sdsodijnosdjoij@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Search

Action Performed:

  1. Launch Expensify app.
  2. Go to Spend > All expenses.
  3. Tap Filters button.
  4. Tap Date > Custom range.
  5. Select custom range date that will return some results.
  6. Tap Save > View results.

Expected Result:

Date quick filter will be shown on search results page.

Actual Result:

Date quick filter is not shown on search results page.
A blank space is shown above the expenses.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

Video.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 27, 2026
  2. melvin-bot commented on Apr 27, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #85234

  3. melvin-bot commented on Apr 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  4. github-actions commented on Apr 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. OSBotify commented on Apr 27, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #85234 - "Introduce a Bottom Tab Navigator for Top-Level Navigation" by @WojtekBoman (High confidence)
    Related Issues: #85260

    Recommendation: REVERT

    PR #85234 introduced a significant navigation refactor that reworked the SearchPageNarrow component, and the static rendering optimization it introduced has a bug that prevents the date quick filter chip from appearing after applying date filters.

    Assigned: @WojtekBoman (PR author), @ZhenjaHorbach (approving reviewer), @mountiny (approving reviewer)
    Labels: DeployBlockerCash kept (frontend App bug). No label changes made.

    Detailed Analysis

    Evidence

    Verification

    Affected file: src/pages/Search/SearchPageNarrow/index.tsx

    PR #85234 modifies this file (confirmed via gh pr view 85234 --json files).

    The PR introduced a static/interactive rendering switch for SearchPageNarrow. When the screen is pre-mounted behind the right-hand panel (a new behavior introduced by the TabNavigator that keeps screens alive), useStaticRendering initializes to true because navigation.isFocused() returns false for a non-focused tab.

    In this state:

    • isHeaderInteractive = false
    • SearchFiltersBarSwitch receives showStatic={!isHeaderInteractive} = true, so it returns null
    • This means the date quick filter chip is never rendered
    • A blank space appears where the filter bar would be, because the layout still reserves space for the header via paddingTop: variables.searchListContentWithFiltersMarginTop (170px when hasFilterBars is true in Onyx) — but the actual filter bar UI is not rendered

    The isHeaderInteractive flag transitions to true via onSearchLayout, which is called from SearchStaticList's onLayout. However, when a date filter is active and the user returns to the Search tab, the focus-driven transition may not be completing correctly, leaving the filter bar perpetually in static (null) mode.

    Additionally, PR #85234 changed bottomContent from conditionally rendering !searchRouterListVisible && <NavigationTabBar> to unconditionally passing tabBarContent (a pre-created element outside the render function). While this specific change was subsequently partially reverted (the !searchRouterListVisible guard was restored in the current code), it indicates that the PR's changes to this file went through multiple adjustments.

    Root Cause

    The root cause is the new useStaticRendering / isHeaderInteractive two-phase rendering optimization introduced in PR #85234 for SearchPageNarrow. The optimization was designed to defer heavy rendering when the screen is pre-mounted behind a modal. However, when a date filter is active (hasFilterBars returns true), the SearchFiltersBarSwitch renders null during the static phase, creating a visible blank space. The full interactive render (which would show the filter chip) depends on isHeaderInteractive becoming true, but if the screen transitions to focus while still in static mode, the filter bar may never appear.

    This is a behavioral regression introduced by the TabNavigator architecture: in the old architecture, navigating to the Search tab always mounted the screen fresh. In the new architecture, the screen stays mounted and the focus transitions trigger the static→interactive switch, which can get stuck.

  6. 6 remaining items

  7. luacmartins commented on Apr 28, 2026

    @luacmartins
    Contributor

    Fixed. Closing.

  8. IuliiaHerets commented on Apr 28, 2026

    @IuliiaHerets

    Not repro on iOS as well, iPhone 13 iOS 26.3.1
    v9.3.64-10

    ScreenRecording_04-28-2026.12-43-35_1.mp4
  9. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. changed the title [-]Android & iOS - Spend - Date quick filter is missing when Date filter is applied[/-] [+][Due for payment 2026-05-07] Android & iOS - Spend - Date quick filter is missing when Date filter is applied[/+] on Apr 30, 2026
  11. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.64-31 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-07. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Apr 30, 2026

    @melvin-bot

    @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. changed the title [-][Due for payment 2026-05-07] Android & iOS - Spend - Date quick filter is missing when Date filter is applied[/-] [+][Due for payment 2026-05-11] [Due for payment 2026-05-07] Android & iOS - Spend - Date quick filter is missing when Date filter is applied[/+] on May 4, 2026
  14. melvin-bot commented on May 4, 2026

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.3.65-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-05-11. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on May 4, 2026

    @melvin-bot

    @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions