You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
The Floating Action Buttons disappears on Settings page after opening "Add address" modal. #88959
Version Number: 9.3.62-5 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from BrowserStack: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by:@dmkt9 Slack conversation (hyperlinked to channel name): #Open Source
Action Performed:
Prerequisite: The user is assigned a physical Expensify card and has not yet entered their personal information.
Open the application on a mobile device (or in a narrow layout).
Tap "Settings" on the navigation bar to load the Settings screen.
Tap "Home" on the navigation bar.
Tap the "Add address" button.
Tap the back button twice.
Note that the Floating Action Buttons disappears.
Expected Result:
The Floating Action Buttons should remain visible.
Actual Result:
The Floating Action Buttons disappears.
Workaround:
Unknown
Platforms:
Select the officially supported platforms where the issue was reproduced:
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Classification: Frontend bug Causing PR: #88726 - "fix: Tab bar remains visible when opening search from Reports page (mobile)" by @dmkt9 (High confidence) Related Issues: None
Recommendation: REVERT
PR #88726 introduced a regression where the tab bar (and Floating Action Button) can remain permanently hidden after navigating back to a root screen. The fix it applied was targeted only at the Search router case but the isBlockingViewVisible condition it added to the tab bar hide logic affects all navigation paths.
isBlockingViewVisible is driven by FullScreenBlockingViewContextProvider, which collects route keys from ForceFullScreenView and SearchPageNarrow (when searchRouterListVisible is true).
The PR itself acknowledges stale isBlockingViewVisible state as a problem: it also patched useSearchPageInput.tsx with the comment "This prevents isBlockingViewVisible from remaining true after navigating from the SearchRouter" — but only for one specific navigation path (search-to-report).
On mWeb (narrow layout), if the user previously visited any screen that sets a route key in the context (e.g. opened the search router and navigated away without the patched code path running), isBlockingViewVisible remains true.
When the user then navigates to Home and taps "Add address" (which opens ROUTES.SETTINGS_WALLET_DOMAIN_CARD), the tab bar is correctly hidden during navigation. But on pressing Back twice to return to the Home root, isAtRoot becomes true — however isBlockingViewVisible is still true from the stale state, so the tab bar (and FAB) stays hidden.
The affected platforms are Android mWeb Chrome and iOS mWeb Chrome, matching the narrow layout web path where the isBlockingViewVisible condition applies.
Verification
Affected file: src/libs/Navigation/AppNavigator/Navigators/TabNavigatorBar.tsx — the shouldHide condition that controls FAB visibility.
PR #88726 added isBlockingViewVisible as an additional hiding condition for the tab bar to fix a Search page tab-bar-remaining-visible bug. However, isBlockingViewVisible can become stuck as true in multiple navigation scenarios because the FullScreenBlockingViewContextProvider relies on route-key cleanup (via useEffect unmount or state change), which does not always fire in React Navigation's tab-based architecture where screens stay mounted in the background. When a route key added by SearchPageNarrow is not cleaned up before the user navigates to the Home tab and opens the "Add address" RHP, the FAB remains permanently hidden even after the user returns to the root screen.
@youssef-lr@ZhenjaHorbach@dmkt9 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
github-actions commentedon Apr 27, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Apr 27, 2026
Triggered auto assignment to @youssef-lr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 27, 2026
💬 A slack conversation has been started in #expensify-open-source
OSBotify commentedon Apr 27, 2026
Investigation Summary
Classification: Frontend bug
Causing PR: #88726 - "fix: Tab bar remains visible when opening search from Reports page (mobile)" by @dmkt9 (High confidence)
Related Issues: None
Recommendation: REVERT
PR #88726 introduced a regression where the tab bar (and Floating Action Button) can remain permanently hidden after navigating back to a root screen. The fix it applied was targeted only at the Search router case but the
isBlockingViewVisiblecondition it added to the tab bar hide logic affects all navigation paths.Assigned: @dmkt9 (PR author), @ZhenjaHorbach, @mountiny (approving reviewers)
Labels:
DeployBlockerCashkept (frontend App PR caused the regression). No label changes made.Detailed Analysis
Evidence
src/libs/Navigation/AppNavigator/Navigators/TabNavigatorBar.tsxto addisBlockingViewVisibleto theshouldHidecondition:const shouldHide = shouldUseNarrowLayout && !isAtRoot;const shouldHide = shouldUseNarrowLayout && (!isAtRoot || isBlockingViewVisible);isBlockingViewVisibleis driven byFullScreenBlockingViewContextProvider, which collects route keys fromForceFullScreenViewandSearchPageNarrow(whensearchRouterListVisibleis true).isBlockingViewVisiblestate as a problem: it also patcheduseSearchPageInput.tsxwith the comment "This preventsisBlockingViewVisiblefrom remainingtrueafter navigating from the SearchRouter" — but only for one specific navigation path (search-to-report).isBlockingViewVisibleremainstrue.ROUTES.SETTINGS_WALLET_DOMAIN_CARD), the tab bar is correctly hidden during navigation. But on pressing Back twice to return to the Home root,isAtRootbecomestrue— howeverisBlockingViewVisibleis stilltruefrom the stale state, so the tab bar (and FAB) stays hidden.isBlockingViewVisiblecondition applies.Verification
src/libs/Navigation/AppNavigator/Navigators/TabNavigatorBar.tsx— theshouldHidecondition that controls FAB visibility.gh pr diff 88726).isBlockingViewVisiblestate is managed insrc/components/FullScreenBlockingViewContextProvider.tsxand consumed byTabNavigatorBar.tsx.src/pages/Search/SearchPageNarrow/index.tsxwas also changed in PR fix: Tab bar remains visible when opening search from Reports page (mobile) #88726 to prevent one specific cleanup issue, demonstrating the author was aware of stale state problems — but the fix is incomplete.Root Cause
PR #88726 added
isBlockingViewVisibleas an additional hiding condition for the tab bar to fix a Search page tab-bar-remaining-visible bug. However,isBlockingViewVisiblecan become stuck astruein multiple navigation scenarios because theFullScreenBlockingViewContextProviderrelies on route-key cleanup (viauseEffectunmount or state change), which does not always fire in React Navigation's tab-based architecture where screens stay mounted in the background. When a route key added bySearchPageNarrowis not cleaned up before the user navigates to the Home tab and opens the "Add address" RHP, the FAB remains permanently hidden even after the user returns to the root screen.6 remaining items
youssef-lr commentedon Apr 28, 2026
Negative, #88188 is also not the root cause.
melvin-bot commentedon May 1, 2026
@youssef-lr, @mountiny, @ZhenjaHorbach, @dmkt9 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon May 5, 2026
@youssef-lr, @mountiny, @ZhenjaHorbach, @dmkt9 Still overdue 6 days?! Let's take care of this!
melvin-bot commentedon May 11, 2026
@youssef-lr @ZhenjaHorbach @dmkt9 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
dmkt9 commentedon May 12, 2026
@youssef-lr I think this issue can be closed as complete, as it cannot be reproduced on staging.