Skip to content

The Floating Action Buttons disappears on Settings page after opening "Add address" modal. #88959

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.3.62-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dmkt9
Slack conversation (hyperlinked to channel name): #Open Source

Action Performed:

Prerequisite: The user is assigned a physical Expensify card and has not yet entered their personal information.

  1. Open the application on a mobile device (or in a narrow layout).
  2. Tap "Settings" on the navigation bar to load the Settings screen.
  3. Tap "Home" on the navigation bar.
  4. Tap the "Add address" button.
  5. Tap the back button twice.
  6. Note that the Floating Action Buttons disappears.

Expected Result:

The Floating Action Buttons should remain visible.

Actual Result:

The Floating Action Buttons disappears.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome / Safari

Screenshots/Videos

ScreenRecording_04-27-2026.11-44-29_1.MP4
2026-04-27.22-35-35.1.mp4

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 27, 2026
  2. github-actions commented on Apr 27, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Apr 27, 2026

    @melvin-bot

    Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Apr 27, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. OSBotify commented on Apr 27, 2026

    @OSBotify
    Contributor

    Investigation Summary

    Classification: Frontend bug
    Causing PR: #88726 - "fix: Tab bar remains visible when opening search from Reports page (mobile)" by @dmkt9 (High confidence)
    Related Issues: None

    Recommendation: REVERT

    PR #88726 introduced a regression where the tab bar (and Floating Action Button) can remain permanently hidden after navigating back to a root screen. The fix it applied was targeted only at the Search router case but the isBlockingViewVisible condition it added to the tab bar hide logic affects all navigation paths.

    Assigned: @dmkt9 (PR author), @ZhenjaHorbach, @mountiny (approving reviewers)
    Labels: DeployBlockerCash kept (frontend App PR caused the regression). No label changes made.

    Detailed Analysis

    Evidence

    • PR fix: Tab bar remains visible when opening search from Reports page (mobile) #88726 modified src/libs/Navigation/AppNavigator/Navigators/TabNavigatorBar.tsx to add isBlockingViewVisible to the shouldHide condition:
      • Before: const shouldHide = shouldUseNarrowLayout && !isAtRoot;
      • After: const shouldHide = shouldUseNarrowLayout && (!isAtRoot || isBlockingViewVisible);
    • isBlockingViewVisible is driven by FullScreenBlockingViewContextProvider, which collects route keys from ForceFullScreenView and SearchPageNarrow (when searchRouterListVisible is true).
    • The PR itself acknowledges stale isBlockingViewVisible state as a problem: it also patched useSearchPageInput.tsx with the comment "This prevents isBlockingViewVisible from remaining true after navigating from the SearchRouter" — but only for one specific navigation path (search-to-report).
    • On mWeb (narrow layout), if the user previously visited any screen that sets a route key in the context (e.g. opened the search router and navigated away without the patched code path running), isBlockingViewVisible remains true.
    • When the user then navigates to Home and taps "Add address" (which opens ROUTES.SETTINGS_WALLET_DOMAIN_CARD), the tab bar is correctly hidden during navigation. But on pressing Back twice to return to the Home root, isAtRoot becomes true — however isBlockingViewVisible is still true from the stale state, so the tab bar (and FAB) stays hidden.
    • The bug is only reproducible on staging (version 9.3.62-5), not production — consistent with this being a regression from PR fix: Tab bar remains visible when opening search from Reports page (mobile) #88726 which is new to this staging release.
    • The affected platforms are Android mWeb Chrome and iOS mWeb Chrome, matching the narrow layout web path where the isBlockingViewVisible condition applies.

    Verification

    Root Cause

    PR #88726 added isBlockingViewVisible as an additional hiding condition for the tab bar to fix a Search page tab-bar-remaining-visible bug. However, isBlockingViewVisible can become stuck as true in multiple navigation scenarios because the FullScreenBlockingViewContextProvider relies on route-key cleanup (via useEffect unmount or state change), which does not always fire in React Navigation's tab-based architecture where screens stay mounted in the background. When a route key added by SearchPageNarrow is not cleaned up before the user navigates to the Home tab and opens the "Add address" RHP, the FAB remains permanently hidden even after the user returns to the root screen.

  6. 6 remaining items

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 28, 2026
  8. youssef-lr commented on Apr 28, 2026

    @youssef-lr
    Contributor

    Negative, #88188 is also not the root cause.

  9. melvin-bot commented on May 1, 2026

    @melvin-bot

    @youssef-lr, @mountiny, @ZhenjaHorbach, @dmkt9 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. melvin-bot commented on May 5, 2026

    @melvin-bot

    @youssef-lr, @mountiny, @ZhenjaHorbach, @dmkt9 Still overdue 6 days?! Let's take care of this!

  11. removed their assignment
    on May 6, 2026
  12. melvin-bot commented on May 11, 2026

    @melvin-bot

    @youssef-lr @ZhenjaHorbach @dmkt9 this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  13. dmkt9 commented on May 12, 2026

    @dmkt9
    Contributor

    @youssef-lr I think this issue can be closed as complete, as it cannot be reproduced on staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions